From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64679CE8374 for ; Mon, 30 Sep 2024 16:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D51FB28000C; Mon, 30 Sep 2024 12:59:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D02A7280003; Mon, 30 Sep 2024 12:59:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B53E928000C; Mon, 30 Sep 2024 12:59:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 923A5280003 for ; Mon, 30 Sep 2024 12:59:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 31DB51A080B for ; Mon, 30 Sep 2024 16:59:18 +0000 (UTC) X-FDA: 82622015196.19.C0F8E12 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 607761C0010 for ; Mon, 30 Sep 2024 16:59:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j87HO3X6; spf=pass (imf20.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727715431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qwExymp8z6/0tjlloTrSYWWOshTAEGnshQb8H1Fv5Cg=; b=ExbpD9WbMKKjIvKdBekWNgbmmi/zTuoWxv6Mf9AKveNrHwVaXDQS/iU6ZGSsidSlp+5UgJ vRYpe5NTm8B3vhDf1m/rq5x9OYtjeXW15wZxhZOQxje/VyBHBbvExyzvjkPixzwqu24WLq bseWXLq29K2PL2nboEGU5AfljeMA0MU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727715431; a=rsa-sha256; cv=none; b=7FeEBI+DkRZKo3PBtiAnj2/FdROf1lufnU8sR9J6ILkg7gHb1kU+ClZm+BmgdtPgAPJkvD 1VKW5zkgXN9FkFeSIpYH5Z3YpWRs1LU+PYEsf2rsRsSWGICWpakwU07E2mMC5UiWY2LDe1 p/D7Zs6A3oauCI9xAgIxS0NgIm7tDQk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=j87HO3X6; spf=pass (imf20.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6e2326896cbso30986827b3.3 for ; Mon, 30 Sep 2024 09:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727715555; x=1728320355; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=qwExymp8z6/0tjlloTrSYWWOshTAEGnshQb8H1Fv5Cg=; b=j87HO3X6XzA+JhV+qM61EFN/SSPITc9N7IrmhTf+0aApCqGj81KujxFbokwPLvhC+d 3RWXBQZK9Ss/vVIW4aLbyK3eezWQoN9dad9o8xMaKv2llbiU7p2wMOGu9SHp0BBx/w+c dlQgwxBC3y01lKSVPtFUZQs96tYAQirlKMf+UDUrGTx8VSHj5l3JYiK1MWmSWtHOm31n ce4TF52hddp23kcz1FVqPMj1F4rsikUpBTMRI+0jRXCx4B/lBGsZSpmXRDj5OHh1SfWi DzCq4yFpfZ5bDrd8JmtbLY7FBA1HCF/4+KNx8mZWh0YhRgkk0gMM52kRB89MW1oKj2QK darg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727715555; x=1728320355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qwExymp8z6/0tjlloTrSYWWOshTAEGnshQb8H1Fv5Cg=; b=QbJnjU9PSB0cu7KIdHRlC++ziYShH3XDLDGFAkBY7pnIgQHjy4v/Vl2fdvQdZfkI6Y rrGmXY4lPJ8agAi/zGtBa5XLoHDfcqyoYnCYlnIwbI3jw0CeiA00Pldg36fKlUViUrML bXagds+pyaJ/i24QYbGWHxMOS9aC2bYb7X75pwWR7DpRaUxCwESXWKRS5d03SF69yMMN 2AJqzDSpRU9Dhe4StWr8HHKAvTVvIDVGMZcWlzWAzk50NegNSgr4jKF44/o5ngRtkrLY EgVhvH+AfIkktTXf6AE3sluXdeZS9dY1i07PYwuVgnpLngAf1cthKElfx2vDOt9MI+BS St4w== X-Forwarded-Encrypted: i=1; AJvYcCUL7x7+J6QudeVTSCk5FR+3+cw7UOus2bHVabcWukMsp9wlFOUl/jY8Wb7gp9tUIB6YQ08/emakkw==@kvack.org X-Gm-Message-State: AOJu0YzloeeWD3Jjx+Ba8AdflTyinFhFPNoDP3LIDRYP9ussjxSNE16S rqUTtuTVoRYH5t1Aex6d2JWCDhtr5MhZP24oOlX+YF7MrNNMUGoR X-Google-Smtp-Source: AGHT+IGdCw6IHDEfxfOgc07NtnjK/791nXenJL9nHV1zg9PEk+IYfqHNVrUbSJV0U1xsPpgO/Vpxgw== X-Received: by 2002:a05:690c:2512:b0:6e2:2600:ed86 with SMTP id 00721157ae682-6e2475e320amr59611887b3.45.1727715555187; Mon, 30 Sep 2024 09:59:15 -0700 (PDT) Received: from fan ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e2452f7e13sm14583537b3.26.2024.09.30.09.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 09:59:14 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Mon, 30 Sep 2024 09:58:53 -0700 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, jgroves@micron.com, vsalve@micron.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v12 09/17] cxl/mbox: Add SET_FEATURE mailbox command Message-ID: References: <20240911090447.751-1-shiju.jose@huawei.com> <20240911090447.751-10-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911090447.751-10-shiju.jose@huawei.com> X-Rspamd-Queue-Id: 607761C0010 X-Stat-Signature: kb17a3suidis5wrmbyr4mmb1tnzeomnk X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727715556-132188 X-HE-Meta: U2FsdGVkX1+gefkTgVwkX2tVqL6DbbbIfACW1A6mZxG8VgTIjk3ClwaYoY+ijiT6JwWA4Z/Ae6I+b0mFrZYclMQyTlkcMy6DAJwzAsLGH3DXlvWUDqMA7crqD9OXHx/cqX2QPDw6vn6H1zvlR8w+VYVwPJZMngBZrgofi1iH/cV3ve2LC8pPBk+2QURWTTEDmJgEEEossnA+ueLLW2va+jnrKIui5FhXYezysOIw4eOwP7GYEKcsFL4KX8U1QNLtiWR2dfIGo3umXqkUFEyF9qU9nZ3W8hvQCIw6yOq12V0L38mjAzCUIEJfQbAa5QnQJVlXWpmb2J+lpeKCZlCTKlwwEU631kcC2n0NcEgpJlGzMHbmcTDOSjYcXx7qrh852UbHSGjd+LVUvpAkiE3qpOBACCQd/xVQFtLcSvhzg8MA6lSXq3VpfuNkhKMyiZ3q+ybtcwakzEq3ocy1tZWQUX+m3a5tf5gERhjM66xtW0GrWxPSz+faN1+mS3+vVz5h9fWyiIsuTq6eCdGd6jjYvbXk8+ACPGY76Iu4/jLV7VnjLyp9G+Bw/N5tONLdtUPDJ2TaGvfeCaUqufy2SQPXW6x+Yals7y9Rr7TahkcZOfDRcyKEQeoVnbQVz1z8ABxVB3kXsv1qjc6YjTSgM8O1lw+/C+NDT5yNF5W8FwHPAkSg7YZ+ZSOfuO9d8tVQnHZeZ4vnk6Wv80CcO1csgn2f/qH3bzwXbonm8Pd94HxV+bfAl2YtHfYy1FGJIsvKyELq4dXsaUZLRphfiB3HFTfEneof47lEW9MwQMJ7IwmKkIHWZ/KU6/hlQGd4XivEUoQsyyp6FbjIvI8q/uG8emXTdOJoTzqZrDtuiKAC+JgCmpJcbmm/OGtaSmah2Uq9yZxy5yaBuLbi6PZOD09Cp2JGvWR/dzzP6oZCqWIQwLCeMc1hG8yv8VBzEefxJpBrVOy3CddALVHaZxw5KXtZi7a Enhp29f3 gIhiRSyte0ufEyUj95+SI9kh+xVDmWJ06kP77HAUG8uTaflQ6Yykjdr9/DPdj7dIQFRKQJVUieWNY4MLpRI8pY1LpFiQV4ZDidscl3u0bxLyboUzBqNEquGlrBaNWMRTo1gxJni4abSRt1e7cjXW6V8r3lqg1KDwFew5O3naS9/gPCvEWt1Ntlm9HS7Q8/gTVZEipWxBIrs3NrsFPDbpGZyxSCb9DNtniwn1LoEnk0uz8MAcw8ju8NOgasa7XJ/imQvMrzyqPCEbstsY767zedF4G1F5l9O2chVEY2OUD1TsgVDh/wPX/QHSBlhs/AaUziCHdFu1TOTRuDFQ1FR5v/iLwlLzzCv0eFOkMnhV11niGLeeYvHwibjQ2RESSRc9npTl22dPZV/qkdxw7663McDr6hYN+7lxQXbmnBHIxZI49CQ1krqE7wa1mANvD6360MgBgA85EP1FOL0w2G31EiulswXXEFJaUhzexsYXBtd8J0bkZ0iAcpmW2pPmc+xAFdha4lUH1Hl7AeZudWmV8/jN/ArJz0O6UNBKDk+CfH5/BhLsx3OzfrnhrOEC5TxzdRG4X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 10:04:38AM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for SET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices supports features with changeable attributes. s/supports/support/ Fan > The settings of a feature can be optionally modified using Set Feature > command. > CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/mbox.c | 73 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 34 +++++++++++++++++++ > 2 files changed, 107 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 3dfe411c6556..806b1c8087b0 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1006,6 +1006,79 @@ size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > > +/* > + * FEAT_DATA_MIN_PAYLOAD_SIZE - min extra number of bytes should be > + * available in the mailbox for storing the actual feature data so that > + * the feature data transfer would work as expected. > + */ > +#define FEAT_DATA_MIN_PAYLOAD_SIZE 10 > +int cxl_set_feature(struct cxl_dev_state *cxlds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag) > +{ > + struct cxl_mailbox *cxl_mbox = &cxlds->cxl_mbox; > + struct cxl_memdev_set_feat_pi { > + struct cxl_mbox_set_feat_hdr hdr; > + u8 feat_data[]; > + } __packed; > + size_t data_in_size, data_sent_size = 0; > + struct cxl_mbox_cmd mbox_cmd; > + size_t hdr_size; > + int rc = 0; > + > + struct cxl_memdev_set_feat_pi *pi __free(kfree) = > + kmalloc(cxl_mbox->payload_size, GFP_KERNEL); > + pi->hdr.uuid = feat_uuid; > + pi->hdr.version = feat_version; > + feat_flag &= ~CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK; > + feat_flag |= CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET; > + hdr_size = sizeof(pi->hdr); > + /* > + * Check minimum mbox payload size is available for > + * the feature data transfer. > + */ > + if (hdr_size + FEAT_DATA_MIN_PAYLOAD_SIZE > cxl_mbox->payload_size) > + return -ENOMEM; > + > + if ((hdr_size + feat_data_size) <= cxl_mbox->payload_size) { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER); > + data_in_size = feat_data_size; > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER); > + data_in_size = cxl_mbox->payload_size - hdr_size; > + } > + > + do { > + pi->hdr.offset = cpu_to_le16(data_sent_size); > + memcpy(pi->feat_data, feat_data + data_sent_size, data_in_size); > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_SET_FEATURE, > + .size_in = hdr_size + data_in_size, > + .payload_in = pi, > + }; > + rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + data_sent_size += data_in_size; > + if (data_sent_size >= feat_data_size) > + return 0; > + > + if ((feat_data_size - data_sent_size) <= (cxl_mbox->payload_size - hdr_size)) { > + data_in_size = feat_data_size - data_sent_size; > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER); > + } else { > + pi->hdr.flags = cpu_to_le32(feat_flag | > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER); > + } > + } while (true); > +} > +EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); > + > /** > * cxl_enumerate_cmds() - Enumerate commands for a device. > * @mds: The driver data for the operation > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 57c9294bb7f3..b565a061a4e3 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -488,6 +488,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_GET_FEATURE = 0x0501, > + CXL_MBOX_OP_SET_FEATURE = 0x0502, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -835,6 +836,35 @@ struct cxl_mbox_get_feat_in { > u8 selection; > } __packed; > > +/* > + * Set Feature CXL 3.1 Spec 8.2.9.6.3 > + */ > + > +/* > + * Set Feature input payload > + * CXL rev 3.1 section 8.2.9.6.3 Table 8-101 > + */ > +/* Set Feature : Payload in flags */ > +#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) > +enum cxl_set_feat_flag_data_transfer { > + CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER, > + CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX > +}; > + > +#define CXL_SET_FEAT_FLAG_DATA_SAVED_ACROSS_RESET BIT(3) > + > +struct cxl_mbox_set_feat_hdr { > + uuid_t uuid; > + __le32 flags; > + __le16 offset; > + u8 version; > + u8 rsvd[9]; > +} __packed; > + > int cxl_internal_send_cmd(struct cxl_mailbox *cxl_mbox, > struct cxl_mbox_cmd *cmd); > int cxl_dev_state_identify(struct cxl_memdev_state *mds); > @@ -901,4 +931,8 @@ int cxl_get_supported_feature_entry(struct cxl_dev_state *cxlds, const uuid_t *f > size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, > enum cxl_get_feat_selection selection, > void *feat_out, size_t feat_out_size); > +int cxl_set_feature(struct cxl_dev_state *cxlds, > + const uuid_t feat_uuid, u8 feat_version, > + void *feat_data, size_t feat_data_size, > + u8 feat_flag); > #endif /* __CXL_MEM_H__ */ > -- > 2.34.1 > -- Fan Ni