From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 206C5CE8360 for ; Mon, 30 Sep 2024 16:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DB92280008; Mon, 30 Sep 2024 12:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C4D280003; Mon, 30 Sep 2024 12:18:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C33280008; Mon, 30 Sep 2024 12:18:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40396280003 for ; Mon, 30 Sep 2024 12:18:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E914DAB768 for ; Mon, 30 Sep 2024 16:18:29 +0000 (UTC) X-FDA: 82621912338.30.7E317A6 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf28.hostedemail.com (Postfix) with ESMTP id DC42FC000C for ; Mon, 30 Sep 2024 16:18:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="WqKfbF//"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727712968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2l5r1LZwEKOpEY2ktEbhSxXVhypzkb5WeDgzsoyHkvo=; b=bvVIIs0ZVLFOGOfsJ0ZJgoZFkoW1EL1bhdlkDhvB++hw1gRqYxaTTiZiI84SlNCEyjFvXk TWEPB4NhDP6w8n8bHYIBnfsbd3b/j0Xwlr+QyvBBO9FOqjdB+86V2LsF0K5NHvrUtfZakj QbEtcMtWppjQjdr6ZeoKuxSHk/ouLOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727712968; a=rsa-sha256; cv=none; b=KmPrAhtmUMSDHaJYZ2kfgwovFznTlFg+CZClGb/8nEcvhfHfJ/fpMorGHIv3zXm184xR87 7bhBUDP5rpeJXh97eTbo5xswgDZf7h2xemX9Ir1zFJFi/5xjs1yufS/XtpVsb2cfyds/bh 8TdohPeKKn5tsMd4F9tIWIg74slkQgw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="WqKfbF//"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-e1d4368ad91so4489238276.0 for ; Mon, 30 Sep 2024 09:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727713107; x=1728317907; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2l5r1LZwEKOpEY2ktEbhSxXVhypzkb5WeDgzsoyHkvo=; b=WqKfbF//g03StUQd3W0nXbu8JdXTfY6aDgG/Y0EwOVgbdD4XPxd0IncaeaDfbeHbbB rP28eKWrJ50Z40ZnaS2KhpGRGnRN0ww5eIu7cdR+bX8fd/Sq1wwWjqilIiSpXjMKHI67 LVxQi+QWvdVk+Gm6FwWuVJkB+eyNKk4GNlBnxmHNG/UMDyIX6ZkLQzLKOGVUz2/spfbU piLI2qYPY06qWqKh5NbmGjfIo0wvj6j/19SeiPeMUhNVSUy2gg70unRA7WUPj7JBku1U G0nNvwaU0A5NG1oD/andzSlGvK9lVCjjzgI62uautTJcDYCFI3hMbAaUmAfR0SedJ4vH lPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727713107; x=1728317907; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2l5r1LZwEKOpEY2ktEbhSxXVhypzkb5WeDgzsoyHkvo=; b=ogjHAITEPCgwhH+hHf6QnmI3mZ56glRp5fZDMpTfqa+6vWyewLTYGWlh7GM1Kf4rZH YqFmfCqxtrAbW4ZjgsaWyVux+4rKZbgijNrrAdIIrBKouFKoWfEitjV++B5okMchHto2 WOM/oGYpLEeVzE1uAb7RcLlumCNvZH2Alh8DRjhPLA1oAevNKleSlPiumrEUN5IlOOCS E3o4/KtlYDt0iIW9DPPiX+jumIrBd/vC4owd807QbOA3mxEKQTcPspEYQWDmW35rsw2v 1USjR+L652nTOUu4akADhUEOjYsJeLQxZiSCiPe3vodrOImXsePXpzrdEUR/wT7JRQrX 8FGA== X-Forwarded-Encrypted: i=1; AJvYcCXSf0rPXvsTxg8ZbufTeea5PTOEhAGgLMMO0VgbYQ1Hgx49Kd/nkeEEJhEhAI11KjJ7cb+HUsprog==@kvack.org X-Gm-Message-State: AOJu0YzSl3wyWASQD29kcvx+FU49lzqswRm9sGH7skVpQkMZjTA+NxUA mLV0HOmn7HvWh6ObkyQcLXfrz3UddFQSkwHseiA90BybWkJ4PPzb X-Google-Smtp-Source: AGHT+IFl5Gjgwu84SmuI/bp1yeHjyf2HoU9EbS4VxR8UrDamisJDdtS97rTLsocKl2LAstlAiPJnCQ== X-Received: by 2002:a05:6902:e89:b0:e1d:91d4:3ddb with SMTP id 3f1490d57ef6-e262c06c4f1mr167736276.20.1727713104683; Mon, 30 Sep 2024 09:18:24 -0700 (PDT) Received: from fan ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e25e42207b9sm2419546276.33.2024.09.30.09.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 09:18:24 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Mon, 30 Sep 2024 09:17:55 -0700 To: shiju.jose@huawei.com Cc: linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, jgroves@micron.com, vsalve@micron.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v12 08/17] cxl/mbox: Add GET_FEATURE mailbox command Message-ID: References: <20240911090447.751-1-shiju.jose@huawei.com> <20240911090447.751-9-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240911090447.751-9-shiju.jose@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DC42FC000C X-Stat-Signature: qfpibp4fytrpr3qzyhd7n7bmgdqgcia1 X-Rspam-User: X-HE-Tag: 1727713107-492406 X-HE-Meta: U2FsdGVkX19nBSKkVsp/QDsloGx1aDL5T4W6O6rXuF5aUdZ0XLAj8U70u89iueg5WBC/HEwYwEsk3fJlW2TI610zDuiNyQnH86y5tllWqc3gPHCdBCRhr/TwCGmkhtp/GRqvnUgUUnWdEY1ihuICDIg8xg1w+4Rt5eG/l5phlytNqc4HP/YZjN4IZ8MMLsjwWcT6A/bSvY8yP30f2fK2e1sz9BHJXM2JQVCB6+HCeZ5AI+WoT34NL8p7d/yqau5XnA1nQcGZewHaxOsq5PVMoD5xD+9csP7L/Mhavcm8IJOZdSs1s0wRNu1uICdjuYrAS5VyxJ3sQDDExcmYL5T3QZn0r4+/JoK5grZyNw1mpD8fhJNetj/n70TCT9p1zi9FpPlYP1cKYBf2WYmDoc2fl+qj+htZpvomDO+W5qwCUyB3WQFz+wtLc4oCjlvkKnQUKiROkleqdhw/mulf71T7u47ej6VM258MIgOvy7DvhUovaBOeGk3InwsiPMUBPQAv7PDpz9nYtZhwvWMGXdTrD33f/dHstesfaMv/n5n8qF63aD7IeS6+jq74yn2GU7NByTkf/QxHjmKs6QWZ6MoUv/GE6PtJNlq9Ywlf8ETW3L+JJSy0wszyHJlXAXY2pKshgQ5dM7Esh4zpgOQrfB1KINJxJl7SJ603ZnQQx/X6Ak3854R4QKT1K2usvsByfcEEZG0qM5RZ5Bj+RyEJrOgWsbFQEcEmhC6kyZqUDlWs/sBoZn6U+6QaPtdyrCtdw6oX3tKIcmaSeroQeAKc8VtQfHmOyooO0eO26kzPh4genk+AU3mxMbkQQxII9x84Lgh9fijWMTN9KTVhbgbAC2PcwlzWMXqanWM4qWmVvvD5NZ6JkorCzOEqSQ0h1eYdZK0SwqyoXercG+uebrf92JGAv8gnFSS2Y8x1ptFfXZP+2Cxy8r4V37K5zaAHc+pLVh+lvcYJ6xybaxGhb/uM4A2 z4Ertn5G Ff6koeiflBq0vBgcgG17WRlVnoPf7Fh1/sz9vyUXx75364moIbVMJRGF8VXCrgW48brxbKnlG8x+9OuXf+7HYLyKP7azaYoBELKMyj97ejhy5hHatcIGhvhE5IJW4BNSwsz78lGnfmRmhGTGXuSndobLS5vp2QLhUsuu9qLwNGvcSMEr9pBvJz3ApQ3BrvJWT7MhRsDTrJfJRsm8tMSwM5C+cUn3WbEN5A9Q9A7OSXo43OH1hY32nIRXY2jrpJ2C8NcmTZ8W5St0Lt97Z11PaYGM3AJvmLRwObuLZUozeO8iIWLJfhk/Eb4ryO14rDqyh6K/q4rMGZEn9vjvZWnzf9F8w5L+dx4N52fQNMrWgwb4wbHezKtWBovLoFu5OlZxQdXdZhHnKqAiJFjx6mD2WB0iymMM513ezUUiIDajzfkIjchjmzIPj4lPCDZIngIG6PGOPoHrMfZmleKcHWIsNiWDM0lzPAjvEmE3EgpJtxMK3VLSnsdQ0Y2p/+AXWKNuPFkdHJo2q6TCc6yI0Tsk5GNs5L1vYAEQt21UdaGlOHxo7qsMqtmCT3ikhEb6o746UBF5lQGQXxQVCiH/YEMwZWQuFnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 10:04:37AM +0100, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add support for GET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > The settings of a feature can be retrieved using Get Feature command. > CXL spec 3.1 section 8.2.9.6.2 describes Get Feature command. > > Signed-off-by: Shiju Jose > --- Reviewed-by: Fan Ni > drivers/cxl/core/mbox.c | 41 +++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 67 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index fe965ec5802f..3dfe411c6556 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -965,6 +965,47 @@ int cxl_get_supported_feature_entry(struct cxl_dev_state *cxlds, const uuid_t *f > } > EXPORT_SYMBOL_NS_GPL(cxl_get_supported_feature_entry, CXL); > > +size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, > + enum cxl_get_feat_selection selection, > + void *feat_out, size_t feat_out_size) > +{ > + struct cxl_mailbox *cxl_mbox = &cxlds->cxl_mbox; > + size_t data_to_rd_size, size_out; > + struct cxl_mbox_get_feat_in pi; > + struct cxl_mbox_cmd mbox_cmd; > + size_t data_rcvd_size = 0; > + int rc; > + > + if (!feat_out || !feat_out_size) > + return 0; > + > + size_out = min(feat_out_size, cxl_mbox->payload_size); > + pi.uuid = feat_uuid; > + pi.selection = selection; > + do { > + data_to_rd_size = min(feat_out_size - data_rcvd_size, > + cxl_mbox->payload_size); > + pi.offset = cpu_to_le16(data_rcvd_size); > + pi.count = cpu_to_le16(data_to_rd_size); > + > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_GET_FEATURE, > + .size_in = sizeof(pi), > + .payload_in = &pi, > + .size_out = size_out, > + .payload_out = feat_out + data_rcvd_size, > + .min_out = data_to_rd_size, > + }; > + rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd); > + if (rc < 0 || !mbox_cmd.size_out) > + return 0; > + data_rcvd_size += mbox_cmd.size_out; > + } while (data_rcvd_size < feat_out_size); > + > + return data_rcvd_size; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > + > /** > * cxl_enumerate_cmds() - Enumerate commands for a device. > * @mds: The driver data for the operation > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h > index 5d149e64c247..57c9294bb7f3 100644 > --- a/drivers/cxl/cxlmem.h > +++ b/drivers/cxl/cxlmem.h > @@ -487,6 +487,7 @@ enum cxl_opcode { > CXL_MBOX_OP_CLEAR_LOG = 0x0403, > CXL_MBOX_OP_GET_SUP_LOG_SUBLIST = 0x0405, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > + CXL_MBOX_OP_GET_FEATURE = 0x0501, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, > @@ -812,6 +813,28 @@ struct cxl_mbox_get_sup_feats_out { > struct cxl_feat_entry ents[] __counted_by(le32_to_cpu(supported_feats)); > } __packed; > > +/* > + * Get Feature CXL 3.1 Spec 8.2.9.6.2 > + */ > + > +/* > + * Get Feature input payload > + * CXL rev 3.1 section 8.2.9.6.2 Table 8-99 > + */ > +enum cxl_get_feat_selection { > + CXL_GET_FEAT_SEL_CURRENT_VALUE, > + CXL_GET_FEAT_SEL_DEFAULT_VALUE, > + CXL_GET_FEAT_SEL_SAVED_VALUE, > + CXL_GET_FEAT_SEL_MAX > +}; > + > +struct cxl_mbox_get_feat_in { > + uuid_t uuid; > + __le16 offset; > + __le16 count; > + u8 selection; > +} __packed; > + > int cxl_internal_send_cmd(struct cxl_mailbox *cxl_mbox, > struct cxl_mbox_cmd *cmd); > int cxl_dev_state_identify(struct cxl_memdev_state *mds); > @@ -875,4 +898,7 @@ void cxl_dpa_debug(struct seq_file *file, struct cxl_dev_state *cxlds); > int cxl_get_supported_features(struct cxl_dev_state *cxlds); > int cxl_get_supported_feature_entry(struct cxl_dev_state *cxlds, const uuid_t *feat_uuid, > struct cxl_feat_entry *feat_entry_out); > +size_t cxl_get_feature(struct cxl_dev_state *cxlds, const uuid_t feat_uuid, > + enum cxl_get_feat_selection selection, > + void *feat_out, size_t feat_out_size); > #endif /* __CXL_MEM_H__ */ > -- > 2.34.1 > -- Fan Ni