From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D116ACF6498 for ; Mon, 30 Sep 2024 02:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 573438000D; Sun, 29 Sep 2024 22:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 523B580009; Sun, 29 Sep 2024 22:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C4998000D; Sun, 29 Sep 2024 22:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B19880009 for ; Sun, 29 Sep 2024 22:09:48 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D404C80647 for ; Mon, 30 Sep 2024 02:09:47 +0000 (UTC) X-FDA: 82619773614.19.69AEE1A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 4A4FF14000A for ; Mon, 30 Sep 2024 02:09:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ct16NQPZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727662094; a=rsa-sha256; cv=none; b=OsZFBlWYqHCaxiMVNVDK2Z4utBO456UgZ6UBPlESwoKlxreZmIS3xb72hyg1T707uofZVR 1TeS6kjEaAH+YjHbw0YvSpb34NxRJwZkTy0EZyBPspAxrjTE/7YMhomJrLsMJ+RVkoi/gH mmmLVwYI8yjVr08IkjXdfr58M3rlkVA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ct16NQPZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727662094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n4Cgh2YTy3+PY0PMaamuNgHUsn0rgzEhDI8UMrYtsWI=; b=uEP/TvbozycL5lVo+TGIbhsXthegVkD9jyKfOBh0em/UikvSCFK6xOw5u9ml0TVUTGqYlg JhCIkThA1C3bOLIFESa/fTiIIW3mAzTGxJVlbR26igNr2e0/bF1qAjbbwGE6TjVxFwM3LH 9PcuXA8mfMr69AMxSK1OHrB96xqxZCo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 62DF1A40EFF; Mon, 30 Sep 2024 02:09:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71D25C4CEC5; Mon, 30 Sep 2024 02:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727662185; bh=8qMICbzT4XtRFiL9y52Kc0zRBSFZP7xkacMj3/zADPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ct16NQPZWfiUZ8/FMrxohrlQowfYn1wUM+qQKvQjD0RPu/xTzonbu6WZ3KoGGG3jL Ku6qi5H6jXmHT+ph7KgUkreOZRvhnjoJORWFNUnjxLr6j3tuDfRGeJVIl8aX7uWc6u Bfy2Cg8tDTVc1J2awGQj08t+4DIx4UQJKbVnJBp7IeKiL21KBk67oL+7LwkLJDeyJS AeQ9YykyrZsJ92TPmEfa33L7K0C3ZGoP4JmE0RIVOG8lzlv17nc5q2WUCiptduwyV0 yXoP7Uj4EDkGYZxVPza0NdUI/ZKQ3ku2gUDGSJfYlh4fLxXED6Wx6exvv/7Z64vtT6 ita4tr3SIddGw== Date: Sun, 29 Sep 2024 19:09:41 -0700 From: Namhyung Kim To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo Subject: Re: [RFC/PATCH bpf-next 2/3] mm/bpf: Add bpf_get_kmem_cache() kfunc Message-ID: References: <20240927184133.968283-1-namhyung@kernel.org> <20240927184133.968283-3-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4A4FF14000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3pnbdoh13nhsran4htk1dnmdg48kac3r X-HE-Tag: 1727662186-8740 X-HE-Meta: U2FsdGVkX18T+1zFycCcSHIooxwAoYRNx9BDphmtVUDQEJe5S/WwsGyYjKl7B4t/fXA3LKfatQro7l2g19BbasD5XOqpOBQuLSAUXVJLq14g3I6wZkyIfYsf12G/y97zkNkUVWLMxMYQEp40FpdczJmD3MDqQ3h69vfKFub+Lz9xko+Z/nlBsO4VN8zwFDJHrcIHwUCUr7mVqc7VogQVHC10N1JJt77kr23DQAYMdrQqz1zcOsIWJ/EtOcdMHkKKEWFux+EH7YVk++yzZ6rDQ2yFWefAdVXgYfeP5i21JjGxMRGvhPL1vGY1tLFF6G6Uc7Lx4G6cQ5+LgkK9iiZBJRiUDaFnSg7llARKiTAu+zR/QPtTuXNTndZL1AtJk53Hn9fOIGvQtT74FyBF6DsoPRWNpk4pWwBw6sICoh68D2a9+TCI6KJECMzUWk23vitknqi4y3XxnuTGAuQZUiC1EubSQ6AN688jeQmXQec3Uk/6/1H604ZzScp8t2ej/oGcCc7g97EHci5y/3nRV2mdhIcjKoYiYJ8q4IWrkKCxXiHKDUm0sDwZI3iz9/2G+a5XtibxWo+ad0RWKMoS+cwpLSf7EDTyIzDL3rF0VwZP+raeOpR4kFywl7LmIfUlbAgah10I53gTtXPKnSGWyZeRKtS5l/BVG4GGF09iYsSL0lI2jYzeI+HkTlzJmTGElaHlqGg/RMUdzdgaUjufadT21o0edmL/yDPBBvsvITL5eSGaTZLJC4uPFbzVZ2j1ZWW1T4HfPZNy5l/BMEyebJTz+sipcyMHWBUZQSxEqI0nwHZMIFq+vLk62uawqY89QsBDDouh50tHXrQmAlB47IXdnGwzjWHA6BvcY3c6q6tzhv3NhvEGDijBKB6j4x/OKwjlK3jvYwovUh2MmkqGgZ+WthzWKYuFAKJyj1qQ5hNGZ4D4cqWh6REUaJjPpTNVpyHO7Ez9B85vnZVv9zS+vGd gzA/9MjW 33AOS/pI3FJkTp1r/GH26WFiHGPerDK8iGtvEIi86xXMyhGOgN8VfUYFnqSab+4XVPqPjKKqoKxukO6bkNzo9C2hgNDGCr600WjPLSrw9cBXOODWFG1yK4yif+lvyqcztLQq71VTdomiNr7ybTkpo8RSSIZkWvJ56Lycp58/7QA4HiN4YvFBkP6j1T21RHzgmDuBoG6OXHIxLl7NryAmSkGlfto/SA5bWrPX1A+d/Md7mfIZIbXDJO2Ez+ZLba4fHl3G05Uijp+LZz8xvvdL2SXluxO1HW+6ejY+QW5/PE/sq2mUtOLWj2sVhccrQ0jBhQIYJa4K1yKZJcJGnL5TsTGTM6BsIIgYqXLqtk3l/xW5DK8rLUDaD8x/cwg+SGMFu7SJqqhyCWjDM5IiRvPoUXN43yxGBwrcF6Ove X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 29, 2024 at 10:05:42AM -0700, Alexei Starovoitov wrote: > On Fri, Sep 27, 2024 at 11:41 AM Namhyung Kim wrote: > > > > +__bpf_kfunc struct kmem_cache *bpf_get_kmem_cache(u64 addr) > > +{ > > + struct slab *slab; > > + > > + slab = virt_to_slab((void *)(long)addr); > > + return slab ? slab->slab_cache : NULL; > > +} > > I think this needs more safety guards on 'addr'. > It needs to check the valid range of 'addr' before doing virt_to_slab. Ok, I think we can use virt_addr_valid() for that. Thanks, Namhyung