From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA482CDE030 for ; Fri, 27 Sep 2024 12:30:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 309506B00B0; Fri, 27 Sep 2024 08:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 291F96B00C9; Fri, 27 Sep 2024 08:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1335B6B00D6; Fri, 27 Sep 2024 08:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E4FBD6B00B0 for ; Fri, 27 Sep 2024 08:30:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8AD43120B64 for ; Fri, 27 Sep 2024 12:30:07 +0000 (UTC) X-FDA: 82610450454.04.6D0FD3E Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf15.hostedemail.com (Postfix) with ESMTP id 9601AA0002 for ; Fri, 27 Sep 2024 12:30:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sGYFe9qA; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727440069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3KPffXxGN0FIhLP5f2K/FrqF2RGS6QdxDbR1ndTZX0=; b=c85jKkDnpuxJpMo3HLaP/Ic/aH7pwQuNCQ5GEsFWQiMWeqdkvIM0rtAR2lbE9YMrXIyYdw DGLvee4eyVwagormhs/K0UgLucxbRonZlNQTUM/2KEo8vazhuq1nelE2CA9d26jB56KN5h 7YTQfS1JcckR5bT3i+45fXEeukPlU3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727440069; a=rsa-sha256; cv=none; b=rMrTVZz+/Mopj4hDGnDk2TRU986P6rSDZNNSQ/i7cvLbR24seF15Sqr+q2Vauw/pLmoOYT hREr1zehUc/nJNM7YywmWeR5UUlA0ElyltNoUbImt/XCj0z5wTu3NmxvbrSj5YfLlYvd7T QPw8+rvvMl7cqk0xfw6snlVBWLb1Vf8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=sGYFe9qA; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48R26XTD005581; Fri, 27 Sep 2024 12:29:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=pp1; bh=X3KPffXxGN0FIhLP5f2K/FrqF2R GS6QdxDbR1ndTZX0=; b=sGYFe9qAb/CiVmT4JsSABkFSS1iewD180v/BmBSG1tx aSMKrjKxF+MOqGzv+5hc9KigJpdY2e3K6eIumU1MNSsK3qB/HOnHeajJNqxzg/a5 MdnYFUPK5gKSRKskepU17H87XqAn+5YL0VPxKQU7A2/8wQTfMPFqEh9fu4+HSGgg lSASwpn9GFduHZfSXDk5jxHMZTUVh0yFNcPcLflHvzF3qTGM2L/WTtKDL9z6BSWE 74VHjrADXjwIlBVQKNHGGRvOjcUWwj8MvY+3OE/BCW7a12s8ToSgpHIcGqPctGiw kMyoDCNnxrSVlcxM+SqQMS8KkROb7e8ZQs1dJKXEh5Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41wkmnjgx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 12:29:35 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 48RCTYnK016144; Fri, 27 Sep 2024 12:29:35 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41wkmnjgx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 12:29:34 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48RA8lXn008722; Fri, 27 Sep 2024 12:29:33 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 41t8v1mxbj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 12:29:33 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48RCTV7v15270396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Sep 2024 12:29:31 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3FFF520043; Fri, 27 Sep 2024 12:29:31 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5867C20040; Fri, 27 Sep 2024 12:29:29 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.79.55]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Fri, 27 Sep 2024 12:29:29 +0000 (GMT) Date: Fri, 27 Sep 2024 14:29:27 +0200 From: Alexander Gordeev To: Alistair Popple Cc: dan.j.williams@intel.com, linux-mm@kvack.org, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com Subject: Re: [PATCH 11/12] mm: Remove pXX_devmap callers Message-ID: References: <4511465a4f8429f45e2ac70d2e65dc5e1df1eb47.1725941415.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4511465a4f8429f45e2ac70d2e65dc5e1df1eb47.1725941415.git-series.apopple@nvidia.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oFQh9Q3qdgOsP-PvuakR2OvYRSStdcRF X-Proofpoint-ORIG-GUID: 9y1XQY94BFekLXDgIVhFUpi4XYvsL7VN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-27_06,2024-09-27_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=771 priorityscore=1501 suspectscore=0 malwarescore=0 mlxscore=0 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409270086 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9601AA0002 X-Stat-Signature: mf5r59hda18jii1byrge1pefme6hi15a X-Rspam-User: X-HE-Tag: 1727440204-368079 X-HE-Meta: U2FsdGVkX1+hN04MDm26zDCCN9GV2wgSkFMTr8ESs70JKxILWj9fGB7nLFjlwdcJKYtju6bCh9dHDHaRYdIYhs11kVYqtcipVLaayMp8YWFzJcSDny6e1t58t1TzQC/OdUDO7CCzaHObYkcLT4c84taa2uQXJSU8Aw+2i0OE3lP5I+yvmA/LQic/EBd8mv6tCNZn5YJBofQS1YLSpV9XvEL0DMJUu4fCK6ZGIxX3cM42ZWGhBb824q8lghmiQLNd1xTTFKAKF00/czPtHygSyo0fzH/nOgy/ERdvKH1e7YwbwYDqDDuRGbD3opGaZUtexk2Jd7c2JOsnBG9Fsvq5NU+E7ELrVQ/DGv0BiW/xmrs9BUX2+dQzS+8o2Gi0ntRtiZmD/TYQ8RL5xGilk/5mMQ3+F6clPDtMtCx3nfvRA8EHCMWm8p9ZqP/FmQBeF1EBT5yyoZp2FkakHKFKsdu16d10b11n6HTQI0bFV9fPseb3xWkW4YGrh3bRFj37fQ7G2FJDienIELkmOMtrBGS+/SkFm1lubvSjOeYtZU3LV4T61za6RhwnV/qbvszMbC1AOJFOP+tvq7sOJpld4Kx1c8RhsFq3NQzl8G0v3vlZqSu0pWFNkgnjZMcFHDlcnRB5pFysVheI/W4PqTYFo+cEO+lG4D3n+jwH/Scww9sUNF4+RHySwbXEuuFhg5ZTUaBm8nSTrxRTYkfRepBii7VJoq1SpEm8mIQz+0R9Sme0LGTcaeE1mFRMRjRjYgOr0KgNiZCrxcTOexDiwqEYhz4OS2LVsD0/DDDcL4PNCPZXTQBeEdnrjbaW5fZlGf9IoWK18Pf7BOtvqPYHAx/sB+fua1ItqU3IBVpbDiLQBcZji3haMw/X6oH3a7QOvEOxd01vgWTS5WlWV2GED6K05K6y//Wtk+o9JPxTNihwq656NJgRLsOaI3eOTfKlbCgK1jSyNDsN6sMGDoBQMpdhnGP zUPPKPM9 9ITc/Lt48eBcEMUipPY+aPYdK52Ejv8xf/ZkXGDv765JBps8KWIboNEop5b1YRoAIQH+3DaumYo1iJQ/fuXTVRcqdJ3bK6NTtHpW88EIxmEQbcOBNQj9qHAQReOPh+y1iBEPIPbcAv9TOKzcQoDO0vYA9BhjmCqQgpYV0lUYntwm+RAf3r+fDHJKN9n3TrKF7ulPeir1yjQwlNrvwgWPhd5erJXbdGsEQwZn3JWf0KNL1Yifq9Ab46U9shGG+TSzVE/ZiHBhcmskDVVg87ifXfwS05A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 02:14:36PM +1000, Alistair Popple wrote: Hi Alistair, > diff --git a/arch/powerpc/mm/book3s64/pgtable.c b/arch/powerpc/mm/book3s64/pgtable.c > index 5a4a753..4537a29 100644 > --- a/arch/powerpc/mm/book3s64/pgtable.c > +++ b/arch/powerpc/mm/book3s64/pgtable.c > @@ -193,7 +192,7 @@ pmd_t pmdp_huge_get_and_clear_full(struct vm_area_struct *vma, > pmd_t pmd; > VM_BUG_ON(addr & ~HPAGE_PMD_MASK); > VM_BUG_ON((pmd_present(*pmdp) && !pmd_trans_huge(*pmdp) && > - !pmd_devmap(*pmdp)) || !pmd_present(*pmdp)); > + || !pmd_present(*pmdp)); That looks broken. > pmd = pmdp_huge_get_and_clear(vma->vm_mm, addr, pmdp); > /* > * if it not a fullmm flush, then we can possibly end up converting Thanks!