From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FA7CDD1B2 for ; Fri, 27 Sep 2024 14:07:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85B546B00E2; Fri, 27 Sep 2024 10:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80BAC6B00E3; Fri, 27 Sep 2024 10:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 685196B00E5; Fri, 27 Sep 2024 10:07:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 499326B00E2 for ; Fri, 27 Sep 2024 10:07:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C688A1604A0 for ; Fri, 27 Sep 2024 14:07:27 +0000 (UTC) X-FDA: 82610695734.22.CE72741 Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) by imf07.hostedemail.com (Postfix) with ESMTP id 872F740015 for ; Fri, 27 Sep 2024 14:07:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm1 header.b=YLIExtAS; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Mt+Z0Npn; spf=pass (imf07.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.144 as permitted sender) smtp.mailfrom=tycho@tycho.pizza; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727445982; a=rsa-sha256; cv=none; b=2TEY8O3TJ/CSXFAzPpEhwrY85BMUtXB/bTEYal09Beqyif/5mX2+TMxsgrGDYE5e29tks+ VpxIjJFQDb3UFL+cf8HsiBE6HOPcLH/dH6N52c1Mao40xUhb8gr7uixBXO2TFxvBLNGGiE aNpIBEHu3qyRoUzfqRBNhvcMJ0ZTvt8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm1 header.b=YLIExtAS; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Mt+Z0Npn; spf=pass (imf07.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.144 as permitted sender) smtp.mailfrom=tycho@tycho.pizza; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727445982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=reEuEofoIX50Jk9+XfJrwD0MRSP6hIoJJ1tb5DJ8T7Y=; b=eLLdiSbr1FvJfYNP/X4K3lPWdjKfI/npr2sPlT1q5d4zVCeiDUHLabpOqDYPZvEH5cB9z4 4U8f2SEUboGHRxheOf+wskNI7VEOylul98qNipCp22LXlxCR/UUAb2vRB3xBHWZBPUsBsK 5VY52Mm6VTYfUYk+rV8WIORWSWZW7SI= Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id C41B81380162; Fri, 27 Sep 2024 10:07:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-11.internal (MEProxy); Fri, 27 Sep 2024 10:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1727446043; x=1727532443; bh=reEuEofoIX 50Jk9+XfJrwD0MRSP6hIoJJ1tb5DJ8T7Y=; b=YLIExtASxjMsLzAQVgJU9JmOsc /FBDk20AQOHIbQA7l7q9wC4SvNTwE1yR1a3+uMTjCsEuR9eRGZ7PD3HjlG57wM7f G2E3CNdhbx0h1HB6sq699XOXVA5eH4LbBpwGxQ4HZXDR3uKH44/6hCo3+L9DsZt9 UBqkFKV0lHuNX7EgQQf7MeK8WxU0uOjKUiCjr1fwnm8iGHUk+EVa1jPQJ/aAKsLX BiIBXbiO0P2Fu+s4XuSdoRa2hffg2Z616fMs+EV44vJIFwsaAFLdUd2iy8ofFshD xvSH/qsG5VuqbM8wu5+dMYAE3GKh/mBY10xVMNo0ayxm5PKHFpS4KJ6JiQjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1727446043; x=1727532443; bh=reEuEofoIX50Jk9+XfJrwD0MRSP6 hIoJJ1tb5DJ8T7Y=; b=Mt+Z0Npn8iF9AEDWPT/DMESvRfJ6Vow6mC1kB0zqM5zN 9krzJvPSFtaWibAFAbrc/ifWXfGCsi4F4PAyCUkK7lLDbsPgLhyZA/sutqm4WL7B 5MAYhe92No5bG6skcJq7vv9ctRs1+04EhLJZ7eQvbGMBJ0VFHQRnUgmWpKQRk8N4 Pr5GK/5BM4HZ4Z0Kl7/E2fnVtrRVGNJG2JszaEZBqMeDCb9yTIU/l9t+s8CJm9wR Q8af6Q1UBBzZllHKNPst8J2RY48lgi5nIGnuJ1Srt7BHi+QqolFgZ2zoyZsCH6tW /T5V4ghJW9a1effr3R+hOmEJ4ywaycEu20MTFpcLIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddtledgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvden ucfhrhhomhepvfihtghhohcutehnuggvrhhsvghnuceothihtghhohesthihtghhohdrph hiiiiirgeqnecuggftrfgrthhtvghrnhepueettdetgfejfeffheffffekjeeuveeifedu leegjedutdefffetkeelhfelleetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthihtghhohesthihtghhohdrphhiiiiirgdpnhgspghrtghp thhtohepudegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvsghivgguvghrmh esgihmihhsshhiohhnrdgtohhmpdhrtghpthhtoheptgihphhhrghrsegthihphhgrrhdr tghomhdprhgtphhtthhopehvihhrohesiigvnhhivhdrlhhinhhugidrohhrghdruhhkpd hrtghpthhtohepsghrrghunhgvrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepjhgr tghksehsuhhsvgdrtgiipdhrtghpthhtohepkhgvvghssehkvghrnhgvlhdrohhrghdprh gtphhtthhopehjlhgrhihtohhnsehkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhhu tghkrdhlvghvvghrsehorhgrtghlvgdrtghomhdprhgtphhtthhopegrlhgvgidrrghrih hnghesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Sep 2024 10:07:21 -0400 (EDT) Date: Fri, 27 Sep 2024 08:07:20 -0600 From: Tycho Andersen To: "Eric W. Biederman" Cc: Aleksa Sarai , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Jeff Layton , Chuck Lever , Alexander Aring , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tycho Andersen , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= Subject: Re: [RFC] exec: add a flag for "reasonable" execveat() comm Message-ID: References: <20240924141001.116584-1-tycho@tycho.pizza> <87msjx9ciw.fsf@email.froward.int.ebiederm.org> <20240925.152228-private.conflict.frozen.trios-TdUGhuI5Sb4v@cyphar.com> <878qvf17zl.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878qvf17zl.fsf@email.froward.int.ebiederm.org> X-Stat-Signature: 89gub1ifift9qtyinq6xortjkmmw6y3m X-Rspamd-Queue-Id: 872F740015 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727446044-391733 X-HE-Meta: U2FsdGVkX1+0/pG6BQWof2tq+d3xjJ+nzMbsosma8WajZCgbqV0u41rKhrFTDrcBXd4/hjFzaBL//rqfwx3WJM3KYnGrmRuecWs8sdaEq0pKTQ/BWty2UQ+MvInJiNbBLid6c5xUilHq1bhaL5iOi4CwZ/qMcTMTozYnUYOm/Zaekc33MxO9MPuDvC6QLoC/0I7fH8FEHRXH3329FHEra6HCmm0t7lxPJwaffiTI4S4gJMJejMsTk+SGIX6fZ6HBNcFKzQFRaXEF96EthIq7bKynjo9FsRszm8oyR0xk13uXeWhzshb+kDRPvHxacsxWmFKsSNqABGcR+s1FKfHSFs2MRAsSRYs4zK73Ejds6vN8o7/nm3D1y3yzwnJok7CliE3e29s4lZT8pnd7gdF2DZ7oRhBAzYbQDdHUlGNJWPhy9vMTOk8/jnshoEzZ/YCRlxHtm2GFu8ZiRC+NOsr/y5P3VFzM4ozQPKRwCSXlEykuVCHWYO4PHNK0DXxPjObDu6mEDRI6S2a4GUJWx/oZVK5jnMHhjn1XJGJA2Q8EWvGC7JUB0vplU7BmlGPQydq+nqGzVz4rSULG3dRlXagrpkQ9UM/0AjxHKATFj03hVuQMAqihGgxa6+qdbHW5IQomVoXa5IAXDvmGmTqYmYka7csnyW5rQu3D+EAOxOhvEp6levk/CL2RNcY03lxheNAwt/sEgyc5dsGx4wqerx0XfiHvwhb9lK3t1dr91tYI3YVsvrx7IxpV4yb7FA5dG1HoO5QKVG67/xEqmuupXKIUlmT57N8RyfwbeAtT/1xAKGKTWuhiwvOANx7AHhEPe1S1eFugWDAbv2UowtjD84iZncqNe3SpGKWcIpXCnfIDZ6GQgk0Yb0+Tzz7uZYG8hG3SoveD3jGgSlruWN4uJ7R64uOA1XHIq+dqrKRIzNyI6mPQXCknD0/noNsB+GIEOTr7V1BQ9VWzMtgNbKtpAz0 mVHS4vTM neg4JpYnQa9ggfMEMDH3ErfSQH7VValqK3lS8wQb7KgA7ymX1GpAE24hSt+c09ou5hNOHcHCQP25yVfIOJ1huv2qryeKVvqHflUNZ4vmhmmYAY10eRoWBqllVW9WXSkXLUkiahqQVZeKKISLEjt/Ea5/9qA01oYMAg7btUT2JYLksjAJTFeEsWCYmIRL6E6vZa7CDC9k+CPGbdfJOvmfcsyUdi+po7mazTC5RvO44y7rb0r6kr3wP/pl58kTMtCZ31a1EDlA29iGxvNI5RtRL258GDTcdMxqqnT+Mhc9tt4sCYCnybKIy5ussQsVDzJN3fUvDn6OWA8GYeshz3haPXPo4FfmNvTUcHv/QBS7+A+b0fsm0TNuxXbmG4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 09:09:18PM -0500, Eric W. Biederman wrote: > Tycho Andersen writes: > > > Yep, I did this for the test above, and it worked fine: > > > > if (bprm->fdpath) { > > /* > > * If fdpath was set, execveat() made up a path that will > > * probably not be useful to admins running ps or similar. > > * Let's fix it up to be something reasonable. > > */ > > struct path root; > > char *path, buf[1024]; > > > > get_fs_root(current->fs, &root); > > path = __d_path(&bprm->file->f_path, &root, buf, sizeof(buf)); > > > > __set_task_comm(me, kbasename(path), true); > > } else { > > __set_task_comm(me, kbasename(bprm->filename), true); > > } > > > > obviously we don't want a stack allocated buffer, but triggering on > > ->fdpath != NULL seems like the right thing, so we won't need a flag > > either. > > > > The question is: argv[0] or __d_path()? > > You know. I think we can just do: > > BUILD_BUG_ON(DNAME_INLINE_LEN >= TASK_COMM_LEN); > __set_task_comm(me, bprm->file->f_path.dentry->d_name.name, true); > > Barring cache misses that should be faster and more reliable than what > we currently have and produce the same output in all of the cases we > like, and produce better output in all of the cases that are a problem > today. > > Does anyone see any problem with that? Nice, this works great. We need to drop the BUILD_BUG_ON() since it is violated in today's tree, but I think this is safe to do anyway since __set_task_comm() does strscpy_pad(tsk->comm, buf, sizeof(tsk->comm)). I will respin with this and dropping the flag. Tycho