From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0677ACEBF76 for ; Fri, 27 Sep 2024 04:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1106B00A3; Fri, 27 Sep 2024 00:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570766B00A6; Fri, 27 Sep 2024 00:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 411E86B00A7; Fri, 27 Sep 2024 00:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23D556B00A3 for ; Fri, 27 Sep 2024 00:29:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CEFD8160A0B for ; Fri, 27 Sep 2024 04:29:40 +0000 (UTC) X-FDA: 82609239720.26.4CD9A7E Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf25.hostedemail.com (Postfix) with ESMTP id A9549A0003 for ; Fri, 27 Sep 2024 04:29:38 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EmJtVO7Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727411361; a=rsa-sha256; cv=none; b=CNbqSxksA/sF9dcqbiVjDn+0r/TYzHShbGaoXyYbPuhhiKfaY6zgNOQ19kZxkKp9roGsWq 2mj7bj7ZZLxgTLOWt3Nyuehj78owjz6Y5pR4qXm/aLji8GRTLQ/nC58lPbVz4cXZ1EDs0j w8Xx2miSTuZ6hVY8jM3TkuvuJ0iP1IQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EmJtVO7Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727411361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=21M9MzJPvTphBfiljncSfgv5gf4c5od3t3MjpsyahVw=; b=RVup1kiWESSyrFCVfBV/ChT1eKpl8d3W0nbq4kYja+uJpfhYLfb2F6E7V+0cZVU1FW1q3+ sTtcYlpx0/KcN7FJsBl5F12RTF19gQVt5TeUIhlu28Q0s4pekbRIBH2UE8ZBP8asKg5xE7 WlL5T3CwJZuFwK8LuwVHYsGhs2RKkPE= Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6cb2cba60e1so9968246d6.3 for ; Thu, 26 Sep 2024 21:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727411378; x=1728016178; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=21M9MzJPvTphBfiljncSfgv5gf4c5od3t3MjpsyahVw=; b=EmJtVO7ZtluVxe+dMpoYaN8RjDExRR1sI9buHBceRvgoDfyjiZlruIyMOGziLS1MJY K2DtGgpacrSVAJGRJE/dZfEu6/AIOmHcx1yevlt0D1CDQScWqA8bv07hJ3BfWTKYRZPx 0vIW5txWJrksyXV/GqUIcxgZb5WnlMEIWBbFtG7teJ/K/tAcqkxY2L9OUicotgTrHmIK K4kqURRPaVv3EzXmgIqSW4zxa3EVE/gDoOfq0k3PiGYE+6Hnfh8oR0puNQaLVCBFfTUU ODzf5OOimIbTFeNYRrtOFOxFyLdhL+7fVex0aw1I0h33d+4GLTJrCoU2X2B2Zd+H+gLb UmxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727411378; x=1728016178; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=21M9MzJPvTphBfiljncSfgv5gf4c5od3t3MjpsyahVw=; b=vDo/hyZvc9L6hFzr04Uz6TEsaRyt7Q9+Lk7CaClccUO8zTRn5KDY1fQzqO+B3rQ6Dq yU4jY+PQINlPMjJE//SlDv6BBNr4LAZHPepnJLwDS7bkwaJpVJR5GhOL6GopEavEP1iO BnfGGKAHe+VNEGWkAkehZK7iaavHZftD9PMDl1c7ElPktSOpF6PuQQSiwP8To9FjfzUZ dGCk8K7FMl+h23SGpfFsy3NDHyREU4z9AOHAvqePb5Bgw4FI4cIQ286gQjSFTZFLcXSy E39JoxAhc5iBzt8L962Aa4oQQgN7eKWqag/YfT4PIRGwIixq6RkN6P4HAyseVqC9HZCl v5GA== X-Forwarded-Encrypted: i=1; AJvYcCW+y3ottlXoWkfu4fEI+WEc8OrLfXFxEhNsVFgxEYYYSC013ia6TowdtkhR6Af7iKKZapDIyOn35A==@kvack.org X-Gm-Message-State: AOJu0Yw3D3zN393oKgF56GNTDJmfDPXI/kQ3WhBCOaBZgaQFVzPgTWSi ZCUvXt+3Kkc/vSb2kGNAsldgPyKJnbPk3EUsJG/cV5VPHR4biBFn X-Google-Smtp-Source: AGHT+IGf/plWz9ASXEKjdPoI6R7baDwvKze1+ejjNG6Hfz77yFVyuHE5hcsLvlFgymh7Y3GdLFe/cw== X-Received: by 2002:a05:6214:3d0e:b0:6cb:28f9:cf71 with SMTP id 6a1803df08f44-6cb3b5dee21mr33731136d6.20.1727411377586; Thu, 26 Sep 2024 21:29:37 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b66b0cdsm5407156d6.80.2024.09.26.21.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 21:29:37 -0700 (PDT) Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id 587AF1200043; Fri, 27 Sep 2024 00:29:36 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Fri, 27 Sep 2024 00:29:36 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddtkedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvden ucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrd gtohhmqeenucggtffrrghtthgvrhhnpeegfeefvdevffejueekjeduleduveehgfehleek gffgueeuvdeuteejhfehledtueenucffohhmrghinhepghhouggsohhlthdrohhrghdpvg hffhhitghiohhsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthi dqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghi lhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthhopedvjedpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepmhgrthhhihgvuhdruggvshhnohihvghrshesvghf fhhitghiohhsrdgtohhmpdhrtghpthhtohepthhorhhvrghlughssehlihhnuhigqdhfoh hunhgurghtihhonhdrohhrghdprhgtphhtthhopehjohhnrghsrdhosggvrhhhrghushgv rheshhhurgifvghitghlohhuugdrtghomhdprhgtphhtthhopehlihhnuhigqdhkvghrnh gvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehrtghusehvghgvrhdr khgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorh hgpdhrtghpthhtoheplhhkmhhmsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthht ohepphgruhhlmhgtkheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepfhhrvgguvghrih gtsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Sep 2024 00:29:35 -0400 (EDT) Date: Thu, 26 Sep 2024 21:28:48 -0700 From: Boqun Feng To: Mathieu Desnoyers , Linus Torvalds Cc: Jonas Oberhauser , linux-kernel@vger.kernel.org, rcu@vger.kernel.org, linux-mm@kvack.org, lkmm@lists.linux.dev, "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , "Uladzislau Rezki (Sony)" , rostedt , Lai Jiangshan , Zqiang , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Mark Rutland , Thomas Gleixner , Kent Overstreet , Vlastimil Babka , maged.michael@gmail.com, Neeraj Upadhyay Subject: Re: [RFC PATCH 1/4] hazptr: Add initial implementation of hazard pointers Message-ID: References: <48992c9f-6c61-4716-977c-66e946adb399@efficios.com> <2b2aea37-06fe-40cb-8458-9408406ebda6@efficios.com> <55633835-242c-4d7f-875b-24b16f17939c@huaweicloud.com> <54487a36-f74c-46c3-aed7-fc86eaaa9ca2@huaweicloud.com> <0b262fe5-2fc5-478d-bf66-f208723238d5@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: rdpdis97od4zdkotu5hw5hhkwdakk636 X-Rspamd-Queue-Id: A9549A0003 X-Rspamd-Server: rspam02 X-HE-Tag: 1727411378-768276 X-HE-Meta: U2FsdGVkX1/rdCmDwp9/8TPTBQB5hR7tWYZVzO/u9SgYpabnBSgD0cBtTBewmEj5NtlP8eE5XR8LwhsNJse2qRtV6xshEIP5bqhqZWWgYv55VTt8uCsVQaU8WTGoUBzzOt/Aag4vhcwJQaX/QmjUGgpSW3R3ISdKUNM3aNWZSpu24o4HlfA2z6wN0l7/RX30nBa2f9hY+sh9SPOVnA3+hv5RxtiCv81lY6lGUn2zvfeInI2x+UWg9hWaUNOyhcrEW+o6p+KJXIiLIH2+R3Mi5FA/7ySijYwzYn+xBHpgG/nOTtzW/iSaQ3cWNGO1QafeFH2hp7Vyj/3GMA0ay15ov0Q2xAT5PZ1m40nqeLf3qbT+8jhwzDdxBi+GIl3tyvzvcx0lNto1y/6wgLM+xPsw0FqluwJq1juwWxAO0km9CW08nfhrWsAL9nirTnpD83GTE2RbI7ssW351aG4mnoasCUd5MO82F0Ctg8gr7EJjIzYKGDKjHiR08pLbJbksrWShgyJT9xeVdXIqIr+84iF37edvLNRGiZ8RuUhyQ+mQ1P+ZcOTJZ9+k4Uzet9eQII8n7wWtRVRMn8H/46DWiOtB0akt7pez3tXnJEcRE+l/9dHHb80Z6MwanB9RgLZ3QtY8RK8Fs7c+uJrxvevlDOBf21eTHGTvfi0SmFpOD1pH+uQ/PtGixnhCEk++rKLsTlr1EMkPUGK/44gVQUUZSmAzuvzsY8Q14JEK33OpSNdBZpTRwyF1HRmJp5NH6OoopTnurc5SUDZCq/xh8VKQIy2PH31hE15Smk/c59BIMWBqqcGUfNmMO9MbKVqeHU70QhC23mvWnjY7a/eUrcIIic7aMpmRaDwVeikR+KNmavya0xx0rJPyBYAgABOXYIboB2N10LTEVyqo0NWTT3VeCyCPzjvXuv5sc8LXk6FbTB5UoWAA0nBtmd6FkD3YvPGOxdkcYZEveuEzOo8R6uWSwoV BkEFOl7J OK720UuovQC5guRm+VIzo8Bl4ZihA0jEBZtCQ92XoFI9Hxv5zncwYRNPGbvdFFJFkgQnZRPfEhTJpJc6om4tHEW7gBewnGemFtadrRjdad4VKYgaHkMCGwbBiq7cn6AtXHnj9uo1K55hMMucih3ngizhUKOUZH7+/AlFT250wcowCknJEGli8VsGhac5RF9uTVTvwapQtz9LA52DU0S0HF0B4gCBxJ5zoX57bmQlTCVuas4VPmBRYvcVL0P8YQKeHGWcySUtHZiNjvZ3LHy9Af8ekU4aNkXiaL8n3RiZdcOr/39uyhKBBVd6zxdcdC19ZqVCGno9NEb35KO13vxzgdXKUPB8Nm35x2HWsGrTKa+nqoBmaueT8V2J8USEryGt/26eK13GkYkfl32fOVW/3vFwreOUmcPV+N42z1F6QCDeSsGzoKvDCmH0Wf9csaZ1Le2yPoR9YAc/lY4pwPEzq0bozp7AwViR30Socq0G/XABUpvJPrSzw7nfyBMuUmwHttQHb5Ug2kKTIeytXrjdxL4ut4n/FrsTXJPbhFvf7Z7ySZ2RqqRKiFtqtpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 27, 2024 at 09:37:50AM +0800, Boqun Feng wrote: > > > On Fri, Sep 27, 2024, at 9:30 AM, Mathieu Desnoyers wrote: > > On 2024-09-27 02:01, Boqun Feng wrote: > >> #define ADDRESS_EQ(var, expr) \ > >> ({ \ > >> bool _____cmp_res = (unsigned long)(var) == (unsigned long)(expr); \ > >> \ > >> OPTIMIZER_HIDE_VAR(var); \ > >> _____cmp_res; \ > >> }) > > > > If the goal is to ensure gcc uses the register populated by the > > second, I'm afraid it does not work. AFAIU, "hiding" the dependency > > chain does not prevent the SSA GVN optimization from combining the Note it's not hiding the dependency, rather the equality, > > registers as being one and choosing one arbitrary source. "hiding" after OPTIMIZER_HIDE_VAR(var), compiler doesn't know whether 'var' is equal to 'expr' anymore, because OPTIMIZER_HIDE_VAR(var) uses "=r"(var) to indicate the output is overwritten. So when 'var' is referred later, compiler cannot use the register for a 'expr' value or any other register that has the same value, because 'var' may have a different value from the compiler's POV. > > the dependency chain before or after the comparison won't help here. > > > > int fct_hide_var_compare(void) > > { > > int *a, *b; > > > > do { > > a = READ_ONCE(p); > > asm volatile ("" : : : "memory"); > > b = READ_ONCE(p); > > } while (!ADDRESS_EQ(a, b)); > > Note that ADDRESS_EQ() only hide first parameter, so this should be ADDRESS_EQ(b, a). > I replaced ADDRESS_EQ(a, b) with ADDRESS_EQ(b, a), and the compile result shows it can prevent the issue: gcc 14.2 x86-64: fct_hide_var_compare: .L2: mov rcx, QWORD PTR p[rip] mov rdx, QWORD PTR p[rip] mov rax, rdx cmp rcx, rdx jne .L2 mov eax, DWORD PTR [rax] ret gcc 14.2.0 ARM64: fct_hide_var_compare: adrp x2, p add x2, x2, :lo12:p .L2: ldr x3, [x2] ldr x1, [x2] mov x0, x1 cmp x3, x1 bne .L2 ldr w0, [x0] ret Link to godbolt: https://godbolt.org/z/a7jsfzjxY Regards, Boqun > Regards, > Boqun > > > return *b; > > } > > > > gcc 14.2 x86-64: > > > > fct_hide_var_compare: > > mov rax,QWORD PTR [rip+0x0] # 67 > > mov rdx,QWORD PTR [rip+0x0] # 6e > > cmp rax,rdx > > jne 60 > > mov eax,DWORD PTR [rax] > > ret > > main: > > xor eax,eax > > ret > > > > gcc 14.2.0 ARM64: > > > > fct_hide_var_compare: > > adrp x0, .LANCHOR0 > > add x0, x0, :lo12:.LANCHOR0 > > .L12: > > ldr x1, [x0] > > ldr x2, [x0] > > cmp x1, x2 > > bne .L12 > > ldr w0, [x1] > > ret > > p: > > .zero 8 > > > > > > -- > > Mathieu Desnoyers > > EfficiOS Inc. > > https://www.efficios.com >