From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7CF6CDE026 for ; Thu, 26 Sep 2024 18:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9406B0093; Thu, 26 Sep 2024 14:04:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 441936B0096; Thu, 26 Sep 2024 14:04:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331A46B009A; Thu, 26 Sep 2024 14:04:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1AB2E6B0093 for ; Thu, 26 Sep 2024 14:04:29 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 98E0C802D2 for ; Thu, 26 Sep 2024 18:04:28 +0000 (UTC) X-FDA: 82607664216.26.68D041E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id E83B54001D for ; Thu, 26 Sep 2024 18:04:26 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PBYdNH+I; spf=pass (imf27.hostedemail.com: domain of namhyung@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727373745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OR5efW7AzvRx41e1yWjCbXuayNGkFdWZq45RFOpwOHo=; b=JPP18xjxF8zXPV8AMdfPN9zo5vdBJLohZwQh0llrHzUjuwW6HhNnfjDvqfke2axMnJkfXI esmLX0/Lmd/u6BXILrKNdSdxO5frMLL5aEq5LnKT4e+94blle4zqX5JUe1P91e4cr18Esh RDxFKCNel5uQvzvF88K8Cv3FRUd4oLM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727373745; a=rsa-sha256; cv=none; b=CYn7QQp7GNhhtM7XyAfn9wGox9mKX7nCiiYD/MzUXKVE6EKsp/tIecvv4WHwrwKyhpCYMd 60zTbwxe0lOwtd1UhkOPz5thou0ADXyJTBoJDqCGj1ncpZAaN4YBs1xrONyEajDbier/NT ltkgZRT3+1lA/3bdbVh7FWZeRyijw0w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PBYdNH+I; spf=pass (imf27.hostedemail.com: domain of namhyung@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E3AC55C5913; Thu, 26 Sep 2024 18:04:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5CF1C4CEC5; Thu, 26 Sep 2024 18:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727373865; bh=gj9eNFEeiWVEaaqEkkwhe3PeLqdetTJaVkbInymCKyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PBYdNH+I4AK26SkyPpnSkEDEL6ETqz9yHPijs8bPR8r/vSQ4Z9QCMUvjBqTnLwDkO t2MgFmsZcKotLMgPMs0Co29Zh0nzuSOYs5D92soiZpo7XF+GdoH57C+njD16nQmY4l mAi/o6llL25D/ll3uL7y7iSgI5zmI09l0e9HIy6LYr4LzmXns6iZ85ZQBIkQpr7eo2 CsbSboz0Lp5Yq5EmsYHDzYMMZICxzKX7GtjgddHsy4DuPbSOiV8xclcDPK+vYWmUiS 2zODvxiO7dmWn5+5buvL/ZNjFk7U/dcjHGnkuOdqmfrc9/hhbHruZT+Hc1TE9bNiG7 BDvX1XYPVA35w== Date: Thu, 26 Sep 2024 11:04:23 -0700 From: Namhyung Kim To: Roman Gushchin Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf@vger.kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Subject: Re: [RFC/PATCH bpf-next 0/3] bpf: Add slab iterator and kfunc (v1) Message-ID: References: <20240925223023.735947-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Stat-Signature: rjkhsc4i39oyn6nu5aenz4u6pq6rg9t6 X-Rspamd-Queue-Id: E83B54001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727373866-249289 X-HE-Meta: U2FsdGVkX19eLAE30gx0EpuJLXAfgVl7b4EJRDleypCCt4cKI81Q9BDYavR8a+k+AHzkD6V+/7JzzchPuIdHgOJG0YI0JJ8eQitUY7k3HFbyQSpG/beu/HtNxS0VFSdQ2hwMzYOOVUwdE8V1l61Q0QUbk9xq+YHdHOPzK6+X2dclmi8a9ddn88fkFP474/gaiaWrWGCzbhMzKnZxTeBhIBZIboZpTJBIMS4jJX/n7vnKD5oj5iI3/ieKq/2f6YQlxwPvUL3xxpIo34JyPd31Bx6Fc7A+WRZosSu4Z90F21sE99Oj6l1Fj5PIlvq3LhTW8szSHNvjItBuhr3qtkRXtWgi7Q9rVT86yCX6W2z7GzDe3e9Unz9QZO2IKt0BVCc8lA/Wr1b3fFRPATTuOq6iJKQeKPQu8dvIpEXnK/lN5up9/EW20k8sZBE03j51WMCWUTtv2Lmzff2ZiVVPLoQ+JnCihlbT7rpN1+BnhX8y3C111RONw01IK8BN6C9eQ0becLgKVZynaRrDA0pW60jQszH4k5YLgeK2ZNwskOkn2XHZFP/CqjtcDBuUYF5YApf/lTVGJpj+zfpV7uSQ8+B46Z8bwysPCtmFavZ2THWJeESLC01RGJFGGLNnouAQfTTdhJAdWi5U0FojXaH0ixi8cfw5Qs77GDLb3RhUnRw6ykQDrzNIEXH/m2zPfkyF1vhrOvvMudSi/kGfh8JEGIrS5Ek/G3KhBwrI7z0/YfxHXnHD48rb9Ism3g2S2Ky8S88iwjznrj4XcFdZlHnl3k68pA1zJvbXdZIC90Kpk6ORUS20c8kI4trvgHfL7+gS5OGbmJxhCP9jtkp5GJbF6cUcbDdXVSgvSSyMkIl2x2ML9Ad1SgF4hkg/Q6RIvI32OIXKxv8Y1HEBhVZVNgw/xmDBmffX2DLV73a2VdWQEDXQfLG56Ah9BxZeQyNBWUfVYeOXIOHCgw1wPRjGLibwYq7 5/h9czEv R3H8uxsRqRqkXT18bRmNukNEWPcSo2A0gw9VTud+WJycaAvrpcfXQhJlljGMoZnkbuvS/ET6Ql2Oa8VkaCaxUMQ/oy9TLREcBXDo17qecyLC4nXimN3FBGzz4dKOfhhefnRrAof1Pi8FMZ2HcXiO0TI0ehW2kn3gLnWvPH3+ngMI4v3i0Tdo4LfEIlm9OgeLj0u/K6xFS4Syty7XxjB+AMgDW9m39aagj32ZQJKGJuF/NBpLQS7TUCyIMPEegDmfyof1J+wJw0/u3Y4s18vucEVRGefOmNO+gtqkt3ZLkbCbaMuwTWUkOK7ZJkr+zO2zlf+dFv4CdK5FQVr6hdo9g+rmp/hppm90FCCRlD2GVgyyaD4A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 12:16:15AM +0000, Roman Gushchin wrote: > On Wed, Sep 25, 2024 at 03:30:20PM -0700, Namhyung Kim wrote: > > Hello, > > > > I'm proposing a new iterator and a kfunc for the slab memory allocator > > to get information of each kmem_cache like in /proc/slabinfo or > > /sys/kernel/slab. > > Hello, Namhyung! Hello Roman! > > I personally like the idea very much. With a growing number of kmem_caches > /proc/slabinfo getting close to it's limit, so having a more flexible > interface makes a lot of sense. > > > Maybe I need to call it kmem_cache iter but slab > > was short and easier to call. :) > > I'd personally prefer kmem_cache or slab_cache, just in case somebody later > would propose an iterator over individual slab objects within a kmem_cache. I think we can add a parameter to limit or extend the functionality like task iter and cgroup iter. But I'm not sure we need to use a different name for that. Anyway I'm ok to rename it kmem_cache iter. > > Acked-by: Roman Gushchin (mm/*) Thanks for your review! Namhyung