From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD65CDE024 for ; Thu, 26 Sep 2024 17:58:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 241F36B009B; Thu, 26 Sep 2024 13:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F1B86B009C; Thu, 26 Sep 2024 13:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BBC96B009D; Thu, 26 Sep 2024 13:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF8826B009B for ; Thu, 26 Sep 2024 13:58:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6A26C1C3FD1 for ; Thu, 26 Sep 2024 17:58:24 +0000 (UTC) X-FDA: 82607648928.13.60F0AA5 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf09.hostedemail.com (Postfix) with ESMTP id 1E017140010 for ; Thu, 26 Sep 2024 17:58:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Kx1XEw0B; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727373412; a=rsa-sha256; cv=none; b=qCyKsdFsAELrANPM29T5yCikbsPHm4dOSly1Ti/QA0FYI1Xp+/T3fPnEC6Zz799zPVIJYw wR9APN455HlVnsp+IpWyaz37DC62N2lBw9bCT5MP1I4BYWBxbAJSZABLBdshvFYOT+40d+ +Vs4zMggfRyNeJ/cCvk2HmWqzxh5HHo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Kx1XEw0B; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727373412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OTDEyPXQ7870iU9CM7jrZ7rQn9oxhjmvFfm/mQgMOKs=; b=uhyfQ8z/6jWuaKzODGipEfs8HDYW6mAxCKnY4u6NPN9sHv7Z4ntPKKswh+XZ3xWgYa4o6o FxnatVJBRctNdHNaUn0PH280BvVdbyW7+sD3+HtT+8A7JQXcbbs/SNxpLBDYfT9gzEySIQ dM3zC3CSLrw9Reykb9DBszoDUi1A5K0= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48QFJK5K004016; Thu, 26 Sep 2024 17:58:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=pp1; bh=OTDEyPXQ7870iU9CM7jrZ7rQn9o xhjmvFfm/mQgMOKs=; b=Kx1XEw0BLgCrZvhVSEhXzl/HDOcr83KYhrhpvVYM51J APA6pcj/7Zj5rJy1TDMiMvwu5QowyJXYZeVeXRrGJeMonRuPYcioRQR1Xn6l/XZi pYg37aqaOMYaMezk+iMNtmxcOItYmv6AYVMJlGdEsAW5FXT4htrhnB8Pz29EJotP sbSgPgcBezT8+ZdNok18r5N9vk30nQPZnCEX15lpyo/cKOLV1KLKdmezScMz8mQV KQp+ZFFVpymu0RsmaR/pooGvV7kn4b66Tr9mtGNh4xvcC1O81+058kWxjMuOoI4t 1u08CxQBC+BJ7grAKIQ6VPblJ+5XTTKhzGCUjq7AB2Q== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41snnar2yr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Sep 2024 17:58:14 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48QFv7au005862; Thu, 26 Sep 2024 17:58:13 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 41tapmrbtx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Sep 2024 17:58:13 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48QHw9ic34276026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Sep 2024 17:58:09 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1B3520043; Thu, 26 Sep 2024 17:58:09 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8FEC620040; Thu, 26 Sep 2024 17:58:08 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.171.12.206]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 26 Sep 2024 17:58:08 +0000 (GMT) Date: Thu, 26 Sep 2024 19:58:06 +0200 From: Alexander Gordeev To: Dan Williams Cc: hca@linux.ibm.com, gor@linux.ibm.com, Gerald Schaefer , Christian Borntraeger , Sven Schnelle , Jan Kara , Matthew Wilcox , Christoph Hellwig , Alistair Popple , linux-s390@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] dcssblk: Mark DAX broken Message-ID: References: <172721874675.497781.3277495908107141898.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172721874675.497781.3277495908107141898.stgit@dwillia2-xfh.jf.intel.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: NJOKKizAeOXHbKl6nmfL3rV28dzBLW3M X-Proofpoint-ORIG-GUID: NJOKKizAeOXHbKl6nmfL3rV28dzBLW3M X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-26_04,2024-09-26_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 mlxscore=0 mlxlogscore=988 spamscore=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409260124 X-Rspamd-Queue-Id: 1E017140010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: i1ox88iaw636fooxn8zco48r9tkte1n7 X-HE-Tag: 1727373501-495913 X-HE-Meta: U2FsdGVkX19A5St7KoNZSJiXH3W05GFwHmbs3QTUFELAtpGaG1N+IN301BUG/oVznks9tF/zsgfti4LsisrTvpwKql3EZO9WsvS4lwgdiSEzTqGnYgyWIC7+yT+SMfOQko6ZAJu9AiFsuALxKvh2b8A/AooY/7KKweOdMISkd7mG4UpPPPb48xLiiot95EZwSGC/POHeSS7YIvNkZPgb6vsAgHuA7xy4wNKDQBpv4729ZvQCmyqG44qdeKzIfUpq1jw7HFXtlXIIT/Z2FHkqGioilKrMd03gFNe7fYsy/r118wBz8vYFR060gSKSSM7HsCi3qGa+OSeRePugLvBuWspDyUSLc9zoTAW18kYdq5n+WbF2Q7ZnxwUxpA6tk1U4pkCz6o7sM1D9JNsePdPb4tx+YigRlI7iiNdNzoJp4/bWlzuX7l+Ch8ftigqwBFrUwIqZblmUHlvY6CQP3/NAlr0oP+/RabgguV+x0PifsfIaMyp1JZG4TpWK6GVaZ5e/Eff6LeytToKlEwakDGBnXeQqoY2+P7oPLUREfMDHtVuh0Od2GaMnB3oRxyPiephjin7mHwGUZ4V+r7eRHtYyHy29TAkgJKoGbKWHhHNcDtZ7n9Us/uy1k+VgvVVcX0RX/6Nxw5iqdRw5zKODiEguQmzDBs7xvEqpluZ4pIFG8m6TWtHDwbWwkBwNNhwYoaYMXitWaUJd9oI/WXl7NjcT+ycyc1+XOJkw/yyr7NIItgphfgqeRgbwWJpvBgi48kCQ4/gFPZPCwJ8RT35ArjBysjVvo4ynYvlGR1Ccz4EQ/gxs0kx0T5xjwxSD8ssJ79TQcn3QHixIDv5aCaeUT5zqEiltO973iZeEUBiD/ILhAXK2hT559KnIQna2QB3kBvOCfeIeWJlD8GAQE2ptSRFj3pcrnPUSNVmH2g5XcDPNFZ1HZkx7PwaASh9MD4dApKgqXV3Mccgw2iwbrvgf3h5 5Ac5wlj2 L2wCvNA2p+u/k36RLaUuuXbhDh1Ckh88LRlwzegSSaYRIU7pvKbK7MlavJ0mirHpLFyRLIRDsFXIrMVAlqUSyvCJGhQFiWDEqpIHaI3c1K1Nk7fVm0C9ZYpPzsNecDc3nf5KpokpjSl4NUnhZGiYl5X+jVKVI40Uwpjeetd2bYfDCic1geobPvrAecvxG7jkU/EXjx7KWZKVScJcsRehqU5T3LrFX87QK1SkGeOWMGAOJFmcbnGrggXJOCVhTEkAS2mvYkQFbBoPdJeMlpyoPPYriLN5EfScEDTsKjcuaOUigfjFwmwK+LaFvwuWMt29MuTGkm6sBmdxQI2kNlzX7lwNyb4Yd2dseZ1qYjwRmMt0lzuA1tWSO5YZuVxAjUIAbrY33xso+JTEMHrkQUBSK/hECyDwJQ34aMD+V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 03:59:08PM -0700, Dan Williams wrote: Hi Dan, > The dcssblk driver has long needed special case supoprt to enable > limited dax operation, so called CONFIG_FS_DAX_LIMITED. This mode > works around the incomplete support for ZONE_DEVICE on s390 by forgoing > the ability of dax-mapped pages to support GUP. > > Now, pending cleanups to fsdax that fix its reference counting [1] depend on > the ability of all dax drivers to supply ZONE_DEVICE pages. > > To allow that work to move forward, dax support needs to be paused for > dcssblk until ZONE_DEVICE support arrives. That work has been known for > a few years [2], and the removal of "pte_devmap" requirements [3] makes the > conversion easier. > > For now, place the support behind CONFIG_BROKEN, and remove PFN_SPECIAL > (dcssblk was the only user). > > Link: http://lore.kernel.org/cover.9f0e45d52f5cff58807831b6b867084d0b14b61c.1725941415.git-series.apopple@nvidia.com [1] > Link: http://lore.kernel.org/20210820210318.187742e8@thinkpad/ [2] > Link: http://lore.kernel.org/4511465a4f8429f45e2ac70d2e65dc5e1df1eb47.1725941415.git-series.apopple@nvidia.com [3] ... > Signed-off-by: Dan Williams > --- > drivers/s390/block/Kconfig | 12 ++++++++++-- > drivers/s390/block/dcssblk.c | 26 +++++++++++++++++--------- > fs/Kconfig | 9 +-------- > fs/dax.c | 12 ------------ > include/linux/pfn_t.h | 15 --------------- > mm/memory.c | 2 -- > mm/memremap.c | 4 ---- > 7 files changed, 28 insertions(+), 52 deletions(-) ... I guess you want to remove dcssblk from Documentation/filesystems/dax.rst. Gerald is back from vacation on Monday and he will likely comment on this. Tested-by: Alexander Gordeev Thanks!