From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: hca@linux.ibm.com, gor@linux.ibm.com,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
Alistair Popple <apopple@nvidia.com>,
linux-s390@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] dcssblk: Mark DAX broken
Date: Thu, 26 Sep 2024 19:58:06 +0200 [thread overview]
Message-ID: <ZvWgrrvYiBaFVgN4@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com> (raw)
In-Reply-To: <172721874675.497781.3277495908107141898.stgit@dwillia2-xfh.jf.intel.com>
On Tue, Sep 24, 2024 at 03:59:08PM -0700, Dan Williams wrote:
Hi Dan,
> The dcssblk driver has long needed special case supoprt to enable
> limited dax operation, so called CONFIG_FS_DAX_LIMITED. This mode
> works around the incomplete support for ZONE_DEVICE on s390 by forgoing
> the ability of dax-mapped pages to support GUP.
>
> Now, pending cleanups to fsdax that fix its reference counting [1] depend on
> the ability of all dax drivers to supply ZONE_DEVICE pages.
>
> To allow that work to move forward, dax support needs to be paused for
> dcssblk until ZONE_DEVICE support arrives. That work has been known for
> a few years [2], and the removal of "pte_devmap" requirements [3] makes the
> conversion easier.
>
> For now, place the support behind CONFIG_BROKEN, and remove PFN_SPECIAL
> (dcssblk was the only user).
>
> Link: http://lore.kernel.org/cover.9f0e45d52f5cff58807831b6b867084d0b14b61c.1725941415.git-series.apopple@nvidia.com [1]
> Link: http://lore.kernel.org/20210820210318.187742e8@thinkpad/ [2]
> Link: http://lore.kernel.org/4511465a4f8429f45e2ac70d2e65dc5e1df1eb47.1725941415.git-series.apopple@nvidia.com [3]
...
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/s390/block/Kconfig | 12 ++++++++++--
> drivers/s390/block/dcssblk.c | 26 +++++++++++++++++---------
> fs/Kconfig | 9 +--------
> fs/dax.c | 12 ------------
> include/linux/pfn_t.h | 15 ---------------
> mm/memory.c | 2 --
> mm/memremap.c | 4 ----
> 7 files changed, 28 insertions(+), 52 deletions(-)
...
I guess you want to remove dcssblk from Documentation/filesystems/dax.rst.
Gerald is back from vacation on Monday and he will likely comment on this.
Tested-by: Alexander Gordeev <agordeev@linux.ibm.com>
Thanks!
next prev parent reply other threads:[~2024-09-26 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 22:59 Dan Williams
2024-09-24 23:26 ` Dan Williams
2024-09-25 4:29 ` kernel test robot
2024-09-26 17:58 ` Alexander Gordeev [this message]
2024-09-27 12:31 ` David Hildenbrand
2024-10-01 10:29 ` Gerald Schaefer
2024-10-08 0:28 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvWgrrvYiBaFVgN4@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=apopple@nvidia.com \
--cc=borntraeger@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox