From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66743CDE024 for ; Thu, 26 Sep 2024 17:07:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFC2F6B0098; Thu, 26 Sep 2024 13:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DABFC6B009A; Thu, 26 Sep 2024 13:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C73556B009B; Thu, 26 Sep 2024 13:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A9D4C6B0098 for ; Thu, 26 Sep 2024 13:07:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5A5EA1418D7 for ; Thu, 26 Sep 2024 17:07:12 +0000 (UTC) X-FDA: 82607519904.12.ED25E88 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf10.hostedemail.com (Postfix) with ESMTP id 662C6C0013 for ; Thu, 26 Sep 2024 17:07:10 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lrFafQ7e; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727370309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sSW8LKXMvjgCAP+LleMXU69ztDlOwlRznFCMfPkydaM=; b=7YPHdJKPBxZjfNcR1UiqLJeFtJ/cE+IZ4FmtWaWXyJB7YRZRPM1nbPm/N0SRGha/RDDWdx YGJ0kBO6c63NX8IvTw2gqGViSTaefvGBRBcPl/9iBQtFYsmrub2QEKOWzNN7tK0MvaMVRK N8NqdAGMXU/H7WZvU6JpsaPFCxOWaog= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727370309; a=rsa-sha256; cv=none; b=meA55SQmfs5QGCvr9RNCykO21xWcvTaNx/PQQGt8P69TxKW773m3DEgf1wvW6YbSeqs06Z VmmbENVmo1KCsnNP/ErICT8Rh9qarZfrTpN7KDlm4SRRsGRBG9qsX8u1+cAv7b2wCl0aFf 9Ou3jugar39LcnLStl+WPa1y2RHkGLs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lrFafQ7e; spf=pass (imf10.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5365cf5de24so1698210e87.1 for ; Thu, 26 Sep 2024 10:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727370429; x=1727975229; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=sSW8LKXMvjgCAP+LleMXU69ztDlOwlRznFCMfPkydaM=; b=lrFafQ7e0+eMtzSAfLL0QxBUi38yULM5nHozEOBSPmpVWzFmCMLkzUAkniqjf+1WhY xiV/cURvaKbpVlie0YTN9QAAbOkyN20Nn8cbepNaHH7ti8nM7tr44lLi9kliw4uwlTmN McRdzbXboOs51EENsHu1AoUboR8c8DUF9A+Qo/YvZbtoJLALMS7JloScaupW4k6FpmF7 IqDOVyHfo/YWfK32vuxuUW6rriPTnjkQAASooXqljUVsV9L7auRT1SS6Uo4UELtXBOfP TqJ9sw72UTJq4OByL/8XJCcqGw0nNaIgb7ECB6fCfdr3mIR4y1lLauvDLEbn6yBL+SNN XbDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727370429; x=1727975229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sSW8LKXMvjgCAP+LleMXU69ztDlOwlRznFCMfPkydaM=; b=V3ehDvQVZ1HbNToODdMiS/FZKQFQiO3bInNoS1CIAmNo2Jn8p9i3ztl2GrSlU1uVod AYUlOEYhu7WpOVDBB4F8HlaNZTcrxnZvZrnK3rRaMzqZ0qn2IreD5QVuUGWMtTOb4AHX CW5InN2aAW4DUqsIRIcqw7uxHuzGCwOEClUBAp6HA57Fz8M/jhGRsknhaFSOlVLB7/Nz IZzUhbhQ0OrIUDOxe3s+Yz7tlQF9L0u5Biy/juX7xGaG3VGxCX+sXzsx5Uuf1uFECy21 0JhHYu7/7/7CNl46OOsD4mQlqmxIeKZuZfYgmtZf87Pb4sObJS8jus1E1U5dkKuRSvE0 nR2A== X-Forwarded-Encrypted: i=1; AJvYcCUVL0e5Je+s57AA6u91kwa9sffa+BgDebQY/kqSK9btwyWbiOHXj7/he+GAA8rqJ4lVH2RU99YPwA==@kvack.org X-Gm-Message-State: AOJu0YwcomKBgzRFdHKGr+STgBMa+X0kW+b6ri1UGEQ7einlysuJsnqA IIUVXzjKSirT7O3rIVb72oze+E4a2nITQe17iMHJVExeVd8b6rnX X-Google-Smtp-Source: AGHT+IEnamfg1YzMrkN+Y0xDuc7LwiVl+tEE9IblD4TwlLvLyB7usjEJR2zCtegZ59qGLt8W+vQrqw== X-Received: by 2002:a05:6512:3093:b0:533:45a1:88fc with SMTP id 2adb3069b0e04-5389fc478c4mr260702e87.30.1727370428211; Thu, 26 Sep 2024 10:07:08 -0700 (PDT) Received: from pc636 (host-90-233-216-205.mobileonline.telia.com. [90.233.216.205]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5389fd5e365sm13887e87.79.2024.09.26.10.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 10:07:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 26 Sep 2024 19:07:03 +0200 To: Vlastimil Babka Cc: Uladzislau Rezki , Linus Torvalds , David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , RCU , Shakeel Butt Subject: Re: [GIT PULL] slab updates for 6.11 Message-ID: References: <8d6c5d10-5750-4472-858c-eadc105453be@suse.cz> <0295538a-4b79-42bf-b0e1-5a905749de1e@suse.cz> <88ed491f-4ae4-4cfc-9be2-dda3de56813c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88ed491f-4ae4-4cfc-9be2-dda3de56813c@suse.cz> X-Rspamd-Queue-Id: 662C6C0013 X-Stat-Signature: 76dcd84s86d1h5hdp6j77cefqc1bt5w6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727370430-197500 X-HE-Meta: U2FsdGVkX1+NhuuEk1S5mvYqfOf+Dhh0TkpVyQpVzp4QoIORT1lY2fVV55DPwGPlLvHUCwTtfI8igAz5vnLy7dpO4gbWIr0i1s08rd+GJUMh/8n/c9wEf5Dbn0oLISLjC785u1Kq+Ro2N+NxPNiUy2Uc5fU83xm85m66Cy2PY9WL7YCoimIfz0KEIZ/IiwD3ML1jV2HUPxcXakI2/+0HQTIJFsE5QsEhRvfioARL/M4VjDqnJYSnRzawiTbjOyf2cE3ckDxrX4BxF/oEnaFrFIMZftNQdUX9f1JTMrVAsTMP2i6wjux6S9c6Cy4KcR3zIrAc9G8xFWnlcGOKrC6DtTgxbqnSwr+9hNxNixRz3T5OLO0bOT+rZfWlcWHsTd1tO5C5zgSUsSljOTOg1LAuIhsaEQpZjVV1AZAg8ix0eo/ePsnCCjCn9t3CXcDur9fTnga+fmwHFwtIJ3X6t3Qr0nQfoqAqg0bQRea4xOmLvf69/uvF8UyWLo2w11GgbQ+TACc6eaurHDKA0DRdxMXLWmIv4WGiU1ppQB/iS/y7X6v5ZDkNvP++ei8DWPfuVEy0qXRRJPHUs3hL22bk2Af8c6cyqQyvj9suhnueb+PzthPqD+CXXVO3mn24EmwEWtfo0R5e8NHSMuGLlT6ElHc9AwcAVArmK+tZP+gZL+lkJQkAhmwqxrEsLS72XbRF1AN9R5kObm7FvEa75Kwa+ZLBI6u52uq9zFdt6FUKzg6vavbsx6pkVZsDO54DO6T78oZlnhutOxz1Ndm8U2iRacFmUFH/3l97UQLXliGsKdE3IX9TnBLOv9fnea1bwsZVKu09v4YN8Nd9EDRtsgTQffkQAa8Dzz6XHq+rQclmq8kvwmPe+w0w5GEv5OtEIN65xOSRO4NstryYOMJvcPwekVNzgtg6cA9kVJmI1TPUSHqjGklws3KixVwx4tOq5Cs5qcCpKEYkCHYP7z6HGcXGA+D 2aCvBH0B Mr/+V0S9vDk413Mb4Dge/LyEHwc+z28iJclbyeqDmYvZNNTQrUCkQzK/2NBYBhHoAEQMaKuLY9OghQ7nuEwRpK2DCrXXFpNWM0LFNIW6cFiGa7JH6YcKrAi82A3H0EVtw2tjE20RTcqj2AyCrMzaegv77Gm2Lbw6a1/2sUZTszWgerM7Ca/zdG1I0O2xBR8Spss0hnp3zxm+r9xp3uELEEA/I8siK+gQKDw49tSyVa9sgz119n0t/TVhHTBFqz+ewh3DEKDWsKSk++mO5qrp9tn4xbzaSKon3LuDlfuUSw5JNOHAkeSn/dN0O/mO/REBxYOMtN6/oSICov+nHJ0HLuS3ZilHuUVQ5cQm2zOXtqJp/xAoRyQj2Sb19l+Yol0k8K37s991WzzyPo+hWylW4Mg0+ctoEhGUgWUNAEYc08rgwUP0wWtpC+jZ9teu0QnDQb0q5KEQ4w0A7KZZQtXOAHeVSZK7NpvqA82nbYVly69kiXOvdCHD16txDGyv1v9T2R7Id X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 06:46:29PM +0200, Vlastimil Babka wrote: > On 9/26/24 18:40, Uladzislau Rezki wrote: > > On Thu, Sep 26, 2024 at 06:35:27PM +0200, Vlastimil Babka wrote: > >> On 9/18/24 16:40, Uladzislau Rezki wrote: > >> >> > >> > Thank you for valuable feedback! Indeed it is hard to follow, even > >> > though it works correctly. > >> > I will add the comment and also break the loop on first queuing as you > >> > suggested! > >> > > >> > It does not make sense to loop further because following iterations > >> > are never successful > >> > thus never overwrite "queued" variable(it never reaches the > >> > queue_rcu_work() call). > >> > > >> > > >> > bool queued = false; > >> > ... > >> > for (i = 0; i < KFREE_N_BATCHES; i++) { > >> > if (need_offload_krc(krcp)) { > >> > queued = queue_rcu_work(system_wq, &krwp->rcu_work); > >> > ... > >> > return queued; > >> > > >> > > >> > if we queued, "if(need_offload_krc())" condition is never true anymore. > >> > > >> > Below refactoring makes it clear. I will send the patch to address it. > >> > >> Looks good, AFAICT. Can you send the full patch then? Thanks. > >> > > I will do so. We can send it from RCU-side for rcX, this merge window or > > you can do it. > > > > What is the best for you? > > Guess I could do via slab tree since the original commit went there too. > Make sense. I will send to you then! -- Uladzislau Rezki