From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF541CDE024 for ; Thu, 26 Sep 2024 16:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B3B96B0099; Thu, 26 Sep 2024 12:41:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 588DB6B009A; Thu, 26 Sep 2024 12:41:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 402AA6B009B; Thu, 26 Sep 2024 12:41:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 214986B0099 for ; Thu, 26 Sep 2024 12:41:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 984A18180F for ; Thu, 26 Sep 2024 16:41:03 +0000 (UTC) X-FDA: 82607454006.24.CB20411 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 9EBBBC0008 for ; Thu, 26 Sep 2024 16:41:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aZG6s2da; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727368741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JU4mphy76HwymguPoEKzi3kj2OGTpmV+ZH2XF2JvXyE=; b=MLpuQ6+niZWNw/96tEumgNebyNa+9m8SdayHh8GKF3b4MqpHWL3tviyoRWM20CK3jHoFQQ HS1DnGkn7iBvy7GudSEBtQfcpyXnWIlso9j1X+WG+dHw5dPzPzvkvvTg3iuL26SpDN/DfP vtw73TsAcabgZa+QqrmCKnrJB5orHmE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727368741; a=rsa-sha256; cv=none; b=pzGfafzBaAKj1EPf053UyaR6sy924YdOPJ/X3PZhZhkxfV46zR4aLDmzQ935fcWOTvfmHj dpyZNfs24uQWZ5LL36RO/4SgUGQiUf3ss0I0vy4E6M4SmHzlgt0py7QhxDBSZG4rgH7Pp1 Q8sw0c1jpVuj5uOjO2bHcjtrQGNtoiU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aZG6s2da; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2f75c6ed428so13921651fa.0 for ; Thu, 26 Sep 2024 09:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727368860; x=1727973660; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=JU4mphy76HwymguPoEKzi3kj2OGTpmV+ZH2XF2JvXyE=; b=aZG6s2dauM+JUYGjEyyd2+MnhU7vQipG9O4SRe38hPtfR7UwLkwAvjwDjP21DrgAaO g6jgtfZhiQaTck7rfajouut2ep+sGUzHOzsQWk8mUN+eXEeBMGq15Ou8/16iEHDGKVPj p70WFYnGjEWZc/I0RDml8Jvc5clW9adN7Dc8bYx9XlHzZsZ9hXdO/mpc86RxkxVpqaMo bqmIKAVDSUgTLhPqFxlcdio5x8BGMGnWohf12Y9TR7EgzrOPiSiI54VJI/pCG+2bZtpE 9j9TGtnbFPof3dWefYnSUfPLIfZ7A05qdMHfWTLTwxdjRKhz9CF0mLnfg0NSe2B/r/ji ry3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727368860; x=1727973660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JU4mphy76HwymguPoEKzi3kj2OGTpmV+ZH2XF2JvXyE=; b=M5cBZLbPLeihOFc/XDnk7r4UNqzpiv9v7vVlM9Q2vaolgYT5TTtgfgcaoUxW/E3C49 Mw3SwXmTAAf3MBSsTAqlrvY3uoD8uSn5QaYHx0qUBEH/Fkl8Z4VM+L87CTMh/BX1Ovru JE4fbl3wlqtGfU6rzYC2af7ixalSpfzYzWdqguCDsol7Fuja5n4HlJX/Qi7mDqKLZFmn IO4bEPhb4cIGyi8jWKDqkwd/Lw9Vc8iPFNzPAGurCw7moLTT6RgK0McJPapD0Um1HJtv oajhvbwbAot6Uejm6U54GAlnq+fAPDCV8YR4kPmBpK4IZ6nQieDI6f4OxVvxiIlM2RVO 7eXQ== X-Forwarded-Encrypted: i=1; AJvYcCXuVaZaqrAvQD+oqJoZZCh62oEqua0cJoy0bwUUK9pjweVb/e64gQC9yHmaBNBmGY58JsSX0BYE9Q==@kvack.org X-Gm-Message-State: AOJu0YxHMabaNs2CrxLsiFkL5dq4i15qPtULp/gTvA7m+ccyF0mBD4yN UZKEPPC/w+OOt4VP9blebo4zxGtFt8hJ8ZSwVWezVVURUnDrYJk3 X-Google-Smtp-Source: AGHT+IFNMjJtobgVHAE/mIi34OHyZUsl9oqOCVmzQ2Ns4AEr56Ppkzvzlb4OxRDp1AHrcPkuPiJpNA== X-Received: by 2002:a2e:a58d:0:b0:2ef:2cdb:5055 with SMTP id 38308e7fff4ca-2f9d3e56140mr2340081fa.20.1727368859388; Thu, 26 Sep 2024 09:40:59 -0700 (PDT) Received: from pc636 (host-90-233-216-205.mobileonline.telia.com. [90.233.216.205]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f9d45d7a91sm86511fa.47.2024.09.26.09.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 09:40:58 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 26 Sep 2024 18:40:55 +0200 To: Vlastimil Babka Cc: Uladzislau Rezki , Linus Torvalds , David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christian Brauner , RCU , Shakeel Butt Subject: Re: [GIT PULL] slab updates for 6.11 Message-ID: References: <8d6c5d10-5750-4472-858c-eadc105453be@suse.cz> <0295538a-4b79-42bf-b0e1-5a905749de1e@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0295538a-4b79-42bf-b0e1-5a905749de1e@suse.cz> X-Rspamd-Queue-Id: 9EBBBC0008 X-Stat-Signature: kbex785ay7zymydwnjc8cayga4gefxeg X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727368861-557881 X-HE-Meta: U2FsdGVkX18xYvm6cg1d79nD5zjOcRrWP1fWmyc8fzGTv+7BLbxoqHPlOTDlLewBb8dJwP9d5GapqwSkym+YaxAbDVT/hmL56KbSIZEXkGd+isOXf33d+Z1kEDo7oKZhzpWnPbQD69s1II8pS+6cQjcDYIzB9W9Vp0WmrHqhkCc0mpJSuwbkcAk52Ohn82NubuQadml3cnxItmuC6wIa0LYkZpLD5DJE4pVx3YpnOzvVHyaUppVYcL8ablyBuYBhNEjEUibEn3TmK1/kFGRZT9L61PgBw1xgX2IHxFRmPAMeexk/Y9y0meMKfiN0r9znHODKWb8Z20+NXpFTkBj59jzsouzb/qxxFpMPJt3BUx3b70Xagds8CJ8d05ZzabB5MN/K1jVdYElNJ89QfSPD5eg6gwGlSY4wBpccqpemtH1j9blJtIktJMNnaLbjQv9zJyGU0KJ3cJ7MSfyupQWqWixTpq5zJkRvglHsvhm7oJNgj8oUomHtIbSFT2KTvfedrUC6Hjmtt2hpfQ1ZXkxg6I/+PQdU3PwLk6W7hcfw98c4XWFHYyZuGFEzeMQ2xL0bU9t1k/ofmFtNQx2cfYIv4oe7CnR/eIH8Gv9Ws0J9gLqG8F899keIvHGBDRkCANsckpiqg3ZJHuiNtGyJp0ifsR/0dt+UtM+iFiFzlgsG5Q1ZjAuHVObr/GwcPM3uV+56brLpyYu8x9cH4fv9odhAz6f69TsptAtvP2eNR9fyrHgUiypNA4heEorrVlf1dtWgB0pnrdOEtAv8wVCCdv2AqKEYH/EqejfmY9Htst2xMdG71yGbRfZJ2Zw2U6E/3ZLH9mSBKh6lcbzSsvVdsJuOh3iBlzcfVg0cx1aJdlw7vzx/0xMpjuJt2jFMKog0b98NGZIzWSMJVfsodvdNT2nXh9paFNZTC3GDvzjKh0cF+cjLp+Hi3kBchBlgmV8fzbE9IkUw25a3hq493/4EfDV YNsWb7Jc mzG0ERxDyfUQN+nmK9YRk5ZNBBfWxa3g7PLAi7nfTjNWaINYQPDeB4Sl67FZoJsVi+N3+XhnVIXyxj6ZEjJTCQYGK+LvVhRuIn2tg3XNBGQienB2r1ZO3ii5EwXeuK5OKWOw7D/XkfhltHqSi7REfwzxVWgcxyEfc1K15gAzkOScZ0dTimG3qcqm7FeNXzEKB1wY0RIkZf8/QIMt7P9KXjQ5OTwdHpXIuV4Q7H5XRqTSbXcF1MwKJBPuYuutMIUU81sTFeqs9pwhfM2uuNKpd4GJV7pSn/M5RzO/f9iz9ODeDr0piP2UecncSq+OWyoSWDlVJ1tEmwOQcxCMDkeHX2cr8CC6EKPV57vaNYSHpEEceMnk2T7JlceOyGz8kpKtcAkSaYLL8v4VgTpFYNiEOThCJMeMYTM09UUqnqv7Y8TbMDRHolgwRQ+JEHfDJmw2HqW7GVM2ZEy0K1dTOtSMBJRE04xxDtubpgBZSdF5qsHx02MEE1gy/ltRT9BYfiT7QdC6S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 06:35:27PM +0200, Vlastimil Babka wrote: > On 9/18/24 16:40, Uladzislau Rezki wrote: > >> > > Thank you for valuable feedback! Indeed it is hard to follow, even > > though it works correctly. > > I will add the comment and also break the loop on first queuing as you > > suggested! > > > > It does not make sense to loop further because following iterations > > are never successful > > thus never overwrite "queued" variable(it never reaches the > > queue_rcu_work() call). > > > > > > bool queued = false; > > ... > > for (i = 0; i < KFREE_N_BATCHES; i++) { > > if (need_offload_krc(krcp)) { > > queued = queue_rcu_work(system_wq, &krwp->rcu_work); > > ... > > return queued; > > > > > > if we queued, "if(need_offload_krc())" condition is never true anymore. > > > > Below refactoring makes it clear. I will send the patch to address it. > > Looks good, AFAICT. Can you send the full patch then? Thanks. > I will do so. We can send it from RCU-side for rcX, this merge window or you can do it. What is the best for you? -- Uladzislau Rezki