From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DA1CCF9EB for ; Wed, 25 Sep 2024 17:59:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D97E6B00AD; Wed, 25 Sep 2024 13:59:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 195596B00B5; Wed, 25 Sep 2024 13:59:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 078486B00B6; Wed, 25 Sep 2024 13:59:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DDDF06B00AD for ; Wed, 25 Sep 2024 13:59:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D9271C6D23 for ; Wed, 25 Sep 2024 17:59:31 +0000 (UTC) X-FDA: 82604022942.05.F35DF7C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 9FA358000A for ; Wed, 25 Sep 2024 17:59:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PtPo8yWF; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727287050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rLHmpQDjNbRe8Fs3fE9dshz0/EVZgppn8nMr2Vj7AXc=; b=oB9/ow2WRHu2pLmW9foE7z2UsJVMGjgVL/hGxYc99sWMO5qRnnZYxsINafQUNDaMBN2LVZ oiCkE3Uqmedr6AshJ7gtm6G1lxHxgPAkOH56E++VkRoI7rBK7fmirXHehNmRDCkxkqYzKy YMwOg1VhWImmjuUBb+TDGX+RUNr+5UY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727287050; a=rsa-sha256; cv=none; b=6vxH+FR63hi1DIGZ+Kc4KOvxlwXAc5hbbY0W5CQ4XvyHYvAloFIfk36IFfp/MD4xmoRaYz iU0twjmSUOlAl1B8P1Hq+SjGwBmacRAMTeDXYsWj20xcNJzZx1UMuW5QrlryQS0dAUiZvE h7lu44nK+ft3Spu5vas9f7sU3YGzCnQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PtPo8yWF; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rLHmpQDjNbRe8Fs3fE9dshz0/EVZgppn8nMr2Vj7AXc=; b=PtPo8yWFySOnUSC27T8ubZRbrg d2uEUjme6SMF+IBm+BQTO16RCCKBDeOAp0zd3x8u9V6EM5wZpWY8DKUmYszH9T7FrHTl9tOO2Ie33 WyLj1yRm65zV9AUenHKqvPiYIpAq69UJRRbEIH3YTmEB+mz61tvgEEd55hFESkxYk8G9Ca6TEfcm3 VgrLyvAW97jIEGQ+Tv97t2Ud7nLQBAbxkjY/DPcpBOZ7xMdjJPd+7xLVtr/4Ow7+ct2iyKeXVfp+D HtAs0tSDYr740tJv+1KVZe/qJeEwOLoSyw04u7VB5Uz0h0C2wXUV9teG4hGKRh7G1ajl0VC3ZcTOu urB/DvUQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1stWIQ-00000004Xkf-1br3; Wed, 25 Sep 2024 17:59:26 +0000 Date: Wed, 25 Sep 2024 18:59:26 +0100 From: Matthew Wilcox To: Leesoo Ahn Cc: lsahn@wewakecorp.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmzone: remove redundant exception handler on pfn_valid() Message-ID: References: <20240925155540.4087150-1-lsahn@ooseel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925155540.4087150-1-lsahn@ooseel.net> X-Rspamd-Queue-Id: 9FA358000A X-Stat-Signature: 71is7ador84mkd8rumk4yq3xiewuayxp X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727287169-707828 X-HE-Meta: U2FsdGVkX19a+TBt0yLV9AtgpCmJ3gXAkHNThVSFQBj+tT97qamXnxzxAwf/GZt98o1/Cg/HA8LA+I2BNm3ciwUmK4DSR+Bdk7Pc5+it9PVp9rCCfmSVkOZaEwIY9/dntbqL+A89b7C/JpEnOe2t3ZqGqfTIKkhQ6F3XSUZqG9/h7Aiq8Hf/oG85z16Rz1i1mNYRYhvBZEAeRNQxYStq16E3BiT4LrejkND2GTueuGU7eUNgmY4mNHIKbBaR54cDcG3MbW2XDUuEs0J2AsEZJEOc4wyJLKSwB5LRtOX7x1x0B5aj02cZH4El4HkqAsOZ7jMOPXwyS78MXk3HUYEslsMP68kBQUyFx3TyXuCFGjcOKs5dG4dNkQX5owG7uogdZ2K8oM0wuTYsNFRzc+20T4procrYeHskjwMUigjCzLOOMklB6VbIo+yCUVDX/K0f+VxrMV2wjyhnOzzwveV3Yau2z53fZ+XYyI3+V+uXt8pcCPQ/irQICpIQOzag+18zqGzsbDjfPB+Wfqdf/HR+NiOmBDRBp5lDK8x5JrsYaGg/+1zZ9i4td55iOy7qZtIMNLiXs5yLrRuDySBRHGUmcHbnAD/yLXTMQTDCRkiYV54kom9GaNn+gbfMk4WBDM3EBjN62x/7/6+WeY04UmxoKKS8WXRtwpJqvEDN4o2JndwF6dXOKUutt+kNUSCL3iMpLH61Gm/YM+clQyevvHcYjyKAW/XhtL4BKI5PXNeUB9l4d4ijbCl9X6O/zE95qH3QzrrA0q+32lYjyvfklsvGiBkyEdzbncMCmtuP2PVEMWKrJastyrTSkj4Gw4xdYteW1y2b9BhGu/NZU06ZqGbc6cBUWG5ojFqeTGFJRgdRV5QuyXUTlFDAubcgnvPDaK+ysGUrOJgaHh4R7htwkWfxS6YolC7XLdmsMRMz1u7H3borysSDWxsvoKC0sDmBMwVp24Ea1tATDfftuFD5zhp 3w7qUPnF c9djqMKNaD9vH6kDoFSIzmMSfVSvUn6AhPoQKnMHb1fHX12u6CDLMubRNqt8d5M5H/komuWO76Lk6huNcZCSzlXQ4367/5dLzKh4izFOdYi90adXZe2L9y+QHYsRCS7abl6R9YcL3ttQ0gPAv/93BtmPeEQEViss9QQoV4WC88IJauk9auxh0V0nJIQY7xXYvbNuaVspb+itK1j9PQR3UVCPBkbv+9khZOW7w/OpsNtyPy/V8oFrx8C43AjryO2SsfEL/oBwq+lII3dfiCM8f5GqctA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 12:55:28AM +0900, Leesoo Ahn wrote: > 1). It can ensure the upper PAGE_SHIFT'ed bits of PHYS_PFN(..) are clear > by the C11 standard: I don't think you understand the purpose of the code you're removing. > +++ b/include/linux/mmzone.h > @@ -2028,15 +2028,6 @@ static inline int pfn_valid(unsigned long pfn) > struct mem_section *ms; > int ret; > > - /* > - * Ensure the upper PAGE_SHIFT bits are clear in the > - * pfn. Else it might lead to false positives when > - * some of the upper bits are set, but the lower bits > - * match a valid pfn. > - */ > - if (PHYS_PFN(PFN_PHYS(pfn)) != pfn) > - return 0; Let's assume that the pfn being asked about is 0x8000'0000'0000'1234. The actually valid PFNs are only 0-0x1000'0000. This function should return false. With your change, it will retrun true because it'll only check the bottom 52 bits, and ignore that some of the top 12 bits are set.