From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2520BCF9C6B for ; Tue, 24 Sep 2024 07:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4C9C6B00A4; Tue, 24 Sep 2024 03:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4F96B00A8; Tue, 24 Sep 2024 03:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84E726B00AA; Tue, 24 Sep 2024 03:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 634216B00A4 for ; Tue, 24 Sep 2024 03:02:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 108441C60A5 for ; Tue, 24 Sep 2024 07:02:40 +0000 (UTC) X-FDA: 82598738880.07.9C2361E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id B9D34140003 for ; Tue, 24 Sep 2024 07:02:37 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WGFtxSrN; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727161271; a=rsa-sha256; cv=none; b=8c69PyKGkB2T6Lhm4bb8UiWhSa0zRUu9sSsh/aCpsCi5uWIrz136pzUf3yPfenWS6MjgTJ 5kdu7Zd+iXc/ula8/b48/cBkwW5bYqGucUuyWjviBf8E8y4lVby2r3oyct7QA8+SumAOKQ r+S5tr2SdNTH+MFzFWH54Gl2TYscBCY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WGFtxSrN; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727161271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FMeWTOqOAD7M1LmcnAkvVkBSA2an0KhGXWy8GvrGsn4=; b=BzvUBtoNdPuHLlJsY75+k4WEamdmDy3m/JxGOr3Y/nAZlfWAc06zecrG1OXrEs62hP685Y DQ/hl8N52ZdFdXdnRFmIQvarDGAuRtumdKf1ynfR7epqtpXqOHHm++6s8JrFEkjB8k+h9J 0Si17XR7s5BcMGLtFct2x0rcfqD9oO8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FMeWTOqOAD7M1LmcnAkvVkBSA2an0KhGXWy8GvrGsn4=; b=WGFtxSrNdWZ8vxKtyyAL5oa2RJ V6CAqtDiQyR9HZ0OEpYOtRSPkUixNfr6KefhjnV6s1E7bl3r7oYdWNKqXXex03jf/XwTVg1jgiBrW cSfx1PpoXPFi9LUTMP7GnabDB3gvH2928hQl8HfuXki/OKKd4A80LQz4QkVyCCAHM1lrNQTRryObX snByTuNRM2VcVLS9BKWnBetDl1k+pB7ex5zuJpoo9ryHLpJEKgTrqYlPayPmO7cLyUiqxLR7bKjoo qnDlwFuETCGdLHdG2/mXuPR27+7I0JM9/kNTjZBZJ6ANgDMCb72iELJhKOGdQT171GpabJ066n+3B 8kVMONig==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sszZD-00000001LEW-2UTU; Tue, 24 Sep 2024 07:02:35 +0000 Date: Tue, 24 Sep 2024 00:02:35 -0700 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Christoph Hellwig , Andrew Morton , Christophe JAILLET , Andrey Skvortsov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants Message-ID: References: <20240924050937.697118-1-senozhatsky@chromium.org> <20240924065653.GQ38742@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924065653.GQ38742@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: B9D34140003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fcjqiun1u1srgrzna4zz36h5z5tnx8p4 X-HE-Tag: 1727161357-226180 X-HE-Meta: U2FsdGVkX18HYvK4XxwTKAQaWc4PocY4EeiZ8/c/JdhuGLE2X2r3/c2VtU4LyuQ27OUSa9RZA97Pm+jf4tEjLf1Tcuy7ERbItf6cLe8N70gTgofwp9+iIP3n72AuOdTv/a5uYURUVwz0BsV1cnEicQEeOjEDanwwsPbGKaM9/g7Tw4UHOJdQiKoOIIcais5XxrGi/lik7WjHh8V0Pd6/JuVwPll8WNsFOBOmjmML4Pd3q5+DtG078V1pHTJrfhfU4IEJ30V63+9FUlCg+GcgtKJBPATOQFGZJCKpwTuxT6cXF9r3YvJdvQbT/KCu6D7A9KdE1Qcm2jmEi16r1hnpOo0eGn9tM06xZXCLgtF0AGpANZBSsjOlKiwxgsrIvCHwI7mpDfrqeC8gBBK+OHVG63fbgE6T2kjcFmKjVxEp5rTcU5sRCuqWhwZvEyPmQviavtmETP9+TmgCEW3QiiBk6dhy28IruqsqS9ACbOgUvxfBQhdeeNSOn0aKZJl++6eI76VEQSuOpca/6BR5LpzewezwAj8LPEfvYSp0ZS+qwsY2xZuZYzxN+q7hpYdroy0GYFQwQSEHrAQe9heodfKBEIO6/MDewPDQJnZNDmMa95YEWJ6d6Bu2TFoM6fisqOXDryzQHzK73ruTAHO2OhxHSMnqaMgQxn5O1tnRMBUDc9hEkvpi0lF/cmZWdodr7iQcJvf0+y3xpfxabNFqM2bpLGEgWw7EA2RhrgfOLzxwet3Uo5vKlV484XM+cMrvr12Ly8v6EqdYWbgPY6u/VvA97Gri64oqotYC6ijbX0vpq3wzgwI7awPeWcADyjEP8uTb2LVP3K1vy3GakqoXiukWwrr1a95A9MaqUK40W9zdGiPX71qc+00EdjuxBnn3rtv6I788wnjBp0OasDb09rEKKhKJPeaD4qkwHNYqm1IZXtdkaarNdcH/hF85uVPlpyfShjdgh+GwYnqjYjcsr4K 2FzCc3lT YYeXZXX/Iaqe9u2SDIGLttG4/E+QrH694YUNJm2vZ9SnZzw7vi3Ey0128EYFgZxG7bWdwpMgZCkxDy/Z7Iv9SDaszTZyl51fA1ojC/z7DadzepiOQ1rtoloElBHBePUcEhgQEfNDK0JXMJ4h8diN1vvDLhm/HpCbCgsy+9BFDVjlpUaRBgJAiBhBdHdhOuMHvQN8rkNamfnNtTnrfQho5dWYccyACkGCqeaSrCMXz8LdX4+AH7nt1XMo6BgsaXB38ltunz0vpuqh6UWSeEv/k9U12gyPhlXkBz0gNnbeavo451KePQNP16B/W+UMApsWugf/Gdtu9RCgJZ0C2ehk7US1l9Gv1HDYYnCML1Mz/AqNrvwsm9lgeXRF9K75qrMAsaAqVPI2IofPrSKj5MgKE9Qt7V65KNmSJOqIysV6VL61tL34Cf23/Z+uRr6aozgTx93X41wEtxFtjfWXaRtgers/0u0RGgdxrzN7moxtGMzaFXmvATjExnsdupGKonELtxgFihZXesbwb17r4bHjwxPuDC/tnGjjRM2o8qVWWH/HegfM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 03:56:53PM +0900, Sergey Senozhatsky wrote: > Totally agree with all the points, I haven't looked at how > popular that API was before sending out the patch. Is there > some sort of "built time const" but for strings that we, perhaps, > can add to kfree_const() (and make kfree_const() always inline)? > So that we can turn this > > str = "boom"; > ... > kfree_const(str); > > into a safe scenario for modules. Not sure, but even then the API would be horrible as it still would not work for constants in other modules than the one calling it.