From: Christoph Hellwig <hch@infradead.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Andrey Skvortsov <andrej.skvortzov@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants
Date: Tue, 24 Sep 2024 00:02:35 -0700 [thread overview]
Message-ID: <ZvJkC_3cov1rfY0V@infradead.org> (raw)
In-Reply-To: <20240924065653.GQ38742@google.com>
On Tue, Sep 24, 2024 at 03:56:53PM +0900, Sergey Senozhatsky wrote:
> Totally agree with all the points, I haven't looked at how
> popular that API was before sending out the patch. Is there
> some sort of "built time const" but for strings that we, perhaps,
> can add to kfree_const() (and make kfree_const() always inline)?
> So that we can turn this
>
> str = "boom";
> ...
> kfree_const(str);
>
> into a safe scenario for modules.
Not sure, but even then the API would be horrible as it still would
not work for constants in other modules than the one calling it.
next prev parent reply other threads:[~2024-09-24 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 5:08 Sergey Senozhatsky
2024-09-24 6:14 ` Sergey Senozhatsky
2024-09-24 6:43 ` Christoph Hellwig
2024-09-24 6:56 ` Sergey Senozhatsky
2024-09-24 7:02 ` Christoph Hellwig [this message]
2024-09-24 19:45 ` Christophe JAILLET
2024-09-24 17:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvJkC_3cov1rfY0V@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andrej.skvortzov@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox