From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FDBCF9C6B for ; Tue, 24 Sep 2024 06:43:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA716B00A8; Tue, 24 Sep 2024 02:43:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7A4F6B00AA; Tue, 24 Sep 2024 02:43:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A69EC6B00AB; Tue, 24 Sep 2024 02:43:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8A3596B00A8 for ; Tue, 24 Sep 2024 02:43:20 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3BF29ACB59 for ; Tue, 24 Sep 2024 06:43:20 +0000 (UTC) X-FDA: 82598690160.02.24D668A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 9ECFF1C0006 for ; Tue, 24 Sep 2024 06:43:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Ka0uon2z; spf=none (imf20.hostedemail.com: domain of BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727160138; a=rsa-sha256; cv=none; b=ER2WLBpFhRy57JTarL/p+BQaavEvCbS9tH44skXEHcFX2DuNyiOaAFBh5RL9z13fcqY1+I 9yRm61NNXONZ/O3Xk6IXTAH4uN1SzgrjjJo4+v04x/Ru2s7MBpK68ysJ5r1LYeRLBPXWTB q0vlEWOulbqiSBduTGDTLG3BcAJroRg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Ka0uon2z; spf=none (imf20.hostedemail.com: domain of BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+421eae2cbd7e7788c998+7702+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727160138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PbJzwROUpOmaLdozFnNNaDRLerBVFk8Lgsc+PwcLyc=; b=b6CLUcH9SigP0fWUGoPLeHu+Cu82qthGiS1Nksf7B/BgClTyL64V89/oAZjFDP058TewaO 6F998tY5lu4ipfdFp/RrUeJiPmqPXrHz5cda0DLaXQ+JIsKZUmDHcMlCRLBoYUC//xsZh5 oYmLKJiuMjzLkZaWzxw4QWsDH4IqlPE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3PbJzwROUpOmaLdozFnNNaDRLerBVFk8Lgsc+PwcLyc=; b=Ka0uon2zqIMJo0sNG4nL3Ikk2H 3aBSSz0O7w87unRL6Fy+MN7IAJTz1kLBOjbkckXSIWB9dXvDnHq2GmL0pAljx7ntG5TBydG2DJzea Ppo2h/8WQmJEb/Bcum8x+2bH3tTV6pEUPmZDJpzXTC9v7HhA3SecoovwLMDwIIULdMGlI+qR1NASd /oLBeDvkW8b/mxymEjgfcEI4g0v92/i/Wshpr5x4L+C4njE9nZqsGw+3tjXy1t9+OdsC4e+bIpI/P K5DVUpFfkMPeUVJ8Uc5NuR4x3V9zTQXYAZ+fxXR9BVJBoAUHE5TgLpY3sqXySg1FtDpOGcN+v6yHf OTu9nXpQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sszGW-00000001IVs-3QAI; Tue, 24 Sep 2024 06:43:16 +0000 Date: Mon, 23 Sep 2024 23:43:16 -0700 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Andrew Morton , Christophe JAILLET , Andrey Skvortsov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants Message-ID: References: <20240924050937.697118-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240924050937.697118-1-senozhatsky@chromium.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 5u5s11143j33oy8n43aghdfg4bb9thjm X-Rspamd-Queue-Id: 9ECFF1C0006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1727160198-828589 X-HE-Meta: U2FsdGVkX1/Tk3QdlUn7dmIBO9sDWEqpyPZiDMNaHWcpqW5WVDCSBK2+m/Ef45hbu1bTE9dV5AuWmVAHFBGVCqs8cIk53vGzaxBS8CkPcn/QVN0fi7pmFoF8VXjLpa0dRVQmWDC1CvnEPqyQW66GwJ6uTtUp9B6xVfZ+y/jiUEqrSTFcJYuJRxkAEd787toMDd9wdVb7zG+Hs3udnBTrHLtcyuElIxjv0pzor+R4DiMivzcPQ+rqVzAN5UEr9k7P1sDb4cseVXn8nAor7rQqIQ4Hsky2+oZ5xfeZyjBOGHZhgKn4LlJetbaXjNk8oY7TCWFDyOtaOb6rF2oqBYjx4pLpQWTesrWj/llpp1us4ziivp3L+0cYrnOkRiOHARh4gMGlPAF61y8Fm5oc09u4J29F7FbKaMN58/98XHRtDTaws+c+7TjldLUqlaIRNnuGuj0X5NzJQ2xIJqx3NmRqZmuRIP9LoOeWmhQXO5xbALwOOzmmOIV9FXwQfL+5lc2S4O/6H2tln+7OMwXmT/XiWGjSxjNQGiEYiR+BDGQuc/qGf7r5yhesc2REbOM+jxieMrjvezPtkfLbatY/xDYEl/6DCdF89Lp1E2RXE4e9lGZW5eF8Rx8ClvO3ADVA61qGKMlNyzC9Vyt50qkfWoKJq5lQCI8vQ6X+Bg2JjbAUUHgWaNDfhy+vvXFVB197m4sCoceuyOhk0/vlDdEhwQp/x69b7fZxwMIHwLYyA87+gr/d1dkvu2Q91GGmWSdRLRv6s2MubjIIsTr2lSMTF42NxnTcxjQe8CBGyBhvLa5SOtYS3BXSI1UpWP1WbDoErCAfSnEdVan7d5rZ0NLAF56oiHEQC7xEJftD+Ebeo5hi9hjVFXt7iLlzEd/Z2HRPsWTTrH1BTOknvSWywN4xt7v2VkA/n+NRZGsWjfA7PLH0vOQJoU+9sjYy6Qc5WUmJqQvQunLJ7I+YYH5fzKlv4h3 IO7A2YLq bChMbgJgxDU1IokKVsJMiGMFWvdVBB3gIDN7uGrHc0cTujY0vxoMHNuhl6Z2GUKXsMjRn0bCP53fiblCWEn5Tep4S24YJYmUX8oLyCmRjzG9xCFj2cH/9SK9DKXYbuGKIFJLjn/oxTUOSjFZVPk9ZI+jRJDQby5DvSJVe8zVr9a4yikb+Jl3nYLCB+t/ywuBe6BIxRCUQUe28jv0kb7tLSb4Ycu6Uw2ubiN4zrf6gQ544z25HGw9adgdOSpQPy1gdwN2nAAokAZWCIB+oANupBDbR3KF1klAoJfVuZfd6L9XMQdvSBoLEi0dvsFT3KZNoQndaXAFFkfclbk5QxozLW49MEpXZWmKoUoY/GuOjUMaoQa6Www8NzRz22FZKYUu1A+ng4VkIrUog/yyw7Ic8mvQI5wyX0qKCE9HcwbSOVuzjt5O5j5PnOG1iZcYcj4iP07CGK/QDtd+l6IwvQsSF26YipcFEdgWzE0Bveg6T4UyhKp+D/rHeOF9nbL3bwC8cctcxiaM+OB5fRXYalxy5Sp/6HicNPL0fjPeoH8u0gc6Uwc4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 24, 2024 at 02:08:37PM +0900, Sergey Senozhatsky wrote: > Both kfree_const() and kstrdup_const() use __start_rodata > and __end_rodata, which do not work for modules. This is > especially important for kfree_const(). Stop exporting > these functions, as they cannot be used in the modules. Well, they do work when called from modules, they just don't work on constant data that is in modules. There's also plenty of existing callers in modules. So just unexporting them is going to break. The API is kinda horrible, but an implementation to check for constants in modules would also be quite horrible. So I don't have a good answer here, but simply unexporting them is not going to cut it.