From: Christoph Hellwig <hch@infradead.org>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Andrey Skvortsov <andrej.skvortzov@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mm: do not export const kfree and kstrdup variants
Date: Mon, 23 Sep 2024 23:43:16 -0700 [thread overview]
Message-ID: <ZvJfhDrv-eArtU8Y@infradead.org> (raw)
In-Reply-To: <20240924050937.697118-1-senozhatsky@chromium.org>
On Tue, Sep 24, 2024 at 02:08:37PM +0900, Sergey Senozhatsky wrote:
> Both kfree_const() and kstrdup_const() use __start_rodata
> and __end_rodata, which do not work for modules. This is
> especially important for kfree_const(). Stop exporting
> these functions, as they cannot be used in the modules.
Well, they do work when called from modules, they just don't work
on constant data that is in modules. There's also plenty of
existing callers in modules.
So just unexporting them is going to break. The API is kinda
horrible, but an implementation to check for constants in modules
would also be quite horrible. So I don't have a good answer here,
but simply unexporting them is not going to cut it.
next prev parent reply other threads:[~2024-09-24 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 5:08 Sergey Senozhatsky
2024-09-24 6:14 ` Sergey Senozhatsky
2024-09-24 6:43 ` Christoph Hellwig [this message]
2024-09-24 6:56 ` Sergey Senozhatsky
2024-09-24 7:02 ` Christoph Hellwig
2024-09-24 19:45 ` Christophe JAILLET
2024-09-24 17:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvJfhDrv-eArtU8Y@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andrej.skvortzov@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox