From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB234CF9C5B for ; Mon, 23 Sep 2024 23:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577536B008C; Mon, 23 Sep 2024 19:11:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B1EB6B0092; Mon, 23 Sep 2024 19:11:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 303D46B0093; Mon, 23 Sep 2024 19:11:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E4B26B008C for ; Mon, 23 Sep 2024 19:11:51 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 96F8EAC498 for ; Mon, 23 Sep 2024 23:11:50 +0000 (UTC) X-FDA: 82597552380.10.6AB192B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 00CCE18000F for ; Mon, 23 Sep 2024 23:11:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=TWtx4cCo; spf=pass (imf24.hostedemail.com: domain of "SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727132952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k3C/OUt0U6Ap2O+4553rXu/pe49KxPnBMUvMSIZ+6eM=; b=gQae7XFg4WKAcZpa9pTDPal2fzJlA6PIxM0h2dWl01V4uqClRoIFeX47eLcVxZQbtgbXBQ 5657gOyeU9UUlW6K7gLjZ0DaQonlQkFxmrEWCnVmVtLrNPoZpnpdGiBCrbRwzOExUFwt6d PvAnH35qe44LsqIobQseGvK7nE8ott0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=TWtx4cCo; spf=pass (imf24.hostedemail.com: domain of "SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727132952; a=rsa-sha256; cv=none; b=LBjgQasymqn+t8Ftci0Padz77AuGdNvaBKG3BAfdauPh5VPw+XyoJ273uEfX38BWBDn/uA 8jDMXk/gnjwUOWOpytWdrdWDBJjeSHKMxyEz7JwhLq3VtAOIPxybf1LtIjjkXkMKOFgmpF fjkHEd3zMToM9qdhGg0cZWuNsc6E8aA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 55F6FA429CA; Mon, 23 Sep 2024 23:11:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A7B1C4CECE; Mon, 23 Sep 2024 23:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1727133104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3C/OUt0U6Ap2O+4553rXu/pe49KxPnBMUvMSIZ+6eM=; b=TWtx4cCoYUxLqtztKAfcfNHTvYS/lEKvry/0Fvlvxwmc0sCdO0YkL4c3rbUHH4Mb48DUEf sLYbJpIZo+lXQ+n7gyqA7N8qbWv/e1Q/UMOyfLBnPQPWag7imZXLrDYYUxW2crCUS8vGzF l6SGGjmXH00dTgVTt6Hl73vdO3BEAMk= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c29f048e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Sep 2024 23:11:44 +0000 (UTC) Date: Tue, 24 Sep 2024 01:11:41 +0200 From: "Jason A. Donenfeld" To: Vincenzo Frascino Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Andy Lutomirski , Thomas Gleixner , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Subject: Re: [PATCH v2 8/8] vdso: Modify getrandom to include the correct namespace. Message-ID: References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-9-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240923141943.133551-9-vincenzo.frascino@arm.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 00CCE18000F X-Stat-Signature: rsmc3b8mobq4ae4wznqc4anbrauxfadc X-Rspam-User: X-HE-Tag: 1727133108-821198 X-HE-Meta: U2FsdGVkX1//h2Y83ZHRitVYa5aDA5zdlA6nkn7oroesmrJd75gEYqhPhcGGpLJgBisfpsxyIPkAKNmh7QUu7weCr8XGFPCGX5R1Tr5ohiUc76r9/htuVWWKWBi08Gg0NyNr56LlRH1iAr5+VqVo8moqq6Q5tkZAVNZhd109qOf8ryE5Jf68t+6Kv1Q5TGmmp4TVCp2pCriYtgHFZZ0TFVIttx4D0nOqVJm2NVB90swrqK+bYPPtzJJNJH42sYbmrYHU2K/1nvN1uH4Pr0iUK7YuZaETQl3YBtOrG+su2vT60ro2iEbbn8bEX/Kk7aoJHBQJx7shUL9eLV+/O/dFi1Je2+tqXhctNaU6ST9RZOpeHmyqf/I8YhRRS6NqEu8STYNa2w7LHU/gD568MiJZ+AwdGB5xivLHq+8kH7m8yxfRLl7wgA94lhRbNikBUAyKIwtWOG/rFZ9+EyIhAtMv4//2My2nfo0VMbUxajDKlEq+o5s8qYmydQpo1TtJZeBEksS7pheG3egvDMIbznmJfV2IciOuLgNKlGE/ChauYvH3IfyzJ/6ildDOw/YIENNCILHz0bWJtG35MY1/t65M9voFbOYnN8PNxa2XQVSlcvPeUYx9Qu1MkiYDlwzUjLOjah+EF5zoyRxIYWrHVV3E1TJvneM82rvom5DJ5RXD9GnQhG4vCPk+PPylI7brm8ZJpXedRHkmdMeXiSEDkFDec8M/PYYqDfOrfeUzqOcuBa3aG2e9Cd6vY8oqOrGfb8wP1St8GSDqr9oSIj0L9CrwVEQKXE26F9oQ2GJHJGoP2XBjnbzL3pzlUvNezQ4d8brkB7spIlENk4glqZM8vX44N/AhXMYenYiKwbyDMkmE0af3ioOh2ftafwXL5u3EUMlMy0qwdlT0hgQznuM5rUS21glB2zgbwW15T1fL4Vz5BFCJyFKRB1gRtgj3rSTTEW1SpVSPlPax/bTDM7aP93d 4lfqkBNx YoXJSP3nkHivkGDR8Y3LdRo3sOk4s9EnEkdXdK4QWaCT0odOuINIUgwV6cUacvyzAbzskS77jllsyEMyFDyEvSiUx4vVHa3fP9RfERvNfRXBZv7U4vAXYrZc0sX97P4bDQDSioipZN7IWpMICdLbfPQ3VHWQTj32ALAOQKh9fhod/wf83De+1SYN37J++5pwI7wrXlrG+JVuGkrYSYESW4L9TkQFzbs4VXR3xLu7LROsGiD6nY+qRtmyVEgLtx3COdZpzdZiXWe2GqbTS8OMrlAIDv+RITlpeh+iboGM8xyvEDGnswfdgPV/BxPYcr5ppnlHGGtmQf47/E6GYnofApDhp2EnlPJH6ur69IkvfCG1bWFqRdp9wBOtxVtT2TeHx3yiagWgUbYIuqsExgduVmj1YCtRTks9qn8II1CDEu/hb+PrpvLU4ORr77w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024 at 03:19:43PM +0100, Vincenzo Frascino wrote: > - params->mmap_prot = PROT_READ | PROT_WRITE; > - params->mmap_flags = MAP_DROPPABLE | MAP_ANONYMOUS; > + params->mmap_prot = VDSO_MMAP_PROT; > + params->mmap_flags = VDSO_MMAP_FLAGS; The code that's being deleted is meaningful and descriptive. The code that's being added is confusing. What on earth is a vdso mmap flag? Not only is it indirection, which makes it harder to understand, but its indirection through a meaninglessly generic name that suggests to the user there's some additional property of the vdso or mmap or both that would imply a specific flag for these general things. In reality, the thing in question is about what getrandom.c uses.