From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA952CF9C71 for ; Mon, 23 Sep 2024 23:09:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4899A6B007B; Mon, 23 Sep 2024 19:09:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 411E76B0083; Mon, 23 Sep 2024 19:09:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B3536B0085; Mon, 23 Sep 2024 19:09:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BBED6B007B for ; Mon, 23 Sep 2024 19:09:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7FB17C165B for ; Mon, 23 Sep 2024 23:09:39 +0000 (UTC) X-FDA: 82597546878.24.B287A58 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id C7B3618000A for ; Mon, 23 Sep 2024 23:09:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=eDK4ISP1; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf24.hostedemail.com: domain of "SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727132963; a=rsa-sha256; cv=none; b=yTjoRhU6R4RlxrRDrzCSGwueBE4TP3agt+YY5048ph1RNxdg4ao/dwFK6dP5q+/JLUUDG5 IVKSN8rLKQy6AbhiCMToXtbA4ojToFS1Ky5JZgDRmWUSq7q+WV2QB8JFjVDLuS4cpB/4MW EOnXXGH4jyovTrlypOtW7eEpFLY0UIs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=eDK4ISP1; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf24.hostedemail.com: domain of "SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=QBxI=QV=zx2c4.com=Jason@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727132963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=43Vh0tWcrKvKgzDvUFrpyFzSlz2V2ztNJ6h2JpPEh18=; b=F1yWo3B6w9k5TILPnWs4it3wVGFzis0lzDq+CCdt9X0sxq/PnklorkLK79EAO06Lv11C/6 MtViPTjQDvBz2uO/fu6tZQCwyl+tt7gNiZZPAEFLuTae5JpnNL5LEJWpUsH8ljWSS+4nze yGbePNyQ1GVhgD7rBRh/ZVq8BcEDNWM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 95231A429A8; Mon, 23 Sep 2024 23:09:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E5BFC4CEC4; Mon, 23 Sep 2024 23:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1727132971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=43Vh0tWcrKvKgzDvUFrpyFzSlz2V2ztNJ6h2JpPEh18=; b=eDK4ISP1Sfxrg30+qTfgwlp5VetK0vNK7DrEB77tHN47PdhTljElxtvxoYM/9xjuvJu6Q5 Oj8etovmHmqkfZARS6r7RDFrTUVZVkPSbc77ewYI4eAO6gBSqvaJ7XcybcSkgsi7x3QfRg +G++Rsa58mUfkX/IE/pYqKs3FVZAadM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 603268e2 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Sep 2024 23:09:31 +0000 (UTC) Date: Tue, 24 Sep 2024 01:09:28 +0200 From: "Jason A. Donenfeld" To: Vincenzo Frascino Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Andy Lutomirski , Thomas Gleixner , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers Subject: Re: [PATCH v2 7/8] vdso: Introduce uapi/vdso/random.h Message-ID: References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-8-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240923141943.133551-8-vincenzo.frascino@arm.com> X-Rspam-User: X-Stat-Signature: ohfrmy8ej3y1jsa76fhkc1hqy4x5uknh X-Rspamd-Queue-Id: C7B3618000A X-Rspamd-Server: rspam02 X-HE-Tag: 1727132977-372247 X-HE-Meta: U2FsdGVkX186NmqeO8KxgvPTu9NQWnmhDzeujYLaFIJq79t+dvIkIwqRe9LdcDxD89yXeZmXTE7XH8HBBr10LUbG5RZ3FFOtQEGjLWNxleiBg2E47WqtqcFhk4sjN8bV7Vsis6HokfCxaBi6dnNHCnS+Z3EqnyehJZqrRoIm38g0/YbdtD/5+zkulbFdsYH/vdrjzaBYRq26fJkjavRP45kQCE+88dzDvZ30xbkx5k4w6EDyxEOVzKz6+r7vmUYE6taOWJ3y7bE9Vz2oYtTGvi9VXlRfCPVbRtgqB/nGBwZRKu/gLC6P/kM2N4bd+JJe0+tu51j8aFNgDebGPmdykicpwGL847YkfrwR47IYg5dMMas34pwh/53FbhtXXNoI9qPTBuAP6PkRzyxnYNejpBenHMYNCmMjuoMJijejZTcmyiEgrAAGA5dd1C64HGhMiBqvbkeMTTYlwjl785wjxO/UEa20NEPiydlj4sSv89Y/2Tq8RHbdCjP+qNfNBxHZj7gj54zpLySzDR3N7bbgNOYIm983p+QgdNCdn4CDZvkZ0B6EmS1iW1qlZTtn8fGFCuIvYVWC/1vDWG1MOoCbj4z0STDMCc3ldixvy27FdZRwHZUviKlKnxVZXbVr9H4t1UcHBnK2CQ2jLyuWh9i4srrkzuzxjHveMovfaZCCSTwMJJ42x51P2pheAPulqoVtqF/x8UzleT1c5A81QCjxE8+ICw0Dm16/cAPQP/nO+z2etgu9M174VSEvkJIkoztBx/h+uBKBTsHMLIj0gT+BPJUfdFsz/Qrho7Dm6uMBSi8T0hfF7p7d7wl6PBq4n2abDl58wyYILYwvcEgR/eDdE0gZNCcHsvyB3KBDA7YEpGICY578AdInWDA9jphR9YjhfNUVJiyBQn+M9X4BRuDUgbuM17syd3U+tfoWBXrhS85ysMnrbQByt9mV2I1SXHw27wK9AGO/6tFk4XXUJFw kE+5GPT0 RHmsc4guT1YVsD27X//2uLrynYX0JSA3ihrBHcPv6cmeH7FbcaqEOX0tLijhx7PIff2ptSitvLNWnLj0bTvGbBtVqaBAc7iu3W3caDAjsY2P2e0x7rCEIhN78hP3nZ8tbK7cM+IMhOHL452MSh89US3bUUigKgwEdtoEZi+rizGz2wNWRg18g3GOv7KxH+tiK4BGJUSUpirwzLwSD7T04B9tgXOy3LjtbnemGcfTgJP+31slhabeohC8rAZK/JbhKazE9KsTBZTvpok7YZ1qqBtTHkchxOg6DeD24uFcaPfP2D88H6eSwnSkxi8xFLlLelL3WR8Y4xRV4/Qwj3AuE8dNR93JuOYEwtPaFJw0HosgPJSay9BR4xqbatulHOznJXkacgEIiruxS1TBCjYTCrTjjd6+r0QupmZHTL4SD+5w7IG6rWZDAaX4v0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024 at 03:19:42PM +0100, Vincenzo Frascino wrote: > --- a/include/uapi/linux/random.h > +++ b/include/uapi/linux/random.h > @@ -44,30 +44,6 @@ struct rand_pool_info { > __u32 buf[]; > }; > > -/* > - * Flags for getrandom(2) > - * > - * GRND_NONBLOCK Don't block and return EAGAIN instead > - * GRND_RANDOM No effect > - * GRND_INSECURE Return non-cryptographic random bytes > - */ > -#define GRND_NONBLOCK 0x0001 > -#define GRND_RANDOM 0x0002 > -#define GRND_INSECURE 0x0004 > - > -/** > - * struct vgetrandom_opaque_params - arguments for allocating memory for vgetrandom > - * > - * @size_per_opaque_state: Size of each state that is to be passed to vgetrandom(). > - * @mmap_prot: Value of the prot argument in mmap(2). > - * @mmap_flags: Value of the flags argument in mmap(2). > - * @reserved: Reserved for future use. > - */ > -struct vgetrandom_opaque_params { > - __u32 size_of_opaque_state; > - __u32 mmap_prot; > - __u32 mmap_flags; > - __u32 reserved[13]; > -}; > +#include > > #endif /* _UAPI_LINUX_RANDOM_H */ > diff --git a/include/uapi/vdso/random.h b/include/uapi/vdso/random.h > new file mode 100644 > index 000000000000..5c80995129c2 > --- /dev/null > +++ b/include/uapi/vdso/random.h > @@ -0,0 +1,38 @@ > + I really do not like this. This is UAPI, and it's linux/something.h style of UAPI. What does moving it to vdso/ accomplish except confusion for people looking where the code is and then polluting users' /usr/include with extra directories that aren't meaningful? A change like this makes me think the approach taken by this patchset might not be the right one.