From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A587ACF856D for ; Thu, 3 Oct 2024 08:22:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 413516B02EC; Thu, 3 Oct 2024 04:22:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C3B34401B5; Thu, 3 Oct 2024 04:22:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28BD56B02EE; Thu, 3 Oct 2024 04:22:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 005726B02EC for ; Thu, 3 Oct 2024 04:22:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 654FA1A11DF for ; Thu, 3 Oct 2024 08:22:25 +0000 (UTC) X-FDA: 82631599050.07.BFD17CE Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 689841A0012 for ; Thu, 3 Oct 2024 08:22:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=F57cFqPU; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727943614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7D08CirM7xuRp06J+f5mwNiOHAYV3NjLlNX5JV7kTAs=; b=sjBy92mAVpZduziZXJMDlBZK6g1/lfdhvkStxacQzvzyyuafnXC5EigbKS+09ZCaatI04z Tc1uipnpFgD4GkvBn7gk79gWySONkA1LkSmEpqHQMXBxpKgvYJIsZX0IpSKZo2/XSu0OgP M87V/1XysttrGe7gEugADax0ynD34gg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727943614; a=rsa-sha256; cv=none; b=bF686HU2bJJ3L68FkNF5vju9YAd898KxmAHZMi06rU1BoKPP2GqI8kfyK81QUnP6nkDDVt 926pnLDx2imTredM1opBADWG5H8O0hk2xA50yydWvmOT6XtjBpvylOxfzwP29LESrcXt3D BkAXmkldRfWn6a3J2UY5ZdPW5N+5Lzk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=F57cFqPU; spf=pass (imf19.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5c883459b19so702370a12.2 for ; Thu, 03 Oct 2024 01:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727943742; x=1728548542; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7D08CirM7xuRp06J+f5mwNiOHAYV3NjLlNX5JV7kTAs=; b=F57cFqPUOREfBwjhElD0WEzfnGYR2iouDLpOxgtJ10wzIPHg7J/JXXmZOfeljzO0mA gtDxlTACORU6eQLveqHeJsfa8YGZRbHKvMWgVy9oRjmUZhxEQyFs5RSsEemoTJ7gXhEe UTi4Tfcmh55aE2B0GIySWcTCYmnrwnt6sIP+wm8ht3Z/DTkLiOGZEeXfTUfoBFAbhU+z wOm/BOJqLH/w/OZst0qemIRMM4msLN5Ve5n4Ee65VNLycMD2yxUpJc/9zvWtEK1fCZJd OoZf0fWtGylqIycCwDM9iRq9tPLgxWpCFq5/OfayaBbtX/mVPHnDMbKBsQ3mJnapdptd n0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727943742; x=1728548542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7D08CirM7xuRp06J+f5mwNiOHAYV3NjLlNX5JV7kTAs=; b=wbrvRPGszq/spU/+N0isiVVJcDCR3PYqLVri3FE9BkQVvG+WShKTxoZJtfmO0nBw0o V8W/6Puoiyj23BOm0cYtI6lGvOwv2pKc4P3DzBWeJD3TauRAruiJfk6iAFixp4b8hZWJ LsAmqNjIvTDEOq9E0MRAZuOomeKwVtYU6JpzIqxwxYUSXEUUAU0Sf8G9s/zinq3HbI+b R5r06XWebRpCHgZ8WOza9E8D7kvpnwwENhkSZ8gfKzbRH1KieOfy8LnQsyqXz1rRxPAZ 6jwXgw89+IjaWTPMPOSuxaDUB0i4LFIicih7WsZma3505PqT0vUrMcbIcrF2L8O4oC2F 1grQ== X-Forwarded-Encrypted: i=1; AJvYcCWP+fo6DOGUtt7vBXRCkOqlkN3hV7LI1YKFx+p1msJ+Rng0YziuosEwDxFacHHxm/4+rTlrkJhICg==@kvack.org X-Gm-Message-State: AOJu0Yx0imk2sRtrBRxtxOTd+mdZfXS6V0cSNIMuN4zDvu2mcTNCqDBO vOuCN4S2GKas4ZXUB0zPxmAlmfaelJGqrcIH2o8xOZtUuC8AG0UZsghjxzggEaQ= X-Google-Smtp-Source: AGHT+IGvbWw2hnN5NuJ3uDlUc9HhXu3sxWuJuPLHyeX6nGIqm/rg554fSuCmfpmRt5IdhcnSwSKgtg== X-Received: by 2002:a17:907:31c2:b0:a8d:2ec3:94f4 with SMTP id a640c23a62f3a-a98f8387140mr421655966b.54.1727943741884; Thu, 03 Oct 2024 01:22:21 -0700 (PDT) Received: from localhost (109-81-85-183.rct.o2.cz. [109.81.85.183]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9910286b9dsm50995966b.42.2024.10.03.01.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 01:22:21 -0700 (PDT) Date: Thu, 3 Oct 2024 10:22:20 +0200 From: Michal Hocko To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, "Vlastimil Babka (SUSE)" Subject: Re: [PATCH] btrfs: root memcgroup for metadata filemap_add_folio() Message-ID: References: <5d3f4dca-f7f3-4228-8645-ad92c7a1e5ac@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: acrk8ywxtgmt9bo9pnwwdg6gz4jbbs8o X-Rspamd-Queue-Id: 689841A0012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727943743-891488 X-HE-Meta: U2FsdGVkX1+UjzeTtTW1NFXiHsPucTOyO7WJHzbHEXR+G9tye86XBOuQGlWfr1iV4rvMghmcQD4c4FJPeWp35fM0U/YiBJEVrdrP2gxBeD7p2yv4LDNarH95cV3582G2u7nIDqucNqKo8BupYR/xOmdlftwvRYZzCHgS4RojzFYnRTOg6itX/xxPnOK+Cxdt7MgtD1yNahsyaVcebF8oHuiRZkGHrsOEEgEtjST7e+CVKHu8HpAKFooiIfC3AyOVU4E6yOumOPBf5VBXlvPJxVECbhxHIPiU8yD0Q6ZCJac/SbNrT/0JFW82HFHvtQ3XX+lq1n3tmQc5DaegfiD4QfhI3/IJ2tLp+ihTFXSFDrb4psWy9zb+FqdUvQCBtwKhhA7GLg3b9MRDhHgVDhxiPz0pSmBXJR0MgjlsV7klQw8PTVNTWfPES0ubV1nUAtXDzYvGQ2NSSXE6T0yEItJL+LPbA5PlYBgn7LtCaOvpTzAcMHhybOHC0PcBCHIr+GCYmBVuFiwQGJZVdkoFbkJaoiM83IyWOhp6mAoxUVqXg+LKE7WNBZWWpzQUVRAfJhR0RrUwCfsGAEJF+OR9JyydBlDfGrFegd+SG7AIisgYU4TsvEJRwOzzAWMPnbCkZZMaK2RLV3yUOQbPDjYNwFcds289sTJSkVPGSK5Ujd8k5vCDsStDnh4mWbeQ+aEDwGNOnVP2kXuhVk4COQfCRfnL0JmfOo1EDYgO1EHXHpOEQzLWIGO3GS9kCYK8lwo9CwZD1Xw8LP0pKgOoMvqki3ZPaUMfVVDer5iCtpPvk/0U0tsc7CURaNRRvwM+qpcfwD6u7vPPQTlwgLeFT667xnZoXniAS33L2922cpDY5izxAR6B4LOYyzZvRMm4PB69kTPvyBWuanWt21Q0xaqOOFnqAkqyGPLs6QMfJasGaRtJTyB4aTtxoX7K6+vIDjHJPcKzHqtzReli1IbbiBH/Da1 h/GFnaR1 D3wb8+x3kWyNAKNDKnWZ4/ApsZKSz/2Ac27cRDQvEW3Pcpc8xAkWLHGQ2B9sNANTExPh2xRdhn+HhUA6iCWZ4gUFT7Z2l3RXeqt+714QFvH5vQ63v9ChgId5bdbSYJ23QMCKmJnOWOz2c2cHmQVj2PnJWLv59NPDWPH5Qc0xHa+VQFEo1JbFMg78AnSbtX885zOLY7TL4fbV5PouXnH1xuQIM92D3WlOe/w0G5RD9Yrb0eTG2tEAC4D/ZcT1oGGW1SS84v5jWGxxFgsejTGbjeNW5io+fZNEsW9G47XZvo2j4rCfY7YcdoJk1BcTipdiXUeOg3jVcBiXhOdJEgBSaj+WBUBNwQ+HILTeMVTsOL5eM5cw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.037467, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 03-10-24 17:41:23, Qu Wenruo wrote: [...] > Just a little curious, would it be better to introduce a flag for > address_space to indicate whether the folio needs to be charged or not? I would say that an explicit interface seems better because it is easier to find (grep) and reason about. If you make this address space property then it is really hard to find all the callers. -- Michal Hocko SUSE Labs