From: Michal Hocko <mhocko@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, hannes@cmpxchg.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, akpm@linux-foundation.org,
cgroups@vger.kernel.org, linux-mm@kvack.org,
"Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Subject: Re: [PATCH] btrfs: root memcgroup for metadata filemap_add_folio()
Date: Thu, 3 Oct 2024 10:22:20 +0200 [thread overview]
Message-ID: <Zv5UPLRBDAA17AA4@tiehlicka> (raw)
In-Reply-To: <b43527db-e763-4e95-8b0c-591afc0e059c@gmx.com>
On Thu 03-10-24 17:41:23, Qu Wenruo wrote:
[...]
> Just a little curious, would it be better to introduce a flag for
> address_space to indicate whether the folio needs to be charged or not?
I would say that an explicit interface seems better because it is easier
to find (grep) and reason about. If you make this address space property
then it is really hard to find all the callers.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-10-03 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 4:45 Qu Wenruo
2024-09-30 17:23 ` Shakeel Butt
2024-09-30 22:00 ` Qu Wenruo
2024-10-01 1:37 ` Shakeel Butt
2024-10-01 2:03 ` Qu Wenruo
2024-10-01 9:19 ` Christoph Hellwig
2024-10-01 9:40 ` Qu Wenruo
2024-10-02 7:41 ` Christoph Hellwig
2024-10-03 8:07 ` Michal Hocko
2024-10-03 20:39 ` Shakeel Butt
2024-10-03 8:11 ` Qu Wenruo
2024-10-03 8:22 ` Michal Hocko [this message]
2024-10-03 8:23 ` Qu Wenruo
2024-10-03 20:58 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv5UPLRBDAA17AA4@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=quwenruo.btrfs@gmx.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vbabka@kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox