From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411EACF6D38 for ; Wed, 2 Oct 2024 15:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF7696B01AB; Wed, 2 Oct 2024 11:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA7356B029F; Wed, 2 Oct 2024 11:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A70816B01AB; Wed, 2 Oct 2024 11:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D7016B0187 for ; Wed, 2 Oct 2024 11:20:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C9B6F1C66DC for ; Wed, 2 Oct 2024 15:20:17 +0000 (UTC) X-FDA: 82629023274.12.D0568B1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 1A15D1C0017 for ; Wed, 2 Oct 2024 15:20:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T1HUVrPP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727882274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Ends8uxi0R2W/csqJ1KQwrDHil3Za5Loyb7Jf1euTE=; b=EnDOOcBg2NRV1akULu6MN/fZYKEw2Ffkh081VOXUuEttzWPoao5EWG8uioCdyO/855AHCu S30KnBKoI1qeQEQ03N0HZuT9lOEtx3ejR8gLYIqtAvzysGOUYeXfK7M0LVv/Noybgh0O2X ElD7DpV3GsKm5cgo5Yt496IqwqyI6j8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727882274; a=rsa-sha256; cv=none; b=qnwfi3NydkpghFAcM1jShERREPcO4JwHEIStx6mwIIl4dDE+QWtx0/s4J0LFKlFgWZ/7EY qjv+RmJNPpw6dtH/D8swF4Kd5WvhsDscob3CuxUqTqo7HsNqCaQwXEHif+V29uqEydv0yD CGAjQyFEYMnKAc7tEP27QULcRYahlfA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T1HUVrPP; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D56ED5C070F; Wed, 2 Oct 2024 15:20:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE1C6C4CECD; Wed, 2 Oct 2024 15:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727882414; bh=dyBqlInnswGOHm0meUkvVLFHAotMWeY/uR1TxBb6IoY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T1HUVrPPSjClNuYbPG1ypLB0rwaYBL1XllUPD5r/UvgLZV01+gHZjG9E08NelR0Lb NVl00V7pEBg0K9zPJJaf7qOlZk/WMN6ev4IQHXRuF8TRbiQZpIockal/xaNGSAGUgh BDCd6ee37/38/K0s785FqHq/FCO8kUhTNxe8rOPGU9SLv3LREPbisxvONgb4MN3VS4 vWo+X6U978iegyI1GztsmMTJc3cPcleTsEFDDaSQndFp4aG9a/CWkkwJDy4Iv4XFqA c5ucy9EMhCjto2pybh/ZWM7IKareS8bL3pIbisipZghDzc3hitBKqi5/lyhTIDmvU5 KECFYvf3XW+Ag== Date: Wed, 2 Oct 2024 17:20:06 +0200 From: Danilo Krummrich To: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v8 16/29] rust: alloc: implement kernel `Vec` type Message-ID: References: <20241001150008.183102-1-dakr@kernel.org> <20241001150008.183102-17-dakr@kernel.org> <977af809-71f5-4a5a-8006-a283f8a6fc25@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <977af809-71f5-4a5a-8006-a283f8a6fc25@proton.me> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1A15D1C0017 X-Stat-Signature: oe1fhiuwa3o736uusjugdmmoatxhsj7u X-Rspam-User: X-HE-Tag: 1727882415-140199 X-HE-Meta: U2FsdGVkX18FuFHV6wBodoDYMqVFbErC6WF00fr4lXS6Z+GdjpYe7W9RqGde4MlPWFjyQLnvCydlGvcpQ5qyChy073SCIDHfIloxyhAb8OUfNLs4OOwKqIjMTAOPKLucuZJavPeQVinYxXpeZD7e0QSO1PBiD0+a5u8TGEMTWMH27FzB8j7DLcVfEKsPJIVyhfZ8j5uOvq/AgGrbq/doqMZDm1NpIpAPdcihLHoPEyaupV+wl+MDPXWTtM6jGUkopFzRGZW2NWoXzGjCd5mrkgU80OyrqKzVFzTsTBAGVzzmvboSc8isGvwG1JZ+Unic8+SYXUrGnTjpR1jZ+vTkCd+fG33jtB3S1lCYVtHwuUyWTrvnZJz6JN+tmPUn26KtyohyivQ6ulZB+dn9xWiWTvUfRBovIGZsfDcyiBW/zd5VKJJYowLEtqUiSy2RwnJD9tIiGHouS02F+s2AXwqTHvI1r+QPx7yXh3hLiPoI6rzmXlxJht0qJ5Aa41IXXqZMpwmSLbc51i+d2XOBM52jLvEv8ohlV/j0h1pHScW2vVjgAlPJQPaR64QucgigMjQkwMCTEu50pgms4mtwiC1wGokgltnrx6Jd1qzhH770QSLC0z/x6OaE7pbsGImDMf1G25L0k82OVHTZ5fNiUDtVOgsYqBInhMbBxK7WwRnOLnfufs+pjO2XJQEtqS0wvkM05JdyIYuSEaNYQijh+/56JCmDfwZC2F0hZ/ybL0/TNO8IuObl9dBauVN9q5O5C9wIF1lROPhTeUa2U/Wyl2QbOXD9LJcHP6PSp0ga7q40LeDZ3FkpF+1W8xGa5MkQTQliKTfU1vEgEp2SPqJfErLi7/7l2p5c/23Bf+Ewdvne8VOZO2183lXhKQzB3Whj4vZAvxquSKVJNHsRLtbLERRTILzKd6HZc8CdbthG/y/+Nak2iSLvGN/vWtdSL8taUP+gAcI2d8ueiuG9JvPzNVv Hgs9Hb5y LqweQDb+hAXKOM19vcMqzgwlutuaQcJuchG5JbHI7a4cgcWEqe8vfXrpFvkzW02YyRheB2gWXFIAObrnjNOEQBYvhTj5CqNVhVj6jHbzfEWam7NPVAreKgl0pZIC7rtwHXzNNSYK9dgcXRkVnSo7sYaTDzsA0cy5JQnU9N65NZRSv6/SrPv7S2Q2YKNYHnNTUaTm5+De6Dbau+q5CljCvXjhf1piJEvpmhBYFYC57kbfQVqPO8lFewFQxrJafn1PrO6dZwOMF7uqFHnOjvwCaW1qmSWDwN2EqzB4XoCiy3q9XO8CjgHFg/UG0wo3uRGFG1a15cGq5PUc9fQ3hgmDeCITAUGo8EG0q5yW9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 02, 2024 at 03:02:18PM +0000, Benno Lossin wrote: > On 01.10.24 16:59, Danilo Krummrich wrote: > > `Vec` provides a contiguous growable array type with contents allocated > > with the kernel's allocators (e.g. `Kmalloc`, `Vmalloc` or `KVmalloc`). > > > > In contrast to Rust's stdlib `Vec` type, the kernel `Vec` type considers > > the kernel's GFP flags for all appropriate functions, always reports > > allocation failures through `Result<_, AllocError>` and remains > > independent from unstable features. > > > > Signed-off-by: Danilo Krummrich > > --- > > rust/kernel/alloc.rs | 6 + > > rust/kernel/alloc/kvec.rs | 637 ++++++++++++++++++++++++++++++++++++++ > > Any reason against naming this `vec.rs`? I think I didn't rename kvec.rs and kbox.rs because we'd need to escape "box" in various places, e.g. in rust/kernel/alloc.rs: ``` pub mod r#box; pub use self::r#box::Box; pub use self::r#box::KBox; pub use self::r#box::VBox; pub use self::r#box::KVBox; ``` And it's a kernel specific implementation, so kbox.rs and kvec.rs still makes sense. :) > > > rust/kernel/prelude.rs | 2 +- > > 3 files changed, 644 insertions(+), 1 deletion(-) > > create mode 100644 rust/kernel/alloc/kvec.rs > > I share Gary's opinion, let's do future improvements via > good-first-issues/patches in the current cycle. But get this version > merged now. > > Reviewed-by: Benno Lossin > > --- > Cheers, > Benno >