From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6499C3ABDB for ; Tue, 17 Sep 2024 06:05:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A05B6B0093; Tue, 17 Sep 2024 02:05:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 750736B0092; Tue, 17 Sep 2024 02:05:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6230C6B0093; Tue, 17 Sep 2024 02:05:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40FF06B008A for ; Tue, 17 Sep 2024 02:05:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F28E4140151 for ; Tue, 17 Sep 2024 06:05:13 +0000 (UTC) X-FDA: 82573192506.22.93F199A Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf30.hostedemail.com (Postfix) with ESMTP id E2D3580011 for ; Tue, 17 Sep 2024 06:05:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=gcxS18Yr; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726553080; a=rsa-sha256; cv=none; b=QINQAzPTRrm9V6VoPXhAvs2h+Atb46PlCOxTdn5/IjKhKeBU54tWmULOiacNrv2inFSZ89 FngeT5kNVO5sGo/nOjfpcNFBuEH+VW7lPwzZcPWraRbNJOkfPrQ6f3RNb8TmQZf3XIJFCP 1pDhreTAq3YA3iJPekC7QTOxbIkwQsE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=gcxS18Yr; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726553080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IAqEXr9dsx/GFARHKZ+CSfu6ynKeAlvuTAEqE2pmJ5s=; b=fOLpi0Ivwk8qzp2vBKRkptD6FH4/+BlRLS6J4YJ74fJOgOvDyP93+kAiK3K0lF8vSr1nvJ NkywMXx7R6OTnPjO9dMPnBVI+pSZIUQbg96nOk9ulo3Ih4BWZNpPsGTth+Cw4xDYR5xBzB 9Yvly6UsoH7G7yq1ItZdgqaWLeNGnYE= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42cae102702so32956885e9.0 for ; Mon, 16 Sep 2024 23:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1726553110; x=1727157910; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IAqEXr9dsx/GFARHKZ+CSfu6ynKeAlvuTAEqE2pmJ5s=; b=gcxS18YrtbWiB8DFZC0JRj2BJ+I1qlyR3CyR3qQgIOoHEU63zpLFSv8o5hz/qWIXu6 5N9V/JGo4pFbKiTiXaqf42osVP/XZqwd40WFshWqYrLNVnEzL2o3kTk0jTzZZkXKMUUb imFCqUSJ7B6vhCHt+WqVMaZn2MzLaS8teFJ/82RfbxV4kV3/+j1+P8ZuJH2hkZLck+bI bKleGVvrLxv4FZ31n5gG4GwK6ZTKs/F87wx9kWP3QkEgK/Z3zCKI+GjaOoUmyAmuDY+0 ZBvtgOjAWW9Euulpe9Ma/lrifsN8dP1PmK9SqLt4SBa8MLtm+TGcD05lHKjJCC9E0xc5 GoBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726553110; x=1727157910; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IAqEXr9dsx/GFARHKZ+CSfu6ynKeAlvuTAEqE2pmJ5s=; b=cXGpcyCT7ssDKQcJ1U6qs75b9pEQh+WMVChX6XnTfjJZQ051cdEVMO/c8XUqwiRbeY rKCBi8IqfsFASvqR01GYEtXCN8S88LOy6oDn2ts0lBVjdGrKN8iwaoVQo5/aUULxo7HC zCUoLEM3HVRuvmP1wEeiFsp8/wZqx3F7OKOLM6foLbcfgnriYV+X/+gs+gZMv6pMj+nU m1pvRGdsOLEynMS5HuRxb0YXm7GeDflZKjil+fGsAeHn4UgWR9aMg6qsQp6vEf6prKen RrseGSk8MeF3MS0oRg65WpVXh37JT7Vwi2R6wixKTFRuXj9WTY2W0pu5i6fpn5oTr9UM RB+g== X-Forwarded-Encrypted: i=1; AJvYcCXDKpxm3USnr/iG959m/kcSBwUFvYxevo/QNyONhlC/nzzxdGobBb9mPH0RS5GdUXSh8/WF4IHnzQ==@kvack.org X-Gm-Message-State: AOJu0Yyi87eFCutgLpdz4pGnwJz8soCBP8aAtOOV5754xEe2xokFie3+ cGdc4AkP1grf0H6kuD1ZZ8TBTOIqLWYQzGk1yp4drhQ/Z5T8cj4G0ew5cUXvWfo= X-Google-Smtp-Source: AGHT+IHWktBmb6JyxkK3Y8xMasoWNsJW/k8Kak+KevSump0oJf2owVsn0eMLrPm7k+dYafLzUSmICw== X-Received: by 2002:a05:600c:35ca:b0:425:5ec3:570b with SMTP id 5b1f17b1804b1-42d964e186amr78086315e9.35.1726553110371; Mon, 16 Sep 2024 23:05:10 -0700 (PDT) Received: from localhost (109-81-84-13.rct.o2.cz. [109.81.84.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378e71f0699sm8622412f8f.15.2024.09.16.23.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 23:05:10 -0700 (PDT) Date: Tue, 17 Sep 2024 08:05:09 +0200 From: Michal Hocko To: Frederic Weisbecker Cc: LKML , Vlastimil Babka , linux-mm@kvack.org, Andrew Morton , Peter Zijlstra , Thomas Gleixner Subject: Re: [PATCH 14/19] mm: Create/affine kswapd to its preferred node Message-ID: References: <20240916224925.20540-1-frederic@kernel.org> <20240916224925.20540-15-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240916224925.20540-15-frederic@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: E2D3580011 X-Rspamd-Server: rspam01 X-Stat-Signature: f1mfuducygf8xahowxy9ekkufi697bqi X-HE-Tag: 1726553111-343119 X-HE-Meta: U2FsdGVkX198PDFiEjN1UH7e6WCpZDafJ4N5hE1uz7XAfwhjCqBz22gWGeAmskXs4n0vyS62DaBaf/ZttqLPHtSa8WB0Gcfd03t7zoLilkRdvJ03p13ioyXk3QCNzMNDuiTpH8ghnSnK0tL5GdGTTIAHRpRccaXtcb1WP4TQuOhLozlCe59GP1+dUjIed3YYton4GlqyhNWaGWk9Dv3SU5Wvs9ywjl+eOf8+fh82q5QvkMzTVo1gOMzgXSZtlyD9aC8YVzUqUyQN5hjDiZlFH/kU+hUVtpj/7N3yHcf8tGmIZyH632kh84vhg/su8VtdEALhtHO0oRqDRsinix+y4y399ekPPMvt0wnBbtG3Lrl4RT7T2EBniwDgXSYoUCg4tDzFD6TFu8guzCSo2F5VRMUhMrtrJ6HqqAWW4HKD6usjgS1OXAiif1Zll9rGmCkGQQbhcUw3QkAm3zxj6u/2N1G8lECzapiiiUbbB1n9AlZHixFWZOuqEuwa1ih8VpwdiuKJh1pCvMdcwEecdN5SN3kH2oEonReZfef8uIu90XL4MWixjTmZUmJoDqsAgVyouEQrQ0SwW0S9ZtObhtfLy6VflzQ8eB7+jhTYV+gcPOS8ZOmR3UlEWWWxZ9WwPPr5uzwGowq7McSbfriZn3cg8l35c9U2leFbQs7e2Sa8OaEL6f+tytoORQELE3qHUaZ7pQSVunFP769mT4vVSoSVE9Jbv43IB/0UMjmVz1P/Pi3j38j/mz6tz/l71XL0mEHV5n6y3cDTHM5cNjFGTLL1Y7VmwDs0M/Y+v2kq963BlvkxZvFyUZIQvtt/3hgd0fue8BDUtc9sPTS8n5mQmYhPEAGb1KkAwU+1gXFy7Pti3QI8AGpm8xpSQ5QIybvpUVHYF8TIkfnWOW/4tDem4+4zaIxkLuF0wWs1mrrFUR2C6CyrRfnYdHHgJuw368sM9JJ8+rTPuREpDRUbxfIZI3h jMrjB4ZQ AcrORckWFwwRY+x6mmGouhIjAvHh5lElFlplil/3G8CVVY8OZhWdPQ1qjNz4vG2PHH3JmMv6Iupxk9ywgSYXsgCWbbeonhViy5C0fEshCSBekJKQtsq0nh5l40Q01sYEfjQZW762yaxmA69rLZH2Iq/aPsXOx7CiAfvwbe67VR5F8K9RVeXPHdhgZ/hV+O/1oxDmtk5TmYSnsDldOPbgaBltlFOn9Ad2wsf+kv5KyXuTr5xzvhuCCwMY1sbwVswVaW199vqdBHLjzcrZZyWK3QXVsEa8ws/72npyCAagmeXrbbgkb4drq7s5vlbKkFSTo6aHG3OrMFMtg5SsYu/KuqrDmjRuBr+/ICkYHZEU3XRD/hucvylU3H66OIjStBo+hcTuOmW7B2sUKSyDjQC1AIg+cOj+snHTl8uyV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 17-09-24 00:49:18, Frederic Weisbecker wrote: > kswapd is dedicated to a specific node. As such it wants to be > preferrably affine to it, memory and CPUs-wise. > > Use the proper kthread API to achieve that. As a bonus it takes care of > CPU-hotplug events and CPU-isolation on its behalf. > > Acked-by: Vlastimil Babka > Signed-off-by: Frederic Weisbecker Acked-by: Michal Hocko > --- > mm/vmscan.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd489c1af228..00a7f1e92447 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -7139,10 +7139,6 @@ static int kswapd(void *p) > unsigned int highest_zoneidx = MAX_NR_ZONES - 1; > pg_data_t *pgdat = (pg_data_t *)p; > struct task_struct *tsk = current; > - const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id); > - > - if (!cpumask_empty(cpumask)) > - set_cpus_allowed_ptr(tsk, cpumask); > > /* > * Tell the memory management that we're a "memory allocator", > @@ -7311,13 +7307,15 @@ void __meminit kswapd_run(int nid) > > pgdat_kswapd_lock(pgdat); > if (!pgdat->kswapd) { > - pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid); > + pgdat->kswapd = kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d", nid); > if (IS_ERR(pgdat->kswapd)) { > /* failure at boot is fatal */ > pr_err("Failed to start kswapd on node %d，ret=%ld\n", > nid, PTR_ERR(pgdat->kswapd)); > BUG_ON(system_state < SYSTEM_RUNNING); > pgdat->kswapd = NULL; > + } else { > + wake_up_process(pgdat->kswapd); > } > } > pgdat_kswapd_unlock(pgdat); > -- > 2.46.0 -- Michal Hocko SUSE Labs