From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC82C3ABB2 for ; Mon, 16 Sep 2024 21:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E9B76B008C; Mon, 16 Sep 2024 17:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 899D16B0092; Mon, 16 Sep 2024 17:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761EA6B0093; Mon, 16 Sep 2024 17:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 58DC26B008C for ; Mon, 16 Sep 2024 17:42:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF5DEC019A for ; Mon, 16 Sep 2024 21:42:22 +0000 (UTC) X-FDA: 82571925324.22.D3A6EA6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id C385A4000A for ; Mon, 16 Sep 2024 21:42:19 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t8ZGdrsZ; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726522794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iWPVUjwXOy2FImjR05EIaFD8Hokx95ABL5Jg22WP/1Q=; b=f9W9KrTj8PrhUP028UCKfyKaI2ALerGbPVoyA20lDUuHk25pEc1sztrXMJB38w6BHxBhKl 0XrX4UtgM0y0UuzOdNL91CZiPFrQ5Q+orEeliD+JUFdRNg03qTi4GnP/OE4GXNG9eLVx98 2x9PY+3vxLHtjJB3TqQGK3e3nLyGNs0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t8ZGdrsZ; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726522794; a=rsa-sha256; cv=none; b=ozRpFhbmn3dyYWrnJsdKBwu6HFak8WeRy14X8M9OX/8N0LiZ/Nz9jW2XZ8hw4I6TuLCOjj +n9heJNuLADDg9yBTiMoud7vRjvIISy//kz4LQDOsJBsKb+fRky0EbS4eCJ4314epEDGqS wyMtYwupqEoEDvqjFEplMJX8AdwyLyc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iWPVUjwXOy2FImjR05EIaFD8Hokx95ABL5Jg22WP/1Q=; b=t8ZGdrsZBw9vZG86m3yTJXqoB5 GMWr0Vsq3lqtfFAm6pg2j63vipBSLt6Me37OZFKXgmi7von2QYUx9PBIIbwEH41sjO45eCDJMydlX hBtfHd/FcjcqDayDt22dU9PnVarf0xmlpCMW+ZRFIBA11JM0Az5wtJ0nek7XtLQFoCKLcPpyeBCwH OapTa9xyVPd1VjVPcMRKGvBPKF9ymip8wv3FuGwdfRRJ0Q3yxpYRY2sjm6lMIYxCfpPRLNsCUzuTa UaTjoryYB492d0saSphaC+pw9dDu9Pqp6Qc0JTthS8gEtGytCPs7eucTjwosI4h2AyLFAoV4qn5/f 0W3Wc8/w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sqJTy-00000002PR1-25HR; Mon, 16 Sep 2024 21:42:06 +0000 Date: Mon, 16 Sep 2024 22:42:06 +0100 From: Matthew Wilcox To: Shivank Garg Cc: pbonzini@redhat.com, corbet@lwn.net, akpm@linux-foundation.org, acme@redhat.com, namhyung@kernel.org, mpe@ellerman.id.au, isaku.yamahata@intel.com, joel@jms.id.au, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, shivansh.dhiman@amd.com, bharata@amd.com, nikunj@amd.com Subject: Re: [PATCH RFC 2/3] mm: Add mempolicy support to the filemap layer Message-ID: References: <20240916165743.201087-1-shivankg@amd.com> <20240916165743.201087-3-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916165743.201087-3-shivankg@amd.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C385A4000A X-Stat-Signature: o9s5eze3pgpneb9rzkif9ftafi1u7uw3 X-Rspam-User: X-HE-Tag: 1726522939-603935 X-HE-Meta: U2FsdGVkX18z+DtKbK3gNY3yVRSxpIgdFd5UQLbmrtgq0AMD6lnhM1KKtyuMIFgtCe9KAIpTN64koA3JbCAdu1sZ/euo1ME/mfftkZFZX8VEheVOHACIf0SEPs1dN7OLOxC+MlsSQLQ+o+Yj3hti1dabyHzrG4JE6s1JCBZ7P9ib1z1U4jZVeSV03/aq9CXV7iMU5Q0ZUmGcDZ/VCONji+ILl/jlOyY86fIEVpsltOVUOB32pMq6vBKP9NAXMHNAYFo1DHgFdQYec7dOLaoND0wp1awmTOUxri6YLEtoL/frz+Wh71ikJ8MoQpQ6HN98Nt/IRmXxyDuF7SKBOUeoG3LwEq1U4AfhaQFc5jjAHEs5GIkeghtOMuWYlXfSG4ydxEqiKm6cIYNc8sajyveNGHtAXmOqQqxkuuq/FhkKmmfbM0uud5wE5bfexaHgbnocQ9h+6NIS2aPmJmuHNgB3vXXtlODLj388If3sIn/qF7D8AjCoTNthD19ZMwayBm4+N8s6E0d4PIIgCUzthGav0UbtHYHe+ZUdzf5W9aKl/ykrerFcgj0EX65YjO4p0R/g2DnaXiCi9Uug/4G7hUP0PK+1Mmfkr/xlj0BQZFpy/Jz1I/VpTCrJ1i1PFQX4WQqJqkvjgUu1vGZgrxITvYkmqODWS68TXeHzJDLSBO8uT2vN/3Ym/CIOjB6o3mn1IkjLwa9d2Vyblq8szKwI8VSUptYthoMTRwmm/0NavfteElAJoNUDEuDfG0Lgv8ZSQAhtOKx+Z7agIAjql9c4lKfqZAp0V/MQ6bA7JYBLLy4gQG3mZGZg7w4GGmnLFAVEdVWeoKkw2MmR9pJiW+R7QPekXHsWDuk9eyBOy/ng2UZmbG3cs8y/7thisy2mumdwfivJIKySVjD+YsbDz7zmoj2tBMKqqHAPIdj79df4AtCB9Tj8PaAboLv9CcVFKh1nDyUT4bqJJ96Lw89W3Dk7DOY DCjpAalF 9jlhckqBFQiQG5QoyT8xDlU35ZmOZmptJVoL5aJAaiX8mg0AmVO54Bz1iS1Fa9XPYKx6MRS/VQoXgsPb+F/9JMxlkT7adKuKL8xSbcC3THc+ay1kE5PyXqzqN5oEVJEvb5hHJEEPHttdFEYxSx33/dPlmgAldOk8lSHbwPUvChQ8oV18O3vr09YwN8bCN2DYRK1hekQyxdupLX0AEn4VGcl2NAerfgowOUwJYFKFUMXyuK+U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 16, 2024 at 04:57:42PM +0000, Shivank Garg wrote: > @@ -652,6 +660,8 @@ static inline fgf_t fgf_set_order(size_t size) > void *filemap_get_entry(struct address_space *mapping, pgoff_t index); > struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > fgf_t fgp_flags, gfp_t gfp); > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, > + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, struct mempolicy *mpol); > struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, > fgf_t fgp_flags, gfp_t gfp); > > @@ -710,6 +720,26 @@ static inline struct folio *filemap_grab_folio(struct address_space *mapping, > mapping_gfp_mask(mapping)); > } > > +/** > + * filemap_grab_folio_mpol - grab a folio from the page cache > + * @mapping: The address space to search > + * @index: The page index > + * @mpol: The mempolicy to apply > + * > + * Same as filemap_grab_folio(), except that it allocates the folio using > + * given memory policy. > + * > + * Return: A found or created folio. ERR_PTR(-ENOMEM) if no folio is found > + * and failed to create a folio. > + */ > +static inline struct folio *filemap_grab_folio_mpol(struct address_space *mapping, > + pgoff_t index, struct mempolicy *mpol) > +{ > + return __filemap_get_folio_mpol(mapping, index, > + FGP_LOCK | FGP_ACCESSED | FGP_CREAT, > + mapping_gfp_mask(mapping), mpol); > +} This should be conditional on CONFIG_NUMA, just like filemap_alloc_folio_mpol_noprof() above. > @@ -1947,7 +1959,7 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > err = -ENOMEM; > if (order > 0) > alloc_gfp |= __GFP_NORETRY | __GFP_NOWARN; > - folio = filemap_alloc_folio(alloc_gfp, order); > + folio = filemap_alloc_folio_mpol_noprof(alloc_gfp, order, mpol); Why use the _noprof variant here? > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 9e9450433fcc..88da732cf2be 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2281,6 +2281,7 @@ struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, > return page_rmappable_folio(alloc_pages_mpol_noprof(gfp | __GFP_COMP, > order, pol, ilx, nid)); > } > +EXPORT_SYMBOL(folio_alloc_mpol_noprof); Why does this need to be exported? What module will use it?