From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38BCC35FE7 for ; Sun, 15 Sep 2024 13:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8516B007B; Sun, 15 Sep 2024 09:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E77716B0082; Sun, 15 Sep 2024 09:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3ECE6B0083; Sun, 15 Sep 2024 09:51:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B21806B007B for ; Sun, 15 Sep 2024 09:51:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A13CAB8B8 for ; Sun, 15 Sep 2024 13:51:50 +0000 (UTC) X-FDA: 82567110780.16.26AD76E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id A22DEC000B for ; Sun, 15 Sep 2024 13:51:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DRkIar9R; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726408164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PRdpsXqKOB66nzid05vkfMQY+h3dZqrBw/EG9fBVIP0=; b=4HDN+VGqmZZlVHuo0SRwLsCO0gAoVWR+zZSbk4T8dTjaLPtwUJDoICWvIgvJjZp3+dVfjb QhcMz8bOo84RDtBDfMKqVrml3tU+ryqYVnEliVgNCOnuyUxIHIMJjQbhnvtKrsr8E2BBRQ v/pCkBGn23T9wmH+UzAdscU8twxzXdM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DRkIar9R; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726408164; a=rsa-sha256; cv=none; b=Jy3+MhiwH0EO4Ti8Ob60FqXzx4vI85hHr33s4cv3EzwJh3BIWJw+IQStD1D+OOMR65Flm5 d6psI/g0OT9Rlav5u4Yvf1ELe8BcWHGGIQACBA/mNyQRd2giN1wb2bdHVgAukT/YSQ/fFr /U+iLNZLRFKb45IV5580j3vEHQK+FLA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 45A6A5C54F3; Sun, 15 Sep 2024 13:51:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 666C4C4CEC3; Sun, 15 Sep 2024 13:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726408306; bh=q7WJquAI08+CAD5lP6bdNehob9Dq1wPKxQPjeFRtiiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRkIar9RFkBNG39Lg4VF36+C0l1NwYSaEE09Z1SxGxc6M4S+jx9O3QiS3XE0iEOXa dugg4+gux8cHvhMy415EwhG2oqeI29OZXErerIPWPPLxGdjDxioHvmSB5SFgMR8cmZ GF890/YHKLL0YWKx3z2y3nIavnufDvUSXph8DwoVC1aciO37Nuj9Dl/4U3xgMBW1Vr QqbWqbJwbZ+B8JLq+POjgebhgVzaYSVrG+oX+aypioA+ScnFYEAUCNxQIIMCRKMIR8 1d75vfMvgyrvMLYGrv0O59GREHzSdXP1f5IYJf2XBPq1KtNNCfQ4hdGzn/h6TRc0iB 7g69hrbWPmj5g== Date: Sun, 15 Sep 2024 16:48:27 +0300 From: Mike Rapoport To: Ard Biesheuvel Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A22DEC000B X-Stat-Signature: 85w1jmgwpwuwb8sc5wfybiy7u6cqzbkt X-Rspam-User: X-HE-Tag: 1726408308-175054 X-HE-Meta: U2FsdGVkX18Cpl0gFr4qTfPN0YPIhnWFVVjBZ1wXkpjhUkzoxoYJ09RAvMHvJnY0tJXfLEtpktFlVZN9t3N+YGa26DED8mhdqCyGUs1MyoAkC+w21HEp/DJvlZWNjazBAAG6/lG6jjtHKP7AZiks/kILbsWzTgRPFQChBoz9kLAhso1DxpTRwSkucUEtuUzWjKjLQKModL6EYPNgRG2+eqKW1sSJEkH2zoHxqQnU/caguxMQaecZSizg+R5P0ELvEojGW1slSEVEb6KMchGWM+0xGkJJn8RE3ffFADNEaYqPR9h1o5vc3hiO4Rc5dwa3fMzAxxxiLpXMT9rOY3ts/TQb6Ml9nztAqvqO/trJS0EkFccL6pKELg0kH2O2Rh40pjahxkCOlJBNvnUmdkYvZHwnE3WWiW9s1chWrrFToL5/69chjq8zgS7wJ8fBoJLrdRRAuVUXAVszEg/vh5ZWZekRvniNEgtsL92fp7DIo2Hv+1ZOn3nWeuWS3QezIokAkT3ZRQj+Nvfpj+DTkO0tfXkk1gwN85bZbbx3ynkugKaU/EDte35DSs5S8JRRr5blXTy5oW6jntzLrAqtqgwzypFbmliTBHQHuzcXUXHnufxLrxwbkDZ+v5hk9/2QFfPUouauT0+mv6iu5I3tW+DaC2mst6Jl6UW6ifCSPQBYjsg/L4bLuKgTuyPbce6EczPHcGIw175FN6UZtz7VHD9Cb08IVaXc1OkdTIElaD8nxk3OSIJmTP+QQA1In5LudVaFHlAGykDU8SIPGBDmjy1pHlj7tJqMP3b/tAbOgcXAcfxoVjrUua/kv54acv+VUpkBf8pRzRieHc9SBfG5K9Yw0iksOl4titD8j/gDNJjxRTN4+b6V7SMuw96AhC6j5pzn7c+uQLGmEDHE79WrARFYfMPPlem8mLwMLg8PFkKNSe7EvL/DLJ+Jm19fJSKu4CysFUJFjktp81qM6ZoSdnl EF6HpwF5 Z/kZfHVs2YPvWHrZs5ZWvGnLk6DIpgcgfu1pwue8ZfIksNCd/fXD3BFMPOojn+5Ot9d7OPWqp9bmaFgqARaqBT/+42hyXlInz5EY4nWtZPspCXsi8oqOGovc7vwBQzn5etE+uatGalzP5yVz9IJU+pYgG8uFzXwRd0yvWbgtW6Igdd8/i7DiIder71JRaK2ahjA3V5YVftqxlsv7qXci+wJfkkr2+IptBQ3KukZAuxnhQ5ymagCXZOi7eTUB1Gvf+cRr5ICv/hT/aRyAzydvdj8KTHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Ard, On Fri, Sep 13, 2024 at 05:00:42PM +0200, Ard Biesheuvel wrote: > Hi Mike, > > On Mon, 9 Sept 2024 at 08:51, Mike Rapoport wrote: ... > > +static void execmem_fill_trapping_insns(void *ptr, size_t size, bool writable) > > +{ > > + if (execmem_info->fill_trapping_insns) > > + execmem_info->fill_trapping_insns(ptr, size, writable); > > + else > > + memset(ptr, 0, size); > > Does this really have to be a function pointer with a runtime check? > > This could just be a __weak definition, with the arch providing an > override if the memset() is not appropriate. I prefer to keep this a method in execmem_info rather that have a __weak definition that architectures can override. This is not on the hot path, so I don't think a runtime check here would matter. Still, I can fill in a default with memset at init time. -- Sincerely yours, Mike.