From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311B5FA3750 for ; Fri, 13 Sep 2024 19:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE5546B00AF; Fri, 13 Sep 2024 15:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B95846B00BD; Fri, 13 Sep 2024 15:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5CB26B00BF; Fri, 13 Sep 2024 15:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 835E46B00AF for ; Fri, 13 Sep 2024 15:22:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 265221C5134 for ; Fri, 13 Sep 2024 19:22:37 +0000 (UTC) X-FDA: 82560686754.26.40E72A8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 0C92880003 for ; Fri, 13 Sep 2024 19:22:34 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=USrHQTI1; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726255301; a=rsa-sha256; cv=none; b=8j/ULkuolJv3hGfIjlq0ZSmDS9LaAQ8XddqwonIgsGJJijQjnYdOTVivWPi6pzdv1/DfLt CEZHVcxYqh1TgS++NXGIlkPO331bJ9rc98avT/DU+Sg4yXkBIYkgsgV6zv750qld7rxkbF Qk0+RFpxcTwqRifgdDUhN/rVpOjimNo= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=USrHQTI1; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726255301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Lj/20hT1fbEbqfuXUYTZnnoIn58aQxQZGwFa+ktq7nI=; b=WRTW2XtsKBTY7sqPQzhSjT+DlAr1CQjTVdTUP8mfX5wCE05xa2XZHIJIWdObf/6rGdrMa8 90HbzSrQKSfgVI260D4A9Wds4QxzlVUNU+sB6J7fc4e8kCr6MF54UvIpp3S6auDNqQ9sGm 9g0iETiiY/Wm+9m+7t6SikDA6jQwBA8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Lj/20hT1fbEbqfuXUYTZnnoIn58aQxQZGwFa+ktq7nI=; b=USrHQTI1gAhLcewwZyHVEmvH+2 TNfnavn0WmWrViQukWcWKUEDmPzjkL0xEn1n8BhzZwM9T+pwhTzsxu91hYIN57ewocp9cvGn/UA9h nDPIR2H17TcSfPO62NYQFrX+48iHo8fHvr6GrMEtD8iooOIvFUsMxuKi87bCzAB34fqozCVoNjSNC cpOr1cYF4oyo7BePpJi8MDiU+JbLFkyunDgG7G5HXPIm3h1euuqWGrhgPNe7+s9uz06ECd2yN2e2B aBqS8T/VdHWgpwDvegaDqeaa/dxE/40oEXpmQ0ir9IEHYYp5g05SJG4iHMwNc/A4JtR8h5YehcBCc O4d4pjaA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1spBsC-0000000GuqH-2j63; Fri, 13 Sep 2024 19:22:28 +0000 Date: Fri, 13 Sep 2024 20:22:28 +0100 From: Matthew Wilcox To: Mina Almasry Cc: netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Simon Horman , Stephen Rothwell , Jakub Kicinski , David Miller , Paolo Abeni , Linux Next Mailing List , Arnd Bergmann , "linuxppc-dev@lists.ozlabs.org" , LEROY Christophe Subject: Re: [PATCH net-next v1] mm: fix build on powerpc with GCC 14 Message-ID: References: <20240913192036.3289003-1-almasrymina@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240913192036.3289003-1-almasrymina@google.com> X-Stat-Signature: jedq81posibcde6aotj3qpgftad8ws7s X-Rspamd-Queue-Id: 0C92880003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726255354-486898 X-HE-Meta: U2FsdGVkX1/6WRHjrngV1nP7UZMpfblbkjjRgkxeRbJCKCk64aMoJd6Op9UMkimBi9RAqeNr6kHn26iq/h9Ss0Wm0QUS4TrygOWEX6qmtcmqrsMmLbUx8FP2s7kRf8VH/Qowl1xo9z+RuPo6heSXOnD69DkHYwk43tkKPEsU6XrPWuQmAMfxUCG1BY06XgbLrv5dyTS12pXhP6zGljr3aAMfUYiDbYQLn6BWAyfE78Zk9CPk2DSBIgvbxe3WQVZbMzTo3m9JgZbqksx0a/llrHCxCwbNzJxRWl80s0uxoaEAkYbNzZp2h0rTspfHGx3LbC4O9XGDZA28+S6BLC9YTyoDdWl71KSHX3x7/nDCIl0rSWl8AZKNiTyn+g5WaQH0jFil+w2EHXnqsPxV/vV3m2OU1+9VB31TgHlZLY8j9/4por4+jLkSK1tvMpwTgQV00qZlpHunHwzUN5fPCvrY+edLbdkcas7CAGmX4Ot894lViID8AjzagenizR3ZclxwXxI/7ZGFUpXjOlbAn52rlxe6unXfaB3yEKl49Pasvx3K8vBdQtqkQPPX0dR3WrCmbaSGK9LazQeu/R4civsWGM8FBXEM1Tzvy0n6LEreeWSteCZwdL8W+7Lt8n2m/QcgbUxVoIL/ppKdUJOzBmAHoUxBrxEjuzDAybKw2uWGR/QOoGS8cZoP72sVxOC+Y8d/eSUoNkaYLqfAhv+vTLLPGCI3glgFSxmiMWK8mJppNo/YqZYq1R9U4QdFD10yVvPM2DPTtc+nZK+NNzsG6SAOJDm2iW1P9gE7lvKmYkP50IklSM/IEHYvkdG7aK36pqZ34mrrmYEPlriMlQsBzrohvdomm/fFuWq1dbxpDrU209ahMIBXB8JV1/jWRMWXMI+++9dVqLpLWDj10eJ5Ecfrvwns+lWU1EXpXQiIG5XUArmeY8Ga8GtVEZhSPdHhLwXsZHywrZERbtNE9LdIezz Ax5aIdsh 6FR6fkpZmYLOYl21/2OgRPleeVKbY1Hsiz1eyaENQJG37miiFzinxFMKxq4J8dBJ8cVy2+YxGp4FAX3IqA9SAVSfxOPDUccUMx76FtrpefXUSKjeJW5vg1KzfoRZBwCo2xwHZDDPSZ6lnUOIzs5ZpO65T44qEEKzbyz6shnx3Q88QN1HLk4KKjMYawNUuEeAzGLligbqoR1PZRwvrQEfj5C4BjQ3KXtHAe+q4KS/ebhDnUtrT6wHWqOEcwrrGA9cg8eRlGmUVhsL1TNQFKFXlpks28w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 07:20:36PM +0000, Mina Almasry wrote: > +++ b/include/linux/page-flags.h > @@ -239,8 +239,8 @@ static inline unsigned long _compound_head(const struct page *page) > { > unsigned long head = READ_ONCE(page->compound_head); > > - if (unlikely(head & 1)) > - return head - 1; > + if (unlikely(head & 1UL)) > + return head & ~1UL; > return (unsigned long)page_fixed_fake_head(page); NAK, that pessimises compound_head().