From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70482FA3723 for ; Fri, 13 Sep 2024 07:45:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E19AF6B00A4; Fri, 13 Sep 2024 03:45:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7146B00C8; Fri, 13 Sep 2024 03:45:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8EEC6B00CB; Fri, 13 Sep 2024 03:45:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A702D6B00A4 for ; Fri, 13 Sep 2024 03:45:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2CB3B1619A8 for ; Fri, 13 Sep 2024 07:45:20 +0000 (UTC) X-FDA: 82558929600.25.C067F1B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id D822B14001C for ; Fri, 13 Sep 2024 07:45:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=24jJLMzh; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+948d10b9599a1a0312d5+7691+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+948d10b9599a1a0312d5+7691+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726213511; a=rsa-sha256; cv=none; b=Sb7nskPteHFRs0YxWqEHLQF+5ajagJ1nWIDBL+joPXLydzl7JaC0D2L1ZtEaMVLh7I64RD NVSv8dKiYcOV4n7QQH+rI2mFU5R61HQmQOY0arqWnhxRjA/KEWIn9u9HNa56pm51G0IoAG uhxMN5QCizNVr3es9ZYmenrhKPVYEsw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=24jJLMzh; dmarc=none; spf=none (imf23.hostedemail.com: domain of BATV+948d10b9599a1a0312d5+7691+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+948d10b9599a1a0312d5+7691+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726213511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oAL4XSiPCdCxsFRJpP40OPeCmZ3h+2yPthNLW4wasU8=; b=vqnlJl0n2woj56VI4V+UMy0mcVRd7r+lqUZHLD0sWcKFgFbk23DUeUNnFsOyTGZlZ495wm Rc3i4lr2O2R0h0gO+lCKdWrw4uz9S/QkigC93PDT82odG3Nkz/JDnkHFYmgZBBxBVqfFCP P8KbXKa4+GjZK1dyoMLwIZcDmkZrVfs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oAL4XSiPCdCxsFRJpP40OPeCmZ3h+2yPthNLW4wasU8=; b=24jJLMzhlw7fsF4lRmyyaKTDTx C6S+XfsZYT/9OiZCMj8PFnItGB1ZdWZtMRkqOkkDzJ87CeF59ewfAChpYpskYBGDDGOEMHHwdg9tX W23GLz2Ba604H3O9k1YeJl4nkog9PnISEKvDbuGdcI6+L/iyaLv8TDiqxbwS9pJAqGzd6MqFKD93N Krb27Y6ZMgEjUdDhQt6cbusxaFJjJjGT4WXzhkY+knKTNqvqyM/3cwvVvagwKhHy/DWSv89rUxowX jlKo5qk5Nyxahny3AF0eTdjQmd2HBpInxzHoYsmfURSuOYpCuA9LLpsUzqvF6gUZRbAB7H2w+FqXT bixtb8qg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp0zR-0000000FD7N-1nHB; Fri, 13 Sep 2024 07:45:13 +0000 Date: Fri, 13 Sep 2024 00:45:13 -0700 From: Christoph Hellwig To: Jens Axboe Cc: Pavel Begunkov , Christoph Hellwig , io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd Message-ID: References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 7gigw9ns76sdko8szi54w43isfqit33k X-Rspamd-Queue-Id: D822B14001C X-Rspamd-Server: rspam02 X-HE-Tag: 1726213516-527296 X-HE-Meta: U2FsdGVkX1/EE7p/sd93aQvp4IzFeKJYgRfxpB5+eP3ikxMXgPDqekpwLTR3x5xuj4melwO8TwJfu6izQfh1ozbgQuEI44Y5SlHhg4msvqbpuEBE49VdAIhysGDDbLSyR8l8Z2Qkns+oqj3Hym01dk8igS3GRV6YlBC2GLMenTozxGVIDUWHJbXbM9cFR500UkbabzgnfL974zdwp8cuF4/e7WrXWp6EFEBdexUpvw/9HGSDZS/TkGJz+jPaO8QbUtwpHXq8PcNk4edM6GLRXy2DC6zP2FaL9Di0dC71RmKaEpJv073ya+h66O0qn73GhUTeDl+se6nwwCDybOY9x9GHwtqUSteNYMtyHV5JBUd68TRrVTOwmTuF2dGQZAEAYjG4LvGpRPnlAiq+EBDKN5JAZKipH7rcXHrxcXe1YBgE5KNhiVD413cRYz2MbvjKpHJP8q38GDeZAENAv6QepJeMeTAdA57teci1/V/7XYs1IcYE2DsxVY9bAKV+oeGlSts5uYbZ67/ukZzzyyyv53ptkPO4KgZdCCtkIj8fZn7kYUI4DyXWSKytGRmeIAnpgu+9FU5whS8OnmVK2n+bDqZ7J96vTVkRMZ0XrkZaT/KBSLxXMySa8fz45tiglP8zIC1uUztqTilAJB6oeRqcKebVzYgrvZr1bhEWZavlGgK9ZKDNb7+EVivo7XIhyjc/X/Rx40Y8eCB7Zxs+gHldHRezbhvyHRD7NLuUr2jhqcAyz/rh7KVtBwjmY9YC25HhM0/k0ZOAmjP1IZ0y/t5ohzevNqaZtqICb5D2vmM4KizKxWeUNuJDk/MfE0oRWtczvsB6Iqciu05WpLJvVE0NWtMtYKEbJJptcLC8kaS41zhNxr3T+zmAq0b9aFx66ZiGYV4GqFgJ740goagglbNuZ/S26faeLC9R8aCAaIL9rdVGjPK9+iPWOetMftJ9PaRUS6WEWJ62Tj3J9nibEh+ 2xnavawj XLFply3Gq+n0ycYPFVQ/iBlbQRWwixpNy+zcC7wBVZw+fPDPzbVUh+X1OzWf7qoXIazwVLJp5ZB/QBqePuGFc3VOTn8JOg7t2ni2E1RmQ0X6YqUPaMTnhd1Jnhqs+EG0HJQLa8HZ6qSNloPBfFKgnTOplpzPt8TIGBGXre3Fc7yi1L7W1fuuoaKP5aWKjYJzta0NiCJBC05C81sAspcpMgJ3EiHXr9by4pf+xNiQfvOmDs6JAoAOXDZaxwouOLE/Y12qCaWbEmiJl0+vRWRIuA+COmyw6MzrTL8rPaJUrycrlRw07gB3qjiWKDlGzWR/K6vuvDbt8gk9+bOIgGCQ1vR45ey8y1A/Q56Zsqr367AZyRdROm7A5lOJFiSDWaoR8iOrdPsh+Jf3N2QqecxOpM7gz0qJPEGrJUEZubcKSp/NlzWFKUhy+Fk0uwKFW1FPkIl32pW1Ud6nT7hwlDrC6ByXnie1JZN34TcDF8skuDBJtpHBuHyaApegbV7avZz8YWbxkGVw48owkJucdrdtTWnLcCj6Ey5Q9dCJddwZxk8J+D7dHojXBuUrSZSHtxQ9yr8aS9yQrXy2tVAjljedUNKvY1kHimMj1er92 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 12, 2024 at 10:32:21AM -0600, Jens Axboe wrote: > How about we just drop 6-8 for now, and just focus on getting the actual > main discard operation in? That's (by far) the most important anyway, > and we can always add the write-zeroes bit later. Sounds fine to me.