From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00F20EEEC07 for ; Fri, 13 Sep 2024 03:22:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 652816B009C; Thu, 12 Sep 2024 23:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 602626B00CD; Thu, 12 Sep 2024 23:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A27E6B00D0; Thu, 12 Sep 2024 23:22:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25EBE6B009C for ; Thu, 12 Sep 2024 23:22:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A44094021B for ; Fri, 13 Sep 2024 03:22:23 +0000 (UTC) X-FDA: 82558266966.30.03BF664 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf20.hostedemail.com (Postfix) with ESMTP id CAE341C0002 for ; Fri, 13 Sep 2024 03:22:21 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=JKcjZCxd; spf=pass (imf20.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726197636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gkPkVDRD0OwFEuQUvV+n2s6XJ6GgG4bakHl8tALnG+0=; b=5OfCmp1N3XdQj6Yw7EHJq93YSK6BjRGICZtXyFmXtv576eFrgF0za2hvUJ6qKDSwLHOETh Ky5vfZkGjpl84TEQSIwXMhffFtgbBavOQnNUW/iyG61vWJkFYW/kXWDBMbZm9ClRyeQFHO 7tkgTqD7wYout+cuttKvZfKMBU6hGF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726197636; a=rsa-sha256; cv=none; b=2DHKcMQIMi4h5iNaXBq4JwJHkLvc7CnXEwLwlPKrRTnAIjDR9RiSjs7QF+BzyVcHAdgfGR Uyjcx68eOlN2oG7OIkh1fO5cDZ+bYyGJ8jqZJgGq3vlLLZ69LiTQF20XaXBTn1OsmWzaab OhHnI0svfNnF+qLC8R+Bjqk4wMAmkcg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=JKcjZCxd; spf=pass (imf20.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-718f4fd89e5so1519320b3a.0 for ; Thu, 12 Sep 2024 20:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1726197740; x=1726802540; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gkPkVDRD0OwFEuQUvV+n2s6XJ6GgG4bakHl8tALnG+0=; b=JKcjZCxdr12cPLe0rz+MFqeEIgoS8PA1JMoawXT1XPJCONutd94R9mwd3QtBzDCHt4 7D5o2uYXrTYzYMepTac4zf+q0X8bN1Tn5AmZgkKxB/nBqO5lUxA+i6WDd2ihzNJ7KJRk Yb6m7uGQ91R9G7rXb3GO9F2jVjdUA9f+Ve0/m8mL90pSf0WClJS7V4kKqD340aZIPcp4 dX8S6iJ4unqZm2LQJJCQ9jZE7hM/Iz6ibhVxhRpcCJyseA++LRDTks4Dg0zJtUbK/ltQ X0p7AyMF2N/DvwmmAN6bYT7L7ngf9S+ZxrsaqU6QoQnovQoZeVSUzM84Oip/9kLsRKji nlaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726197740; x=1726802540; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gkPkVDRD0OwFEuQUvV+n2s6XJ6GgG4bakHl8tALnG+0=; b=QgqdBVeo+GfOZw2ZgwQpaptKL3Rm2fgp+TpEp05DMHJjO42PRiipzbqAcATH5CXyrA V8zZC/A001MOl5+k87gQ4g2XKl0CDzLxahqCdtv6Yqvs51nVMnewaaE+XW+GxczvYJI+ jdQA4K2uembwggGiWU9R2z/0WYNMv07FDhE6jRSLC1qPHD74BgKQbELG6HNYIepc1JUZ MlXhpcRrN96JaIB07XwpSCVxtO9RFKEsnSkMKnmT2pOAJwmYh1XtpLO4F1EyHPS2YRvv n+OBbKWOxlf27OuUKzexTRdlmEikovq0NTVrcZRQ2RPSEORgcdTwX89hXgVNFPWlANGD nX8w== X-Forwarded-Encrypted: i=1; AJvYcCWvB/njAGy8SDCrRDj9TI2gdHrd9IMDyH7M0/+A0iZsSg8Gj3T+s2slkYOf3mufwuh5qLnhOZi6dA==@kvack.org X-Gm-Message-State: AOJu0YxWR+fwvQD/ewiFJgVin8dM/up/XDhjeEJQAE3Q+r4OZOfRsA7J qKYJbvsVZYWeK/gbYMNAi4wxU9uoKRICWxouSwOBau1E1qwyazDpIUo3PMsgBWo= X-Google-Smtp-Source: AGHT+IEXdu7/jKSiLZPseTbEtvh8wm3jfCToFcsHiweT3cn9stVw7aGwEh7jPsLs5sXKDmpHC50qCg== X-Received: by 2002:a05:6a21:9d91:b0:1c6:fbf3:a0ef with SMTP id adf61e73a8af0-1cf764c11e3mr7345712637.44.1726197740389; Thu, 12 Sep 2024 20:22:20 -0700 (PDT) Received: from ghost ([2600:1010:b329:66c7:b074:429:f745:d035]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-719090b273asm5263978b3a.166.2024.09.12.20.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 20:22:19 -0700 (PDT) Date: Thu, 12 Sep 2024 20:22:15 -0700 From: Charlie Jenkins To: Chunyan Zhang Cc: Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Chunyan Zhang Subject: Re: [PATCH 2/2] selftests/mm: skip virtual_address_range tests on riscv Message-ID: References: <20240913022635.751505-1-zhangchunyan@iscas.ac.cn> <20240913022635.751505-2-zhangchunyan@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240913022635.751505-2-zhangchunyan@iscas.ac.cn> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CAE341C0002 X-Stat-Signature: jwitfk3squ5puhhko53s4hd143omg9s4 X-HE-Tag: 1726197741-17294 X-HE-Meta: U2FsdGVkX1/s7OFgsCsJj81UvOnNDhA8KrfeNZMc51seyDpSnsGqePnblA5Xt0uD0WX0grqxPb9fp8JyVIeEsRsbOawfs0LpcrgSw8vJJakyrrJJ2ZIeNZEyQYNC6UWdrzp/LiRpOLRmSQ7WH8ik2fobWpEwlXGSQr/L8AxYP6t3fyQs37xUzO4vMSJq6kjyMozelVyL6pW+Oh491GGCSzYac9uKDGhE+azWEXzEaFEwYFjgFYYo/wpSbzMILmksQkqiF5uR3sfpwdhIkn685Buur55oRQweoBlLjkdRtJdbgdGJI9QuNL8VdoXTDr0gCTDR3dYPsZ/TqoXcIpIDBtIbewZ22y+9VKD0rr//qA+HInArk899y8nOVgsHb4OqERkAc69Wijk0nik6ULkGwCm2YglVSXYXi1lYGKyY7eCd9MDD4Xm5yC4qNUTWSAQL7nqNLrS06lKEwV5clIGl9YH72DKb7hfnvtfbhoEU1frkT5RwULgyGnK6Brh539PQquHp6zlMrHD1ZZ2CZ0xkPbkbn3gsii/VMu0zSvouVb9BTipP5jRbwpfhmKn5sqyd4SumYPj0QwQ9IZ/KrujumsqdzDXwxpTIEs/3z7NBW5kXs98PRICmJww7WTi5YyZtYDZYBKE3LoZa3cxm4kUJZX5/MJo5p9cTGThVHl9aI3zt0xI+Rp9xkcGvuhF5X8NzkxHJ8sakg5i7+kGqC5iIwdTwcYLwEAQU02pnFAHpvX/J0NBMHHJZdk735m9l0aiUicP94agc/Km0pG1zr2k0L+8EzFkbb+Q35QRNMDtOWC1wcalXHRKraP9nkdNwwUmyJteuZxnUOoC3ec9Yd0Nua/Rm922OShRDCG+bf6qIZplpDWLU2/3nltQZwAuCUEi/9xiptSLO4fPytsUeAlhNkuldWFBAzxfVC5LHTi6xmgfOI/VaIzlPrRoD/GGssHI6Yus+ZRZoXtGbzmM/asB 9E5X3uz/ igJQ8x+h3AMEsEfaXWfT7+5KSShlSMMexNtJuDTyLItFnH8FhONLIO2K0yDHEGkg1wXk4an6XezwoceHGDYTKZh11c+5+OSNm+o5EPgjxg04E/oW3GD1UdaB/D5ttS0RGnCAWU2uKdEdp7no9P0O5BbgyXyGuNAMhWqLTaLV/FJpsNNWhy7b8NTY0fANtVqs5sKXxvQP1R4NifLdvEdtcZNk6lkw+B5ORKWlSpCGJXZgfZdq49FLrYpXKebvAyNfJ7HuMfc1JWQA26kYp4OW689/YVjY+qYJYeQOv45jhWo6VplbLBSPR5RAQCScYt9BCSymQsVaoWJ6La+pDEsgZ1ohb52OTExhiDRznlSV32MYfenI6i6OHq6n7h1ia7YCi/evcF2QDD1ALNoI3rheh3/CSI5W9x92wxBxsYPmz2wSY6KQULv6Bo0DI2KoFMJ+yYwT8gp6CmG2Hc43l4djxJONgIojw5HG6rEZ8H6/R3Up8Q+Ej33dFnI8JuNS//cFeqOzKM85CQO/HgLr2MqjB283L7vtzxCBK5Yw8CIbalS17/s6ri1rA7HPFwrOPgwyiUPtUothGpPhUr5A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 13, 2024 at 10:26:35AM +0800, Chunyan Zhang wrote: > RISC-V doesn't currently have the behavior of restricting the virtual > address space which virtual_address_range tests check, this will > cause the tests fail. So lets disable the whole test suite for riscv64 > for now, not build it and run_vmtests.sh will skip it if it is not present. > > Signed-off-by: Chunyan Zhang Which tree does this apply onto? It is failing to apply on -rc7. Also, since this is the second version of this patch it is good practice to put v2 in the subject like [PATCH v2 2/2]. Anyways, the content of this patch looks good! Reviewed-by: Charlie Jenkins > --- > tools/testing/selftests/mm/Makefile | 2 ++ > tools/testing/selftests/mm/run_vmtests.sh | 10 ++++++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 84573ddfcfa2..912778347213 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -112,7 +112,9 @@ endif > > ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64)) > TEST_GEN_FILES += va_high_addr_switch > +ifneq ($(ARCH),riscv64) > TEST_GEN_FILES += virtual_address_range > +endif > TEST_GEN_FILES += write_to_hugetlbfs > endif > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 03ac4f2e1cce..7caa624a2e5a 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -347,10 +347,12 @@ if [ $VADDR64 -ne 0 ]; then > # allows high virtual address allocation requests independent > # of platform's physical memory. > > - prev_policy=$(cat /proc/sys/vm/overcommit_memory) > - echo 1 > /proc/sys/vm/overcommit_memory > - CATEGORY="hugevm" run_test ./virtual_address_range > - echo $prev_policy > /proc/sys/vm/overcommit_memory > + if [ -x ./virtual_address_range ]; then > + prev_policy=$(cat /proc/sys/vm/overcommit_memory) > + echo 1 > /proc/sys/vm/overcommit_memory > + CATEGORY="hugevm" run_test ./virtual_address_range > + echo $prev_policy > /proc/sys/vm/overcommit_memory > + fi > > # va high address boundary switch test > ARCH_ARM64="arm64" > -- > 2.34.1 >