From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAF1EEE265 for ; Thu, 12 Sep 2024 20:47:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46BD06B0088; Thu, 12 Sep 2024 16:47:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41BE56B0089; Thu, 12 Sep 2024 16:47:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BC7E6B008A; Thu, 12 Sep 2024 16:47:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0A7406B0088 for ; Thu, 12 Sep 2024 16:47:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 78F3E1205F7 for ; Thu, 12 Sep 2024 20:47:28 +0000 (UTC) X-FDA: 82557271776.30.0EF197C Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf09.hostedemail.com (Postfix) with ESMTP id F269B14001B for ; Thu, 12 Sep 2024 20:47:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=uZy8WZcI; spf=pass (imf09.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726173905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QkYEDgSUi+q4cC1mKbyRLPDEigMYGApwN1eBhMPthC4=; b=yjHjiL3VuqO3oyJIQ11ZeInKtF7iRdLSNOWABIQtIfRvut8g5V7RHL/tPl0yCFNU8Cd49F 2HlXLd8BtC8ia+Gjxt9euJcAQlam3k9IvnxtY2peexmfILt7eOPkLMHNW298J33K3UhGgo JyM6fyx2p0a94IJUpZ54AyW7It6y6Qo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=uZy8WZcI; spf=pass (imf09.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726173905; a=rsa-sha256; cv=none; b=X5lAuXM/eMAr3XZYLFEiCFAkqAPAog/t+qYYM86Bu5cve4glriu8TFrBFalyq/1PPFkSXP R52T4IThiE6zEwYX0DhbTXnM6jOCELql+9QYvqv2zevgCLZS5udcSn7/pU0mUUh5ksZb+X RiXpOqninEanZQR1y9hk/kzqG3TObv4= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-6e7b121be30so110098a12.1 for ; Thu, 12 Sep 2024 13:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1726174043; x=1726778843; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QkYEDgSUi+q4cC1mKbyRLPDEigMYGApwN1eBhMPthC4=; b=uZy8WZcIruWhRW6hymwxphGHffWqqII2umcGz4fWbcSs8lu1zFPTgBWVte2s6gXT7s iy30NRvmYfTSscH+whUKHtYWpTucHwaG/17bNLiGot3k/1naJuokSLZUnAaXHCT3WNRt tBUZMGXZsxsiHe2vCaKzLV5ycPihCVMa3W6S37Gx/PuLkzXCI9eWvNmWrNZ8eHBpAMRm g81BQPsEpEzgtTP5sccLV7uUBVo15AnT3ZNJXxK/Tv7ZER/0rv7uyPWmaz1/InISHsj2 2WZlqtGj5VTX5yBGMOulvMYhdkC4K2EYZ/29N7hqdOhJsER1oitO/nFJ55LAy6AjZ4+P BnBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726174043; x=1726778843; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QkYEDgSUi+q4cC1mKbyRLPDEigMYGApwN1eBhMPthC4=; b=DUvU+JRVFmQDq6MDCZF34bP9Vft7k760gKgJ9WLbcI8s1KcaNSSzQ3gGFdlWgqY9G8 J88AnTp0CqbjFP8PK8kI7D0BWn47OrNspJQtMB1HH2WlDdeWcbKftX2XH0gS83r4Blcc gknHn+Id7a9KuCeR9YnFYwJQirr6q7NGDtdjGfaK9Ynn9KY3l5J68o5IeLFR7zgyDs28 Vx520aFZSRpKOjkZw3QTDHKlN1F/1Fnh61NzGtTigcORwWMjQ66EEuyjOx2zCV43fOTJ D9OZGpvXgrCXuXldZaFwElNO8pJQNUXHPbYih3S67vdOSLW8iVT0qFcT4cAyF5NcbdpE SZvA== X-Forwarded-Encrypted: i=1; AJvYcCW5EdHLa6NlB9IvXjMZ3D1D7DH7iWxX2JQAXjTRnvWzo+uV6kW3jmZkh+/OhwxYTe3io/BuII2OOA==@kvack.org X-Gm-Message-State: AOJu0YzDODRgyGGFqxd5ukJhhOQv+RWoi93tMRJ3yN5PYhy5QJ2T8SQ7 aZk8aSnzBiWRaRKWq1CdMo5anJgcNPPSCMpe5Hc/F34SZ3jF6DZoFWhmcKFAXtE= X-Google-Smtp-Source: AGHT+IHY1ulWf8xIoYCgymvFfMz7AvIjbgg3u2pIVYFSwdjBxA8LW0bzDtVMfKaopkm+QTibJTkj8w== X-Received: by 2002:a05:6a21:e90:b0:1cf:6d67:fe5a with SMTP id adf61e73a8af0-1d112edc9b4mr484866637.50.1726174043300; Thu, 12 Sep 2024 13:47:23 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7db1fddd1c4sm2128722a12.63.2024.09.12.13.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 13:47:22 -0700 (PDT) Date: Thu, 12 Sep 2024 13:47:20 -0700 From: Charlie Jenkins To: Chunyan Zhang Cc: Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Chunyan Zhang Subject: Re: [PATCH] selftest/mm: Do not use hint for riscv mmap Message-ID: References: <20240912100018.736447-1-zhangchunyan@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240912100018.736447-1-zhangchunyan@iscas.ac.cn> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F269B14001B X-Stat-Signature: iig6ajd5tk97qp7u5nm5hh38zz63y8s3 X-Rspam-User: X-HE-Tag: 1726174044-835403 X-HE-Meta: U2FsdGVkX1/Ahes2cZ2Hey+Ok72Y2yDpof821ybZrT6r3lzCji8Cu2ixK3FutANZsh8bfkNMSdqutkZC7PqxLDrkRMqm9gvuVpXOkOZ7d1V14u2J49zpFIOQE+j1pyss88EIuI45CzulaujHvAjla+JpcLuNZ1nFUuz4HBzd7WfTJjbR892cRQb6u4fSGDa7ondDk/PULrU9f9+EvKQakkpULPqOiqtk0XeVkT2+UCD63fuuBD7FRHwIxauygJCFsCK4Kc8aPuZX16uUdvngAKpdpg0XZgao8DuCbFyXN8U11cOXhBq/Je+FpxeheNlP5XpXK31L7i4MSG0Rueom5dg+EpCl97BzZc0OOzjfVo65NdQm6bKxen5Ob4ley+s1hyCEzIBoI9m0PyZfuHABPHVNOdW3mWsOOkHR3rW68X/O/OxEJS+EF3s/bNFrplOQ1sTYqwQBjgunFCA3kljd2J5Gt2cUVuk8MAVW/jWPx4CIKiimPogSSJXMQb/6mOBD/9yBhIiOsaVbU1fYD+rQDzk6uPUXrg5KBqZ7RTxeT3ixtx6hCrmc1SiNwtVEAkbmlt+zSp5Sxf9bGzKGrbJ+v0CQ3a4YKULSXKp7u1dc+qtWziLw1XcWLJUyH61rOn0pdLE/t0eQ9ZNVbXw5BavQwttKfq1zYjpD0jR/VSlFdMqPscPgrZ6i5f+XjGUBqCP7OIOl10bMVtXVC2sCA2N4AMF9UyH9MexEQx8hSyh2rdR6UboK5zzYV1S5l9F61+qWpd9+P6/gLrHwXt4sE62KWS7Xwes5uOPZGgCboKWm7gcNue3zfniLrUEK+7uc5HxHfuHd7ZR2/a9GW+gSt9IU3vBdX1TkT7+OGpSsVkqvF9JERAqOIVt1vE+UpynxOchv5YkSOaaUxOZnTFSnnaQP+1DDui1UEnNNADaXryqJeaA6OkZ/A8b/z6HbM7E3jbw4QYOrvzhlr04fdnx8KOO RSf6wJZD Pxwm8zHidSqXPOtdkYUNb0m+9kjJsgOENTt5cHc8r8+JK0q5k4cz4RReLTDz/Ftajun8h5315AoGmuzNZ7QHoI/3mnqpsb5rGWIyE14oil0I6T+CzBN9z356NZQU9VUUGm/2RWHzdLIJh953xCMswRV+viPjgdnxO6NGtbNsbu29nOY2RqOmBjSyEnmnzqBRadWMABSOuJak9nGKbprh4FPcUWKfVId0XU11i3CLmQUYzbpMFWK89gQlhjnZhZeCvIYpKVN9asS6FYdfpzkOo+Bj4K21KhorfxzUUxR+r2fJjbGE9wpcAh2LG2fIQaARq+TTb5HoKwHuRT3754Y4avJDhFf+QvhCLOPHNW5leTeB/68/GOANjz/odFZJ+wRWsQO2KYVmZU2GqyGQB35c8qjVtSl7+WnfW75z1BVum+lKmbjuGuDkvwqYDkzZDgVrW+hVVSxnmrgyh9shIyUJKXomZHGz8uQJ2RfQlzk22nNmEYd4mDwmYJ1gz9WTgJAU4SjDUmPuMR7cdSr6yZFfvE+5UajmQN+OCsVd7DJPV6S5oIUqz+5T4GmV6ou0vyRly99Z5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 12, 2024 at 06:00:18PM +0800, Chunyan Zhang wrote: > When the virtual address range selftest is run on RISC-V platforms, > it is observed that using the hint address when calling mmap cannot > get the address in the range of that validate_addr() checks, also > that will cause '/proc/self/maps' have gaps larger than MAP_CHUNK_SIZE. > > Signed-off-by: Chunyan Zhang > --- > tools/testing/selftests/mm/virtual_address_range.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > index 4e4c1e311247..25f3eb304999 100644 > --- a/tools/testing/selftests/mm/virtual_address_range.c > +++ b/tools/testing/selftests/mm/virtual_address_range.c > @@ -64,6 +64,14 @@ > #define NR_CHUNKS_HIGH NR_CHUNKS_384TB > #endif > > +#if defined(__riscv) && (__riscv_xlen == 64) > +static char *hind_addr(void) This is not a typo by you since this is the name of the original function but this should be "hint_addr" right? > +{ > + return NULL; > +} > + > +static void validate_addr(char *ptr, int high_addr) { } > +#else This is something that I am trying to solve over at https://lore.kernel.org/lkml/20240905-patches-below_hint_mmap-v3-0-3cd5564efbbb@rivosinc.com/ (the solution is still in flux). Since riscv doesn't currently have this behavior of restricting the virtual address space, I think it is more reasonable to disable this test entirely. After we have a longer-term solution with the patch I have up we can adjust the test and re-enable it. What do you think? - Charlie > static char *hind_addr(void) > { > int bits = HIGH_ADDR_SHIFT + rand() % (63 - HIGH_ADDR_SHIFT); > @@ -81,6 +89,7 @@ static void validate_addr(char *ptr, int high_addr) > if (addr > HIGH_ADDR_MARK) > ksft_exit_fail_msg("Bad address %lx\n", addr); > } > +#endif > > static int validate_lower_address_hint(void) > { > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv