From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D70DEED629 for ; Thu, 12 Sep 2024 17:29:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79056B0092; Thu, 12 Sep 2024 13:29:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B00FF6B0093; Thu, 12 Sep 2024 13:29:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A1DD6B0095; Thu, 12 Sep 2024 13:29:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7BB0F6B0092 for ; Thu, 12 Sep 2024 13:29:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 13F84C0DC3 for ; Thu, 12 Sep 2024 17:29:11 +0000 (UTC) X-FDA: 82556772102.07.B8D6B44 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 01B4A1C0002 for ; Thu, 12 Sep 2024 17:29:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OmIhGJHD; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726162096; a=rsa-sha256; cv=none; b=M7HCMlcQtdDWx8uE5w6JPW0ne8IiQH5gWbSQhaE2pk0nTy23bQijd58CfW+LJpz/8qUFJk jtPr8XvzMly7KxsWm3o2j93e6A/T8txJkgUgI7ka31bEf6cgskcQKmFV6WUYPxYbrr2L2P 02Pp5k2ntOApwkTvBef+QW0bF0jgmec= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OmIhGJHD; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726162096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hrVMC21P1xrwM4QIBFAh+bX10ttuPrl/vASIkrjY7Uk=; b=LPVqsIKFw9Ln99ohQF9QmEiAH3OLhVv0xW6QNB9ridvdj4HWsfbPYSydq6Xyr0RZjFYyDY D6KLM/Igdu0im1LtIfQse2uCsoTs2uUocGr6rrqgDdaNcWXIyhSWmBX+FZBcbdC98S0feV Zce5fEPHDC+ayDQB6F9z44YdJNveLHg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hrVMC21P1xrwM4QIBFAh+bX10ttuPrl/vASIkrjY7Uk=; b=OmIhGJHDI9el35L+OmDEXjnF/h RlnjuEeE73Syq/02eEZ1ZQecSLbo0X6xYvbS8Jjs5YhBjKjzTpuFzSPhOZKtwCvpzxSgd4BL0doGv 2o1XChB6joqcbuAHR/7dyodu6qdXG9zGJYOg5Y9ScmqEtsKoKLPNhbZU0JwPM9q9+z2Q4GedxqlfD JGMITVn6h3zdE0+CXIPFlB5m2XkZtj2vskcaNj1SwDvUE59C/U19r0ASZmfPo+1pIPPPE8ka0cVJX OcYajPFaC8OcjTaD5OURqQRVSg7I2/yPC++da75/36LTifKkHQjL2hSQi6q8rGabA8FAsam6xocmd 11Cf/J5Q==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1soncn-00000009kTn-1hkJ; Thu, 12 Sep 2024 17:28:57 +0000 Date: Thu, 12 Sep 2024 18:28:57 +0100 From: Matthew Wilcox To: "Christoph Lameter (Ampere)" Cc: kernel test robot , Christoph Lameter via B4 Relay , Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Yang Shi , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Huang Shijie Subject: Re: [PATCH v2] SLUB: Add support for per object memory policies Message-ID: References: <20240906-strict_numa-v2-1-f104e6de6d1e@gentwo.org> <202409080304.haF25cFZ-lkp@intel.com> <2011fcea-b4f3-a7ec-e747-6ee0195452e1@gentwo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2011fcea-b4f3-a7ec-e747-6ee0195452e1@gentwo.org> X-Stat-Signature: i5foaf9yrnjbk7fq3n4zx4mpudicaeur X-Rspamd-Queue-Id: 01B4A1C0002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726162148-167851 X-HE-Meta: U2FsdGVkX1+QDObUhE1Iq4QlNDq+GO0pkCM+il+7vDnV2CreMPcqjRfGi2FQPgmU73GX/YGPOJ/cVqQt3JjDLE7C0RbRcCWeVQvV5laFRUcb7hGmM9dETzfnrhkEqCRWlsAb9+QsSG2jCjrYPgmArbQEpceBW6axd7EWmq8s3zn7yldYgceOVUXTcjBt6PlLZK8aPYNLZtRsmRYAw5zscl8mLpUKwffSKacVJayHjAZZhkqywC/Xn/BcivtDurx6yqWbCWVg9FGrpVbxWWNmz4tmAcGdTHkq1aS6KKill5M4/rNd0lLzWOCHY8lQ5LKpkioiljtGZ6RawBy3I9E82KRm7Nxs+D2fDxKx0e8tumAeOfgQ0v0wFjtVaswb+SNbk7ReQQQU/JiKZfPDchbzvInY/o/0q824g/7wZ18as0kbqUeJ1wQZ2Cl52oNe63+6CeiKpy1WJX/qsgg69Oguqa4uTTsMKrl9xR3tF1GqJaqADwDC2+x1qJeYrHUmNaqbiIJEWVTV/7s+3G7dUHFAn3jn3Y7mTdDT5Pq9/S/iYQ8Gx9jKf2CGg+UJk6YgU0Yg6IKnFgEJ3V1aBKYIaB3UbW2hFNtbL6wsWjTuaoz2FpYdf+ME1CVotSi3gRzVn0jm25sfddGIWn/4nk+sw2opFjq+WpzqbIkToK363m4rb4yz7v7J3pLibu66nRWql5y0n9u7/mAaHZv89yCbReRVLpml2qvUJrpFDoJyJSXFA7LRcMZ+oVeDExxAyEwblpFMKhgu5+pA2GVGfUXZBi+CYt/GHtj8btnW/c1LAL8J//hL7xfMETLYXq7vY+0wavYL/hfcqdoYFQm3c3zWIp6+EyaCe4592WKM0otDN+g/4DYLO4G6ffQ4Lv6NQ/rkPLnVLrT6MLXItkCPi3/pbt5csXUO41JWI5PhS6+LInPQSKSqvE8ZyNpHysU+dvYkBB5pgRfaQLajkpvqc+hHATQ 7L0srPH4 j/L/5bWUgqaLTOGRxBqAGC5j3OBGy9Sxeo58IztCHVAeqwy0ff0ri06R0TVKf0ivHWIZNcIc6unOraK2r+WTGoKRQvJauoo1TUfyou5oyjRooKfH/rzv3x24NEMspOXIW1EwRBPpJP+2sye+mGcRPxKMKzL+qqgnRBgihV8qLgn1tR/hgpBzTGrtQ7wLmbgAQ+NwXglOzGzgPqYlae/0/dZGHVWymYrf64TPrCEfw5WPinICcMD2ccxC2DW3tKIaeGbfIkTqZifdNLG2WnGc0EkmZIHiGUisR+TdsRU1Pe+LKQaHAWYs85sZGrAiu5/3iKKV4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 12, 2024 at 09:15:34AM -0700, Christoph Lameter (Ampere) wrote: > > sparse warnings: (new ones prefixed by >>) > > >> mm/slub.c:222:1: sparse: sparse: symbol 'strict_numa' was not declared. Should it be static? > > > Ummm.. This code declares strict_numa. Whats wrong with sparc64 / sparse ? > > > vim +/strict_numa +222 mm/slub.c > > > > 220 > > 221 #ifdef CONFIG_NUMA > > > 222 DEFINE_STATIC_KEY_FALSE(strict_numa); maybe this should be: static DEFINE_STATIC_KEY_FALSE(strict_numa); if it's only used within mm/slub.c? Or it needs to be declared in a header file if it is used outside mm/slub.c. > > 223 #endif > > 224 > > > >