From: Matthew Wilcox <willy@infradead.org>
To: "Christoph Lameter (Ampere)" <cl@gentwo.org>
Cc: kernel test robot <lkp@intel.com>,
Christoph Lameter via B4 Relay <devnull+cl.gentwo.org@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Yang Shi <shy828301@gmail.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Huang Shijie <shijie@os.amperecomputing.com>
Subject: Re: [PATCH v2] SLUB: Add support for per object memory policies
Date: Thu, 12 Sep 2024 18:28:57 +0100 [thread overview]
Message-ID: <ZuMk2Yc7i-JMiHpA@casper.infradead.org> (raw)
In-Reply-To: <2011fcea-b4f3-a7ec-e747-6ee0195452e1@gentwo.org>
On Thu, Sep 12, 2024 at 09:15:34AM -0700, Christoph Lameter (Ampere) wrote:
> > sparse warnings: (new ones prefixed by >>)
> > >> mm/slub.c:222:1: sparse: sparse: symbol 'strict_numa' was not declared. Should it be static?
>
>
> Ummm.. This code declares strict_numa. Whats wrong with sparc64 / sparse ?
>
> > vim +/strict_numa +222 mm/slub.c
> >
> > 220
> > 221 #ifdef CONFIG_NUMA
> > > 222 DEFINE_STATIC_KEY_FALSE(strict_numa);
maybe this should be:
static DEFINE_STATIC_KEY_FALSE(strict_numa);
if it's only used within mm/slub.c? Or it needs to be declared in a
header file if it is used outside mm/slub.c.
> > 223 #endif
> > 224
> >
>
>
next prev parent reply other threads:[~2024-09-12 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 16:04 Christoph Lameter via B4 Relay
2024-09-07 19:55 ` kernel test robot
2024-09-12 16:15 ` Christoph Lameter (Ampere)
2024-09-12 17:28 ` Matthew Wilcox [this message]
2024-09-12 22:21 ` Christoph Lameter (Ampere)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuMk2Yc7i-JMiHpA@casper.infradead.org \
--to=willy@infradead.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=devnull+cl.gentwo.org@kernel.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shijie@os.amperecomputing.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox