From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CC5EEB576 for ; Thu, 12 Sep 2024 09:32:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A79E76B008A; Thu, 12 Sep 2024 05:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2A116B008C; Thu, 12 Sep 2024 05:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9196E6B0092; Thu, 12 Sep 2024 05:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73D1F6B008A for ; Thu, 12 Sep 2024 05:32:45 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 03A6941DFB for ; Thu, 12 Sep 2024 09:32:44 +0000 (UTC) X-FDA: 82555571490.18.EB659A8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 58B62A001A for ; Thu, 12 Sep 2024 09:32:43 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qF0anm2+; spf=none (imf25.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726133424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n35qMkqNikSgVY2Dl9iFW23QY9JJFH2dYr31jQSdmYQ=; b=gqimvki9xd6JpNDcxuCRoeVprRa4WgkLipjYzNpXQK26iaJNS9MQyOFetfQz872BznuOVo vT7BkwDt0CVaVniyESYmMQels7sdAFvNY8qWbY5xucAqkwEe0MpoHIu+jcejX4KPODn83S X2WfPGhxZwBPEOvB1hKosvGUR27dJas= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qF0anm2+; spf=none (imf25.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726133424; a=rsa-sha256; cv=none; b=kGZqyEMOioNkEiN3kvHG3gkb7HfLk4+Ve53wS0RMxXfYMbC6v32T9ViedeSH3t2E+vYV9/ TLC1ScmlQGMyQI6l6f8NRbGAaZVl/9G0rnpLvlzndoqSw/PZg2xnEYLUFSXx+wXzHqbhtX RRiFFHoMaINC47F9ujFx73aOhaWMdsQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n35qMkqNikSgVY2Dl9iFW23QY9JJFH2dYr31jQSdmYQ=; b=qF0anm2+DvXS/vszjMXYVq+GWN srWNKl/S4VJBxhdAPwnxSXu8Wce6GZnyW8dSocqvotRO8cC2i1odx/lO2FScwVxfeKvxB0+uapkbE jhUR92u5Z98zAfQ7QKdAUjjSz6+blN10P7c3Y61Y65A+zH2YAfMzNYB/OTXPojX5r6AFlGXPHHzIc Ga+osctonojo087sdZd1J6dRyGjdtncVSMPB17u+Sq2DLJ3i83f0qtq36aCO5l7sGo7mFv5l017wV qJYczis9D65Ce/+GILYDABU2a53QDqNlJcEUEJOvtNpKDomj/+yhW3t7w7IhnXS88cgjzCTtl2jKe idpAd3/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sogBu-0000000CXzj-0nEq; Thu, 12 Sep 2024 09:32:42 +0000 Date: Thu, 12 Sep 2024 02:32:42 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Conrad Meyer Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd Message-ID: References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58B62A001A X-Stat-Signature: f6wcrtyu7at76qa6abauwt7o9gejc77g X-Rspam-User: X-HE-Tag: 1726133563-803514 X-HE-Meta: U2FsdGVkX1+slObNncz9Nr5Z+SzoYHuo9jpyUu0VFpusct+ggqPoKU/I+LUe05Jv4ORjzjG1rY38K52BGj2DioFbZ5SC+tLJbcADNrkRxUy5Xtafet59F0mSvK61w1T3DiYkTBNR5xOgD/7ch5Ie00hvfZB1o/T39WfL3GnaqX93cr3jHmqwJ8sT1vWu/NYzQL4osqF56lxt3Y8x0ncbwCoJqvH5qcVmOoT6u8pGHm3W15xsUHgR/kaj9W/9zCgDNlcaQcaiHomkhmCbgrFy0lNCGUAoauTq2WiyW6OuKYgHRspiO3bGtiosz/IWmh7L/W8n+9C+Vov8vhD8t4LiRRMJ4TCC3neLGKNZFFLgwm98pkpwXWJeqXGNtQfOY84Tovug41A/TJvfPh1X0cDNY3Y6rIXYtX5GuDTj2JplhOPQ42+NzGTJ+K7nd5Dq5/rX9O1vvlaaHcZMeJN3+2lFK7XRTj6HevSnL2SIUP2bT+G6uOlIZrKPiRVnBN89E+26WVU98FBK9wfFOxdOCBV1JlzBP2ayXxn2HH6OXPl1K0ltQIndHjHRx8ZExe07s0waM+el1ue7KccX7SLZXuXBXMuH6cyJnRPdURdXoxxg8raRN1L6iyGPEZKI9OorDu/m/0G2bi36VOmPaZeue2gFo+cbVb6R48pnmzEWhLgMS/ORN4Y4H077rAcEpNN9YczclyaMWFvNNGOwae+sAFRE1dg/4EyM/zCEtZ+Fes4X+zqecJB+c+cJnJBEwdpg0M00mHXflcJXwTMW++KKnwapQ/mHa3AX9cZhqFG0JCz2up9m7uety1HikX4w44arQDYN27MxYKFGKuLNpmQy+5AGV3HCtTYP/v8sxdsZb3qgn1xMkzBg424k5BIjx67WSeFGHfwm8c2CyhihQx2snyvtI2j6sPcI3GTGHGhkfN4ZykW3ZJQtQ7QQV/WF/NY9XoRQWHEFrj97lYMwjld03z5 RFxN4wnN 5aDG/59H1yHAH1FZ7AVmGjW8pKQ+oau4Ik6lRKuszqjiNEA8G0z6+erkQ4RRAY+mQKEL8lQufyNH+cpMNfD5ab7+n92QsCrTKOZcep1qkd+mMA+tnFwv8JDTWzIa9PR29kgkk3JyaPt1vN7AF8EhrmmtP9Y5Dwb2QS3cKg63BDhdN2iwe+aZD+cor+cfXL1CFy3ZdKCj0Y8xxbAOUA50LSo0XuC0sQ7M0xXEyxgknHbIOF0vbvftS1Cq6AVp1SVcQ9GxqnLkx5uF2jaeuihWT7FSSwDPkIr2U7ese3Y9Of5WBAQwJNLjI8Dytd/E6eMTg4W9Rp3rpqiE51xkbCuGgsew4XQEX1CCf02fhxIrtWf25yX/tTxdgN3BGSevDwlTLn5wvpGw3dQh21bb2fcZkcxK4C6BQNyGKYPoEgDEz1TRF8YNISfAhr45WPHQQoIhd7OO7q9i+ZHQ+6Plj+01gYDnb9SoNHhhmr8HanPZzUnyqrn+GjSw5GnAXbAeV8nJeWxCgvSEnmYl1JirhNHoYEyp4o3atcczoXl29LHQX7MSX9Geaihau5yCzjGv5oIIR7tjG3hdT6FtgXSj+vm3ooKx4ow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 05:34:42PM +0100, Pavel Begunkov wrote: > Add a second io_uring cmd for block layer implementing asynchronous > write zeroes. It reuses helpers we've added for async discards, and > inherits the code structure as well as all considerations in regards to > page cache races. It has to be supported by underlying hardware to be > used, otherwise the request will fail. A fallback version is implemented > separately in a later patch. Except that as far as I can tell it doesn't implement a fallback, but an entirely different command leading to applications breaking when just using the command and the hardware doesn't support it. Nacked-by: Christoph Hellwig to this incomplete API that will just create incompatbilities.