From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A49EEB576 for ; Thu, 12 Sep 2024 09:28:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B1546B007B; Thu, 12 Sep 2024 05:28:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 260326B0082; Thu, 12 Sep 2024 05:28:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14EE76B0085; Thu, 12 Sep 2024 05:28:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E76986B007B for ; Thu, 12 Sep 2024 05:28:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 688E14165E for ; Thu, 12 Sep 2024 09:28:54 +0000 (UTC) X-FDA: 82555561788.30.F585873 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id D475CC0003 for ; Thu, 12 Sep 2024 09:28:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NYk6DV4A; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726133327; a=rsa-sha256; cv=none; b=CyGSqULB6NFztKmkBAr/kvLhTvuvis9aEVp2oLRiwAVZr6i07/Kje4iGt3egMD2tzmnVWC Q5NbLrW75mgeAdvjd5bNjtW2+2f5rYV9ja95HgVaJKYDs2vLbTbZZKBIZShZPSGDRCoU7w aU0eMlj3bS2iE26iuqfhuFFuUyo+94c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NYk6DV4A; dmarc=none; spf=none (imf22.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726133327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eAmkBNXobr2RxYsdS5bAIh0eBkEdCd/pvZs+9hqhqK8=; b=TeO2aZWzJlHHUy83seJxu9zB3j+Tdup32fRJ7o8Ff3PsWg6mgdOO2YEI5bFq5Elrv6Y9ud Qub3y8JfzKYHLGEqYSSUTmlaZp0qvrw58Bf7z2g4vO4PsLTpTgNSmMvmpCHbHI3wYYsUpD RGWMz5/HEs70qvxMgf6eyjV6E6FDAkM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eAmkBNXobr2RxYsdS5bAIh0eBkEdCd/pvZs+9hqhqK8=; b=NYk6DV4A/GDMh5wbsVzY0HsqNs Mk9uX42oCoIgUygO+z1z9E9tEeGSPz7nA/7s4wtRVqLucqWDqZ57z8dYILVw3FdivKPXjxh4iEFlU +TkKpmOvq4zg5dnXZILCaLcaI99jYnohMuQOBWcPqiXeVrvV7OxxHNAKoAr9JhjZZ1CT8UrEciH12 rpAUohxonIjQmFQjQAAoBNbMasiM2rlHrY4oUivC3iMM7uMxo18FMGr6oDTc9kf1xicW4VVTQ2o1S ElBk7kBQoOlfY+zsnTlEHrI1WtVT4H+5glFkDySSm4fZ58XkpDyz2N1F7G0CknDyyCRWKFw91qfGl xvlSnp4A==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sog87-0000000CWim-3IbK; Thu, 12 Sep 2024 09:28:47 +0000 Date: Thu, 12 Sep 2024 02:28:47 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: Christoph Hellwig , io-uring@vger.kernel.org, Jens Axboe , Conrad Meyer , linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 5/8] block: implement async discard as io_uring cmd Message-ID: References: <7fc0a61ae29190a42e958eddfefd6d44cdf372ad.1725621577.git.asml.silence@gmail.com> <430ca5b3-6ee1-463b-9e4e-5d0b934578cc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Stat-Signature: 5r4ebnjbzoejujr5k7iowukx1wso18ou X-Rspamd-Queue-Id: D475CC0003 X-Rspamd-Server: rspam02 X-HE-Tag: 1726133332-387189 X-HE-Meta: U2FsdGVkX1+3S9muPYOgNH8yPnjbzovJ/ZwB3xbHDZWsVtjhIh8/yAI9nuA5P64S9qsBLgEjxrHsV+Nd7OloWYqPviqZ3zkal7Ra+nPfEvhsKIYG61rN3LN9MLhh93nfAE54wdd+Scwapdvq24AtVAdxW3AApypgozrXkWStrAJpxKuTP2wON0ABtaBIUVRITwhCClIpInLvxF2zx/kXuWf3A6EQZAOVhuCEzu4lNPwA8nuR9vK2/lt/qx2Sd5U61OofOhm8s21ZUJ99/U9dnmd1GMVVgF/rCULPdKYiREd7i0XJqHNj+3jF7Ym3uzrp3xDqEuSFG20H5EOwh4fZOKaHYEvYwA4If1Ja5Rulwh4fGoYG0v1hOzXHAnnJm05B0GqCFiWh7Sp5ym6Pc6UGlB/toE0WYByi8Q7LDi/J8PAvMQVQ26L8OUNG0lf28m5UXYANlWXafTCJpIvwBy7WsLyscNu1q7Rw61CqCCVE0IMXGJO+e5/WAmBViUD5ipmRktKSyf/0BUVouhJMGWatCn6Wv5poyN3we0QE2T2yyFRQAXk5f4eC7VjZCdzZeqsBGgu5N78ld/0/WPohdNysgB9YbWwOKqqpbSJT89raDLcJ/bm2xDg1ZBr/uWP9cN68PBJvPdcVlqHzwlViOOM3z6W93cjZfJp9VATSsvpsRq6cjTm2BkaUOOWmhRnvZIwZe+vQVO5Kj2wkoMwb/TGUyRdk3HG5hvVi42bQ3nFhl01J0Q6jiRaSTte2jJ41TFZpxYaxbgUKVLZOnPOBcTVp3XBR04Q1aSJlwvl0+Xj36rOkWRRkCopVbpAPNoLpbB3t8RCAde0joyMpdLRi1fi22fpK9wsO2cYn1b4eKQMSNuB69vH1M31ji4FVbfQ3PZSxuupLpLgBFxJUmlCgv+O0bG+Ssjk1sulVXX6rN0MHV6Nvubm80qqV5NqwkKWs2Zue9FkbXaezRt4FHCNvatx 0dtzjocx /zMXeMBkUTB00fa9BJfkJtv4eInFls+9vNfO5uL2YTqridG611DBfM6ovZmdRq0+o6s30iMrYvtOI3CeZBZwAk7IbF0eZsuTwFvRD8ByiUY6heW435Y/2vBxifBmXxjRn6+o20I6AdUB38OobbWBx12sJooI7BYQsUJrT9T3zTxWojhBwPK90exLgp3pGcUVO1zbwmFh+b7NxR40YLjAsq6bwa4vhw8axbgUQ42hy+1eLlF1hzf3nAP209sQ+tYT5glG3uruhk+yxA4BkhN+vGwvJx3DICN5g3+coIehRn6U025N8rnt6ycAHp+l1Nz89hNIS2yZK7E6YDHMpRHS+Zz6nWcm5vxkFirR7qK3rAcInaXhptxlGdsV9lNwtd2s15bC2VRgFisIXL3zMKqhFhbfLvkVklTYc1U1PETood9+KuPHqmWAlsYabQh5pjS+Idc4vaQ6tRimNDk54wmOjmeSTbJzcAwqSADzMSObXdO/YWqOpyrX7sl0hfPpeziTZi33XYIlUeZ4pawWsvqSCd0nWunJeWWwevbNrxIrUGZXmDgItDaJBoG1sd3g8dX5aNG2HAamAGjDoF569hIIq0FFrYg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 09:22:37PM +0100, Pavel Begunkov wrote: > > while ((bio = blk_alloc_discard_bio(bdev, §or, &nr_sects, gfp))) { > if (nowait) > bio->bi_opf |= REQ_NOWAIT; > prev = bio_chain_and_submit(prev, bio); > if (nowait) > break; > } > > Like this? I need to add nr_sects==0 post loop checking either way, > but I don't see how this break would be better any better than > bio_put before the submit from v2. You don't need the bio_chain_and_submit as bio is guaranteed to be NULL here. > > How would adding a proper header instead of bloating fs.h not be > > part of the series adding the first ever block layer uring_cmds? > > Because, apparently, no one have ever gave a damn about it. > I'll add it for you, but with header probing instead of a simple > ifdef I'd call it a usability downgrade. blk ioctls have historically been in fs.h, and keeping it that way instead of moving some in the same range makes perfect sense. Adding new commands to this mess absolutely does not.