From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBCAEEB576 for ; Thu, 12 Sep 2024 09:31:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2899F6B0088; Thu, 12 Sep 2024 05:31:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23A746B0089; Thu, 12 Sep 2024 05:31:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129266B008A; Thu, 12 Sep 2024 05:31:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E95CB6B0088 for ; Thu, 12 Sep 2024 05:31:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 74E0C1C6D3F for ; Thu, 12 Sep 2024 09:31:07 +0000 (UTC) X-FDA: 82555567374.20.AE846E2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf07.hostedemail.com (Postfix) with ESMTP id DDC7A40013 for ; Thu, 12 Sep 2024 09:31:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZX79e4j5; spf=none (imf07.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726133326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fEDX5bM20mH2/Omar9IVkN5H60WcnkX1hb9UHnysmfw=; b=5xw9VO+dWpiv1rn2AYaSg2y0lOIrUp/UuS1n488pRvJIOeeuOWGW4+RMO419d6UZyu4il4 r28iFD2/Pa7mlmECVC5IHe6jORIvTQ1xJ4DdrG9qlU2W+wU0gs4Y081nTt0vYQE6HS3R4W xiLHno239pYhol1dgfTjC9SWyMinFGI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ZX79e4j5; spf=none (imf07.hostedemail.com: domain of BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+78b913441a3cb29668e4+7690+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726133326; a=rsa-sha256; cv=none; b=njLrvi/AOVb8U4xAzUaoNQ04robOmsaXTacF8iAUwAs9gSR4iSHkWKquYnQZuJbOKyCmOD 9n/XDJoqav6WwxHIkNk1AcVIB2CVfoVd+ncJeDvKJqQq5q0fXkAil9S3sYKOL1wGUp/cor 9LQZSfbWHSRrhMuvLoWCEwK9+5s4NJw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fEDX5bM20mH2/Omar9IVkN5H60WcnkX1hb9UHnysmfw=; b=ZX79e4j51fts132lM3D1lXFya/ TtuSDTUVkEboUc66IH1Crwjig2qJX78vBHx0SSZWiX1M9V7t9CWP183p9FAMobkFBB9GswQ1Icq8J 3Dr60zE+ltv651gj33qsxUlbRk974LUehp6CI/SmZxXf9gZWMGOO5MDjvw5Owa7/PD+HPI+7ljZkn 4JJjCeEqLuGb3N/VGD/GiPXPQMrvkFLUTU6GiJJv6B5ue2ya9erzANwkP9Sktgh3xwX8pHCWm7Iz0 n00bHY7QDVsNtlVVOSYIW+GFQUVWYXtQ08nNtTbsnkuqXo7rimIBau7yMGbu1Tnj96J5oSnBHI+/a DfmAOkiQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sogAK-0000000CXHZ-2nAw; Thu, 12 Sep 2024 09:31:04 +0000 Date: Thu, 12 Sep 2024 02:31:04 -0700 From: Christoph Hellwig To: Pavel Begunkov Cc: io-uring@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Conrad Meyer Subject: Re: [PATCH v5 5/8] block: implement async io_uring discard cmd Message-ID: References: <2b5210443e4fa0257934f73dfafcc18a77cd0e09.1726072086.git.asml.silence@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b5210443e4fa0257934f73dfafcc18a77cd0e09.1726072086.git.asml.silence@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DDC7A40013 X-Stat-Signature: jg3wcino93s7qa74qn14yazpu3zns5rt X-Rspam-User: X-HE-Tag: 1726133465-38868 X-HE-Meta: U2FsdGVkX1+RRpr9n/v/e1zTBi8X2BYsBIA0uHzzhxQPbAxJrQw9kVCEO8o1dvqAoZXYIcnJuMr99XFSl0ExmCPjxMb8Ww/TVUBQoNaEEMdtM3teP7ObrMtymYs4r1viouQdzPJrckWfdBArIflDyyyoMAG/cMBK1K+3DhGjr/l7950woGCZ+oOrfO7MDYKT89zHeHEYd/u+8ubmucq+Sqirz4hA3TT3YBCEw3XPCI6CwwYX4rgw6HYFNbMz4SdYpI5cQZt8zf9msWT4myFo7jugM+J6jSc096Xj7I1IyRHqfR87cvEkNqrMhd0uIWzvWP+Ed8cPH7OgVLsk+dsO4kyDlIlJ12xchSxVuSB3QG0LH0ZOAkegdNECYdE44psEZ2TmajAP2UdpmnETQL6bLvGOJdx6iFKD6iiAq20185Q20hbw1555P2mVQ2RSp2STbTxS0rVfhRVcEJuvcVhjOtA1eKR3wVo9nJUoQOj3QbtXkihkqwMj95/GiVJX5Eu+npnxyW/Dk2Qhb2q7PKfsIIbTCRFN4ZQCgF2F+sKUo0cWTGlIqfmQf3yGWkwrJIqaw8v+uMFRw9rza1wDh3EIBMZfBIU9YJWffROIYebDGK6yw4SyUZ+ANBhmHgYTgAfe/ms9fMsbIRIs6uVcshQSj4+A1Y06i0fM0Car+LpplpNjDtxYB60ZbXW2qbgFNaTZHXb7k1uTegTpWjt8feSVjVlpSSOMHDwCS9rBEfnoOanzYHUxDoWiJoBamR1Ce4Ru4fOgxXXA8AHRnqv6bnUz5jmrKoqhPiBiUj46y0M6PASdjWZP00S6mjTvY4cppzifXmU8vF9lpeNUETfINqc39HmSvx+sx21AeBzp2vuvp8iNG1v2N080GdL4PzHxJLhpFDI6hS0SCoQZIcCDdhnbmYhZQNoVwky9Moj2q0yk3mM2LpGFAZCsiUt0makZbnUmVw6VR69+l+W9nyAVwRT wB72geLR TFL9fVK7IZV1ldoXMwsbT6iP2PZpbmbYYPLrBTV900PCPmyKmurU8iWFfmIGpISbd0tKlGMwXxT71YDeANuJChJzDxLfb8p5p8eTAlYx4eg901CKKJYx3Yiyaac13QS/eCtNb4e4af5DozVs/UXCw4QNtworNh6DP0ttqHT8DEgNdVG73wWgBjjRJStdpn6WAN7Y+etq9tF8tphioH31MOw2hqiqHShGZBnLTBRqSudxeW9MmeSFmp0V+OxTtW64IKDAIbIfGDDMPKmccKx9W0z7+Zu/4gPzgZ0kq6Q0fwutlDgQtEWkFJJ/24GpS404VWp+RxTZ0P98wQdo8LSLs1rwmzoUl/NDqIRWOqPL5hlgZiXbV1Li5+1AHA3HPKobw0IedL04SIGdg+KJfPOfyzCJrKjtzI1qiWWs6IVjJhz2cUA3hav7jW93rWimjuB4Sl1nMkz/YyYzUs5nhWIKlGcXuXo27JoFbcGUTOp5Jlma1gbVMrm7GsT1LaASc6GmA49OLNfbqYbuiObd0+eiFPy/G1i5V6Ulytk9TdJa6vwzBAAdeW+01JSDXGrlG2nrFlBHw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + * io_uring block file commands, see IORING_OP_URING_CMD. > + * It's a different number space from ioctl(), reuse the block's code 0x12. > + */ > +#define BLOCK_URING_CMD_DISCARD _IO(0x12, 0) Please just start out at some arbitrary boundary, but don't reuse the ioctl code from an ioctl that does something vaguely similar for no good reason. The rest looks good.