From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019F3EE0208 for ; Wed, 11 Sep 2024 17:08:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0BF940077; Wed, 11 Sep 2024 13:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 871AE940066; Wed, 11 Sep 2024 13:08:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7601D940077; Wed, 11 Sep 2024 13:08:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 58B0F940066 for ; Wed, 11 Sep 2024 13:08:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0AA9B141211 for ; Wed, 11 Sep 2024 17:08:58 +0000 (UTC) X-FDA: 82553092356.21.4D5D26B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 2D154A0012 for ; Wed, 11 Sep 2024 17:08:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L5svkaqd; spf=pass (imf25.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726074482; a=rsa-sha256; cv=none; b=POVgvqFWprhU2LnQKADrMknkDtbQtSsDFxeXJdnXpHkzd9zD3umDFKzufDH4Y4XOvala/u prl3EnzzTpy23kTJjWIgAN3Jte7vLl/tLnHPRYI1xFo/UbE9BWVXRm+oXzUGYnks82qxoK DCmzx5t4J03KcPcPmJtKjeNapsJbHbA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L5svkaqd; spf=pass (imf25.hostedemail.com: domain of kbusch@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726074482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jp1yiK0c2dmZY96LWtQq0IfTcW49sEz+671XVriYzqs=; b=HvyWd6Cr7mb1vrIFNmpcdXilS7oDvElPKFFbo3nwyWq6SpZ0xSBDGHdBGqZDZe9LWoQegM 6E2wNAe4DU3j24Y5r5mq5JtmXyX9+BeR2OUZBfK/YjrLIbrK0Ej7X/5e3uKwSLXcUX4LD8 fEFpHhyAhL2Naa9S99LRB5teLDTd9sk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 63D2D5C073A; Wed, 11 Sep 2024 17:08:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12065C4CEC0; Wed, 11 Sep 2024 17:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726074533; bh=JVIh/s4FG9utWyVDfpxXtb9ClNpZP1t8v9T5/D0JTMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5svkaqdBfBRtQUlgREKi3MzW6bpX7NMM3Lta1D6yy4YgZ3jFZ79l0h4XmOp8rtB0 P3qzsBRsQ2NZAj+SlDXQ9NAP0yFzPV15kZK/Yvbf6MRBcg/DBrUZCWo84lVzr0Z9lW dF1m6Y/ki2jtEEJh+rvnBBfyQcSG8i2GYrcEqEj278NTb6jHSbdEmipNOravR+6BCf QVnu4hl0LAvuvkVRoknUP49lQWG5fmKW/c4gCjoCkuwioMBzbClK5ITUSYNm+1506R EjfLA+l/dXafyFq9AUy76rCVT0FXe5WIkQYReKadjYubkjM2o+cPwum0oQ/gihVdh8 bLzv6LIx/Qi7Q== Date: Wed, 11 Sep 2024 11:08:50 -0600 From: Keith Busch To: Robert Beckett Cc: linux-nvme , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , linux-mm Subject: Re: possible regression fs corruption on 64GB nvme Message-ID: References: <191d810a4e3.fcc6066c765804.973611676137075390@collabora.com> <191db450152.e0b28690987786.6989198174827147639@collabora.com> <191dcfa4846.bb18f3291189856.1624418308692137124@collabora.com> <191e203fd17.118394e2d1606957.7379866259983341167@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <191e203fd17.118394e2d1606957.7379866259983341167@collabora.com> X-Stat-Signature: 1e7d63r5pee7kqw5ed3rp9w616rhimjf X-Rspamd-Queue-Id: 2D154A0012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726074534-756141 X-HE-Meta: U2FsdGVkX1/bNYWgkGB2dJe1ADl0Efj6Nhy/eQRAZCvC+cjPfWl+lwpQCNg6mjt6VVfZGIPFXv5TuraXhhczgPfmOndY/YscyqjSntfAwu7q6RlAJl8xmV4LNu7hLNteZ8R29aTnOO1fR9S1/nO+csBf8G410N56ci53nhcAy0bNg/+WfaQC/zkdP69BXqhPrW8bWQ5KSyU+7xR9wG1jvV4QCsG9hWWX4p1nw4/sxt6bdOg1JF5MiHi44yelBPoGqrsyNYrKrinBJ4SKxRq+h6zQOteNUaT1/f7w4TVjBdipsUHw9WnE0p+k0kt/jaT1cBvZBlyNyry4NIWxQPlvM/hjaaO6Kkx7Pl6FYXqB0Lf+bmcvdB4/+7WaXbJHKUY8So3UQ7lMuBWD72x+DTIFL26ddC82cwXTYfXNNeKOVEqznPKR9HG4RD9Zews0XYJkWNuO2FN63dWMvmEbeSw0bz1Ogyx4RsFvGeZsAGlXwIVzCdxv6IB33GvhMuvX4rDwgRFrzYfPF5Zj1meTTFTgy+8JDcYDize7ycUzaiEzsnmnuxekYCHdE7sVquz9eDzz1T+u6krK5aSbP4t8vtpXveDHdPkO3248SeCyfLtKg64ygsg2LIuOL4pkkG8oKRiaZ2z6L70QMEf5konsuLd8lilZyZmZKC2IIh6tAuYsPWXnJCNWUqSqjLEvQrD9syCILbBPpzk50a+aNjA/b4dexkK1Wt6mkM6MJ7Oa9p29cMX4zogNHffx/iKFnK/uu2doX5xr1Wr9LSmbceVmFxl50y0ukwW8/vLO4o6BzwvkVR55Z0OvDIbrZ2jpO5Fk9v08R3vpFP6GuQZGrAyrXJqieXvqInrEu+z23fHuOyF+siZs8DUhd6AC7e/8201DRtxHxKFxwY/0Pv9t6OpdDsJ7qX13PCFx50Lj4VXUQARbk8248vpUr/nUMUktr4kUoTK8Cvu4rxoIO8J1pLzPKM3 N0QJlUSc bBG7uXXuoozI5QJJUxMZuQ5iIXv9zqJj9G77SXNSEOg1FWJF1rtRpzhNiG3/vS1ILdVpQQzytqW8lvJq2R9alhmeMFv0wqKL+IZVDod4Gx4dqj4/A9DNnFU7zo5zt5v6fLeGJe+opOuP0+zli+dObRaSOsnQ7khkHzVqZ9BkrOV0+r/6znbQdWW0n0fEp5FmX+BcmpYdrLI6A2OwApAVfFOgYxLsWPVwpg1xZvLsB2NMiTT4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 11, 2024 at 05:56:37PM +0100, Robert Beckett wrote: > > given this ~9 year old temporary fix is still in the kernel for the > Apple device, could we just add another device specific override? I > could maybe convert it to a quirk that is set for them both (and any > future devices) Sure, that's an option. Do you want to send a patch? Alternatively you can reply with the PCI VID:DID of your problematic device and I'll write one for testing and consideration. And just fyi, there are potential performance implications for doing this. It's less noticable on higher latency devices, which sounds like what you have anyway, so may not matter much for you. Just getting that out there to avoid any surprises.