From: Keith Busch <kbusch@kernel.org>
To: Robert Beckett <bob.beckett@collabora.com>
Cc: linux-nvme <linux-nvme@lists.infradead.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: possible regression fs corruption on 64GB nvme
Date: Wed, 11 Sep 2024 11:08:50 -0600 [thread overview]
Message-ID: <ZuHOoua40N7id0aL@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <191e203fd17.118394e2d1606957.7379866259983341167@collabora.com>
On Wed, Sep 11, 2024 at 05:56:37PM +0100, Robert Beckett wrote:
>
> given this ~9 year old temporary fix is still in the kernel for the
> Apple device, could we just add another device specific override? I
> could maybe convert it to a quirk that is set for them both (and any
> future devices)
Sure, that's an option. Do you want to send a patch? Alternatively you
can reply with the PCI VID:DID of your problematic device and I'll write
one for testing and consideration.
And just fyi, there are potential performance implications for doing
this. It's less noticable on higher latency devices, which sounds like
what you have anyway, so may not matter much for you. Just getting that
out there to avoid any surprises.
next prev parent reply other threads:[~2024-09-11 17:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 18:34 Robert Beckett
2024-09-09 19:29 ` Keith Busch
2024-09-09 20:29 ` Keith Busch
2024-09-09 20:31 ` Keith Busch
2024-09-10 9:30 ` Robert Beckett
2024-09-10 17:27 ` Robert Beckett
2024-09-10 17:53 ` Keith Busch
2024-09-11 16:56 ` Robert Beckett
2024-09-11 16:57 ` Robert Beckett
2024-09-11 17:08 ` Keith Busch [this message]
2024-09-11 17:17 ` Robert Beckett
2024-09-10 4:24 ` Christoph Hellwig
2024-09-10 9:37 ` Robert Beckett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuHOoua40N7id0aL@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=bob.beckett@collabora.com \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox