From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95A6EE498D for ; Wed, 11 Sep 2024 10:22:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA43940025; Wed, 11 Sep 2024 06:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B79D5940021; Wed, 11 Sep 2024 06:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4174940025; Wed, 11 Sep 2024 06:22:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8752A940021 for ; Wed, 11 Sep 2024 06:22:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D4F3AA15F8 for ; Wed, 11 Sep 2024 10:22:23 +0000 (UTC) X-FDA: 82552067766.03.A1188F0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 1F829C0007 for ; Wed, 11 Sep 2024 10:22:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MbotaJ9v; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726050089; a=rsa-sha256; cv=none; b=Z4HoONReop3rWZWuhpyFTINLniME1BJMlCGJmIEZ7OpNVvZJpMnxJ8VRWbWhnDbud1TdRM wUghv/OdLZJeAm+udJLkgNbp5FToQ51NL+GH67jwbYepaxbv8fvfcb3hKbhIL/FRlMk8a5 WQYxJIlU78nM+W/DdeFAgeqn5NeKwxE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MbotaJ9v; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726050089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gilhAcdrA7pGmi/s85r2gM91YcnlghiT9xFnkSLLu+Y=; b=aRzdKSu2j1ZCDmjwQ+arIL49f+SyOPL7nwua0897n1nUw+IUGTOSyBsrEft7vGfuOi1M9x 2NI9dDwR7feiVDf6WMcPEYh/Tv9lhcj+mhC/0Z4fBjyLH/+MalyLX40MxemkV8ysgy792j mdolQzjEONAY6MPrku3LYO3hjZCKA6M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4C9715C0235; Wed, 11 Sep 2024 10:22:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6640EC4CEC5; Wed, 11 Sep 2024 10:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726050140; bh=8dWUooDoOxWC7Oca2MrJGx9YGMSeHFyGIMo9brZfk4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MbotaJ9vmctcoaZuCwWhMhi9fy5FIYS+b/HAYEruiQzbymZobfKvo47gbwbW+fy1t kmLvVspCoENf4YJ7MG6qyNvTNAzqVaH95FS48N7vxf5HH4w5x9HqfrCJhhZOz0qSYT FD4o6UXDBrwti0gG104xpdNn7cPukgyiIL3B2k9CSxzBbiHil9QxdJScuV7IplHt5W o1J96IBLlfPsULekNIV4gsIz3YvGb3R5Lz6mZ8XITZx+iA0s8RnjfUTf8lq+EpquOb tNbpjbzeeIR2Bev+q9SOEtahsme33D5y9Lo7KW1fhsL38m9Zfs1kaXRBBkfiBGmn1+ HGqEyFiCasPYg== Date: Wed, 11 Sep 2024 13:19:07 +0300 From: Mike Rapoport To: Steven Rostedt Cc: Peter Zijlstra , Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> <20240909092923.GB4723@noisy.programming.kicks-ass.net> <20240909104940.71d8464c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909104940.71d8464c@gandalf.local.home> X-Stat-Signature: 1axbzzyw5qw9yx8ophx6kafqnzh6388o X-Rspamd-Queue-Id: 1F829C0007 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726050141-166695 X-HE-Meta: U2FsdGVkX1/vXtVkcwx5DYszbEjnUhiUCdjFRpWAOaKGBz+tYEeINAbRmdk1nfKXOJUR8jWgxc8HIR53Rb+EOVU7HPd1B6T6E/TUs2k8PyJi0aPvEDKvhT/bThhzucM36FVgb+vH6E521yUOk1LB1Aj6EAGCngEYkATgqfiXkN8B8SjFzFwj31FGybE/JphKBePTe87Emlb8ttVbvb3zK2ZiXRijvQqczdD5c40eQ9tRnoCOdjzq/wdu4DDhmMzc78Ep7hfE7yKAg1Uv4HLw09yCZu4EIdBwJt0Lt2dFG82y+B8fdQOzXxYLGSF9n5WLd2bAawTKXGTfmz1yN2nAGRgEJkK4yym7jZyDkt5fUajXD5EPJo8bEgpHe9aUg0ZH6Z+Q95KphDegef72xLvv7KIIU8k07otmek3FQhE1BGh5dStg4wt9gqWe6uvogEO3egwJ+QdFR25tFWKNZru+4e1RAYY3Hhzq7QDA6dwjvjfLtqx6/3jN7jnAsRFYxIyuR8YhVTuJ0Zw6if9qLeu83lW6UaPVimehKjwdOKx4XcLTgtMUmw0miayMDCgZZQ8Q3wkY7wXVfBdELdYDsyFK4xrHVkTNJJ71wDEUaZDHZDVWUo4zm5MwHuJq4sYqus9SPMGsP26khoh2YhRjtjXMuv+KBiefgaQfx6EHX/N52ijmwycOcVviw/Tg8/o4wyEn0x6BsEYznitDLs1tmTt+1gN75b3qEqyBSVqEmTkbr8gtt8YczIuWVJFlxfz61uXkbzqg+WmIhb/gx6SXGcn+oKwKmfmM7Wxx9/X45hwVUA1AVOY5BSwLfFWsR1BVFZw4JFuFClswKG26MNeJBca7uPnEAd0KAj8BzhGCUvZYq9uhT3G3dtc8Goz1eQoTnx+e5WNtipawdGFcf++L5q+9MM/4l4+CFoh/O60mkZ7uXV2mQhID7GsZyohtkC7q5do7gcJKZKTjsabjJ2EoLxX 9VdJX4DH /dZEgp5HQGG9PGhkcTn7nS/LAVq9/HXZgpSMRrDJ2YYSwIvHlaQmZMnuHswDtGv51SNaSj4mBa/bCmKDv0lgjQBvyZIWcQKAmk5pTuyhqapQ/NaQyu75LU2AMhYs9JInfAX/+V0h/7USUhIcfzbn8lyiA9O6BkYzc3trenizv6PJS03fTKw0WX9CBnSRziNXJiebYUp+2MGiiY0/yxSsfvaX/U89I180eEiV30YdueT4iHoyGqfQ670UFm5en2BTNWiRYDGlzvHT/v4VCc/6Tz+VOTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 10:49:40AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2024 17:34:48 +0300 > Mike Rapoport wrote: > > > > This is insane, just force BUILDTIME_MCOUNT_SORT > > > > The comment in ftrace.c says "... while mcount loc in modules can not be > > sorted at build time" > > > > I don't know enough about objtool, but I'd presume it's because the sorting > > should happen after relocations, no? > > > > IIRC, the sorting at build time uses scripts/sorttable.c, which from what I > can tell, only gets called on vmlinux. Regardless of the tool, the sorting should be done after relocation, no? But isn't mcount loc is in data section? Then there should be no problem just drop this patch > -- Steve -- Sincerely yours, Mike.