From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6B8EDE9B4 for ; Tue, 10 Sep 2024 20:04:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83E368D00B5; Tue, 10 Sep 2024 16:04:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EDE78D0002; Tue, 10 Sep 2024 16:04:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD0B8D00B5; Tue, 10 Sep 2024 16:04:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4D1B98D0002 for ; Tue, 10 Sep 2024 16:04:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E4784140B00 for ; Tue, 10 Sep 2024 20:04:01 +0000 (UTC) X-FDA: 82549904682.23.2EA8C1C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 32B36160016 for ; Tue, 10 Sep 2024 20:04:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RbOSDYcf; spf=pass (imf08.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725998503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OBe/0vlaY3En4HhQ90OZjUX+/Rp1Zw08W+/RcEu0Kuk=; b=GLLXfp/NVv1ljHHrUKoYdaYLniBtel6l3WPqE4E4W9aZFlUACuadgDwtLaCr/BkOAH0QKS HqnZFlHXulRSsWQTn3wOGk+MNM8jkZVbCILyYu0rApa3kAUFNUbKnfCzs1+lSZCXMJWpy1 NnV9Z6TPfNdjtAA8x2Kcafrl0bfDzsE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RbOSDYcf; spf=pass (imf08.hostedemail.com: domain of tj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725998503; a=rsa-sha256; cv=none; b=YrsO3YlqQc75r2YGE140DC+mqLPN6bDSLctXv8tD1raKeiMwxnQud84xIMaV/RmpdqZJQC AMJxrkmJXsqkhJ0eVIM9xxTp8UpJOJMBeMGLriDunJ2//6TWqCIXWaTl5c6RX7DpnJCxE3 O6mj8GszvR0Tg3jm3xzHDEX6btwfI3g= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7D5A05C0348; Tue, 10 Sep 2024 20:03:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A830C4CEC3; Tue, 10 Sep 2024 20:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725998638; bh=rA7a3lcUg350+c2co4v/s/uUSnMAyYuo/DyHMaSivDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RbOSDYcfhXay69roObJpzt+I7PcTvh+KovcxvKHzXuOpHtqVKbSQpJ8hetx5BMms7 z0cBkb+Jcif9VjgJGGGyMDhq2GSM3WNg6iV04ChqpDdFPPfYXAfK4UASDoWDW0F8FL epNA0gA1RXSmnN1BgAnXYXhtjr/CQobI/EzrkDZHwVYLNjalaoclThJnsR/K+uakdf zg3wLPNJhz82WJSEsKzjozLzeK0dUJqAAtsQ6LqddvP403YXkRkjY4tuCecDH4hTNg Og71JycRfBk4d7ZEw/mI+BE2r/n780DqbAsc6563aXS9ZOwP9kB7U80wmkO1+GluK/ sLh+x+3YGR5fg== Date: Tue, 10 Sep 2024 10:03:57 -1000 From: Tejun Heo To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Chen Ridong Subject: Re: [PATCH 3/4] cgroup: Disallow mounting v1 hierarchies without controller implementation Message-ID: References: <20240909163223.3693529-1-mkoutny@suse.com> <20240909163223.3693529-4-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240909163223.3693529-4-mkoutny@suse.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 32B36160016 X-Stat-Signature: ez88z3yphfwky85woodw6gmigosnau4a X-Rspam-User: X-HE-Tag: 1725998640-954923 X-HE-Meta: U2FsdGVkX18AjqwQAIlq8m09hUTK3QAfjdd3N7p/jEm62ejKivxi6jul1tVfyxhcemEVc698U4cjj7ovfJMmw4bpJ3gRwplc84V9wk8LYIxe8rVtdVpix92meYLKuO7gIefiOEjKyIMRpMLoI864zE0EfrK8meTt1p6qaNWUU6jnK1o5jqc0FvGw7fbNU32Qw5qSbyBDoFTkONRevO6BPJ+Fo26UQl/42Zcj5H5usugK/AdPS79/6I0RCZcN2jK3QNayJpQHGYRWYpnKXgjhkHLQEuf244O9BVwtWIsLkoeb1ahMLzejNI7jofC2CDndubBbTDE6aG7hJaywsdUoYuGyg4wBVOTOWDbaq5NWLzxJ+0HUHvEIFhPmVUWVb1A/YbVg8B3H2m0RABQ/MpvtEonKZDu4+YpXtgZFBVGWzOoVTpWZyvSGDqZ5hfqrekNejkuFTcFVXc/tnLsse4I3vk/IO2aFdL3RyXs9ZxT7Pz3JEn+0kLd8KHaqJXahMMXjyf+VyLvRrHG20jdOAVX8kbw5bAqDFlOKOuRpj3QY9/1jOZGsLHN++NJ+dVq4cWG3aKTEb8gOeeyLrJEADybkCIWli6g/+cw17RO4nxT/tVenV03e9IEAu+iuki+LRttX12Ig8ZrjcMQca4fVBSOfERVJ8RM5i6lWX/yuj6AAm8PXu7DBxCVooVixNB+u4JPYZ2dMrWF3kICwfsXHUwnofvzY7ADW1qLXxXBNkU1bKxWgSBioU2D34YuHWv8cTIgrLZCTf3rYPRqYoecimxqySD8MvGplSnwU0EBQ5mAiNigXy3bgR39BLcpt+SxMKs1Jf/rKIkMY414byXJ/hrCcpSHlpRan8y8v+lBhldx686zcl+j/wKFo2HsM0Weo/dB5fVj4in5eXRygi4nnLLaFYoqHj6ku6DAKtzu3HrSsT08//HxlYaAQFijufa1dpmhU19s+lXAh+SyLAKLzAcR uk/Jonfl AooX4v3OZjDPgZUFSNznj4DS2BJCGCwCdnu0etkP2KWvn4oLidQLkjGVqktJ+DsGqZpim1XQoWMOR2LN96xqBBeryc+Or0LvICs3jkP8HPAE4weloIXRnxHSCRbvlF3rF83qDRI9HKZj/AUMMva0HJ6jtqiEI3UZF11k//4jBx8OU4cxSlxJ1P4KpXORugCuHXxKYwrek5oU4s+zee23PYdeGvfbvqL6iBFpnw0IDdUcl1LcR5ZUVgS4Yjlaaxr6dKax81MpW42Re1Qp+vlmHqWOCi7+Siuyz9DgKzzuSbZcxyAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 06:32:22PM +0200, Michal Koutný wrote: > The configs that disable some v1 controllers would still allow mounting > them but with no controller-specific files. (Making such hierarchies > equivalent to named v1 hierarchies.) To achieve behavior consistent with > actual out-compilation of a whole controller, the mounts should treat > respective controllers as non-existent. > > Wrap implementation into a helper function, leverage legacy_files to > detect compiled out controllers. The effect is that mounts on v1 would > fail and produce a message like: > [ 1543.999081] cgroup: Unknown subsys name 'memory' > > Signed-off-by: Michal Koutný Applied to cgroup/for-6.12. Thanks. -- tejun