From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD83EB64DE for ; Tue, 10 Sep 2024 13:29:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD8738D006B; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A881B8D0002; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B518D006B; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 768248D0002 for ; Tue, 10 Sep 2024 09:29:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 243754039A for ; Tue, 10 Sep 2024 13:29:26 +0000 (UTC) X-FDA: 82548910332.25.BF402B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 8133A12000E for ; Tue, 10 Sep 2024 13:29:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hHcAaJRW; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725974828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8rFg63Jl7MlR24R4AjVzGVms+1c1GbErqlANfL9Jfjw=; b=zjcMGkTcoGL2ZE6O7R2t3PnMMwfK0lOMwrqA2xIJV0mMXaPbm7PAFk9aS0dBIMo/HNKiWZ a4CwsNQHPGASjfaLn5O2DNkJArtN5P2M04gXXEHqlnHHhUR+zIAf6H5PnkVuutxIqeZmbf rd7iYnzv+J3PrCYgMta2HKyczQRSCyM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hHcAaJRW; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725974828; a=rsa-sha256; cv=none; b=eILgXsG5utHWX5+zeX+7+MwYZFKY02oPU1GTaVjuhRdB7NO+BhJkp5/uiOht7V/FME1hGT FZ/jVM83l0BnGPC5ipjJ+l56ENnCDkXTP9EYfmwroEKgWc2CQ/SkKC7vRcgwUOj2SgpX22 vNJkj5Iiw56ji3eyniFy8DYlpH7Qu78= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EA5555C01AB; Tue, 10 Sep 2024 13:29:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 478D0C4CEC3; Tue, 10 Sep 2024 13:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725974963; bh=yfTc6oxpd+Mt+p18VAYXcuhQze32Z41xBhz/NewZGsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hHcAaJRWOUGEdqWKky0WxlBtwVlBuQ4xRlKQg3XW/F56aFVNmtFwB0FQoyoTfcVhc bNMgw93N7sGKydI3ORmARKZVAeFZSx9f1euMvNZxdrv3UIni7Qip+d2ps0Tgaj7XSk xy3TgGFs5xdsI8v1EyyQNP1wG0VNzBPsqR89lIvW8Uv/Sjwzzs/b3YFnVQZijJfA5a zrBe5rVqFPs/Sk0mXY+/WHlkYUvqjr1qP72vOMDifVNp4VRE9f/H2h351DfaUfWdj7 kEvH+sdp6ZmvQpql1pb/DQDPfGCK9mmRYY89wx/US+4zer5VLu8CiZcslHQ7hPbIm7 mgU97oyquwMeQ== Date: Tue, 10 Sep 2024 16:26:26 +0300 From: Mike Rapoport To: Anshuman Khandual Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Ryan Roberts , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Drop unused set_pte_safe() Message-ID: References: <20240910090409.374424-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240910090409.374424-1-anshuman.khandual@arm.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8133A12000E X-Stat-Signature: dgh9nd3iq5hq6tokyuxy5rs1jn7irtby X-Rspam-User: X-HE-Tag: 1725974964-880849 X-HE-Meta: U2FsdGVkX1+LwYFMqe3STrw/d9nxvdqpq8TQtpFsyXQd8qeof3KfVxRBVZUwENPmqaySFkg+ZPPaTLKjz5GK8wmMAnMI4EBRrWahGhVwjyPFrspKZJXxGXuI4fmTjnp3+dLhynCh4ugPnVxH1LcQyICTTQ2PZjjpT0YeHBR0gyr5K5razECVn+PnaB8nPuVVlwP0dGW4DxuABrM8ihZSualbSfXj74d8ujAsfHgCMuAGdq3a6q1cjPUhJXmL0uT8WLSBZ17KomLRQNrwSZn3hDWh8+Ms7e12uQrjGlID5u73FaHyJUWrJTM4gAJvQpsdREspz69AcBb7HMGePpYNz+xdKT8pjhoQxPP9uxu/TNnoMfRMWKXsOKDFArwDU8XTrn+JX5yg0UnKCLfQYLbXlVOx0aAsrxfOyCnulHDnn11vSpMUX0cBicC5rVmnBjHK9FVV/ZweTC7ilTEO8OOWyCEuUO222SljY5cxssHALy42KM3/Vv07OqTuMWuGZYIjqwF0iopRuRg76GhdnHfJGa73MCVSqeULV/fi2ljaTiAzqxrB+G1g9IwNSsQxRmc1XISTy7Y3raM8KrzWegVDFQpwxk1fUIUXGGTi1a9Y6X+MygZy5yHwBei2me+iMEPPflgB6ipHwSeX8ua4lqCiOh/+b8gdy+6rdJVU4Ej/+WbW+3EPz8SednSJRnHfn468uWOJQ1q2DvJM+epuMy3h7fMxJTEoTFJuKfbXK+diWFIGevLmiEV6zHdNbfNz16Mq2bBMnOgY/B1wwUfueQuvNjjGYEI6ZcP8ZUPyLah0JqkH+n4aHQnNwYzOU7Hdz9N5dRfagJRElh8TiOejJc9bX2DOJvCsW08MCYYIRR4wPNmMtByqb2nYT+ViXn4XTCpqCq5PZ69DEumlLEoOFz0OWNL5xbkmVQHlNDAs2hJ4LJfpjrQaESSJyEC+Vw7v+acqYOOyfXtWxjpJWuDa1SR K0siy4rt 4pBS3YbYOPOClx+AtPxNfxomusKA3N7RKttMvVpR6BlI6W2cbWTmUqPANZL+pkt8GhfQkpr+vwuukCwZ2KtIpk5djjYOsZozQYdQShNy0Wyxd5aDeEeIHGcsMOQNKP9/CDDdsFxtBJIG7Ra+DqRHC47GAQy6UGMKO/1lwaXlc2gJo5swFutGU8cAjHpsMdIKhTv5wNJ7jXEDAhxQ6EW6kwq0A6Iixyq3nnhsdwluAzv/JUGWsUMhQ8gMsGTzYQ0ZS0LEMpshvKaOa6xtYPRZyhUnF92lDL1l9BMDcl+bMDAI44cZ9lqdvdyzuLoPRE1EQhzfoLgEOx1QqmC0BO5zWdYW89N+HC9HYGd8Xi9wZMW08QLyEQIDD262x6CNYRMbI6oSwaCixbRX2pPGtdIFhz/x88YT6GkIeOsioQeRJe6m/uZtVfWcZyixQuVXslp+zuJyIrHICPcYjYZ7N9ZglLkRTs9iPNVpTNiuF/iou25aGJTS01Y4dbn//aH/AL71Oj8ooeCSnqfuJEdw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 02:34:09PM +0530, Anshuman Khandual wrote: > All set_pte_safe() usage have been dropped after the commit eccd906484d1 > ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page") > This just drops now unused helper set_pte_safe(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Ryan Roberts > Cc: "Mike Rapoport (IBM)" > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Reviewed-by: Mike Rapoport (Microsoft) > --- > include/linux/pgtable.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 2a6a3cccfc36..aeabbf0db7c8 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1058,12 +1058,6 @@ static inline int pgd_same(pgd_t pgd_a, pgd_t pgd_b) > * same value. Otherwise, use the typical "set" helpers and flush the > * TLB. > */ > -#define set_pte_safe(ptep, pte) \ > -({ \ > - WARN_ON_ONCE(pte_present(*ptep) && !pte_same(*ptep, pte)); \ > - set_pte(ptep, pte); \ > -}) > - > #define set_pmd_safe(pmdp, pmd) \ > ({ \ > WARN_ON_ONCE(pmd_present(*pmdp) && !pmd_same(*pmdp, pmd)); \ > -- > 2.30.2 > > -- Sincerely yours, Mike.