From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009CBECE564 for ; Tue, 10 Sep 2024 10:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 894B58D0053; Tue, 10 Sep 2024 06:10:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 845B18D002B; Tue, 10 Sep 2024 06:10:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70DBF8D0053; Tue, 10 Sep 2024 06:10:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1705B8D002B for ; Tue, 10 Sep 2024 06:10:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8BDD01214EE for ; Tue, 10 Sep 2024 10:10:06 +0000 (UTC) X-FDA: 82548408012.07.E9837F7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id BFA35180002 for ; Tue, 10 Sep 2024 10:10:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jkMysAmN; spf=pass (imf06.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725962903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ToHfxJKUDW+fB118lwo/I8pw2qWsaWqyNmDco0o/OMo=; b=M8T53Bj0WNLyYO5AkQ9XLwWM17C3ULOiU/rOcwN2PLLb+WMwRsfOvzq7WI7dStg5rt79Zr YnJm2D1HfN9mBVRDmREvgITOdlWusFp7nGHSQkhMei+hQ12o0SANkZd/wdKdPM2imw2fSZ i9CyNnu7ypr/4clKWi/JymDqxE8VNBE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725962903; a=rsa-sha256; cv=none; b=pmSyRKLwn1xLhDZE4XlyhmZHGXWuETqKKzGk3XqotjJTP7GZFujlRVVXUfO0xL591GZlXl B+MMmVGW7XzFYNFq+L4jtC5bGLwkaTHQxMjP697ojjcBVvTahDgB4X4gW3dgY8lJpTIB71 UuahgvMpDFUr7vMW/AaXW7XvG69+9GY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jkMysAmN; spf=pass (imf06.hostedemail.com: domain of dakr@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2858E5C068A; Tue, 10 Sep 2024 10:10:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EE6AC4CEC3; Tue, 10 Sep 2024 10:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725963002; bh=qci39d1xKfJDxp/aLwjtEh2USiUe2UEO295o+Qvvu3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jkMysAmNcyCCTeplDafB2PHC8Ir3R5Mi55t7clWLtj5hWoXo/2YOmJKj+8VgDo74r 0pwlRQlZVKy9QazVzJgHc9ts+iabrDESOmsnyNIoAbs+55qUgQX4B9yRQaiHcRsqW1 NNa5uynyiPhzVrVT+JagutlmHcgU1X78tbR/hTNCP4pOXpeZnXqb2YVJNdlEfLVyBe OKZ943uHnucygqL+smpLURNUQP6on9fse9UlMtYHyXHVRjoF+fSWOOVqmGzvlR5q/S nJAy5nUN5DPKwMNEPspCZilUa8HHnUv0LOKpg6gIjoNxdLwG4lSXNoU0Dc31mv9YOw VMmuD9QGsBGuw== Date: Tue, 10 Sep 2024 12:09:56 +0200 From: Danilo Krummrich To: Feng Tang Cc: Vlastimil Babka , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Marco Elver , Shuah Khan , David Gow , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm/slub, kunit: Add testcase for krealloc redzone and zeroing Message-ID: References: <20240909012958.913438-1-feng.tang@intel.com> <20240909012958.913438-6-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909012958.913438-6-feng.tang@intel.com> X-Rspamd-Queue-Id: BFA35180002 X-Stat-Signature: 3191f1m84ufgw5i31h4pgydyot9ytotr X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725963004-330253 X-HE-Meta: U2FsdGVkX1/lFqs7wcwYWjLMGu7021dGInDZVW8G8zypFVgB4HxoZW6Hgoilo7k/uWxd+LCOp2fmW+Vc2TUcDFWfASdiM4+LcaSyoFWaGeZ77ampj01+HyEeTdVARzS6XvW+DbLqJqT9SdG1gHo1U5vxcXYh68f+OeO3uOsxPUDFUrVWeE64msLHG9sK97tKMXf7eKhXLd9oV16p/CXRj5LFCzOcLrdM1GLZOL/NVIg+YxhMidlkBUMNd//wHpQae60TbEC+CKVBkDBqR6L5D+chHBFdfHXOu5RFRA+x6ZkVwM5+2x5AzZ0JwApbfmnMbZ6/uJ856Y/48QUS0gMlVXGzNM4WzWMy5ap8od6DVlyBgXVlgkWGJDltIdkmmBlijTOwQk8zcuGaz+e0axM+6uoNJPMRWn60NG49g5u9XJilFenkgrGK4IapsxwBRpUMcJ1rqmHxEebL53OKdsD78iRkevc45X/iyyUsZVgkb3YRiEQOA93vuDoQWvrUMk8zKX5YW2VLu2Pl293JhV3i8wL3EhSqSFFWYh65LX0U6HOjxts9JMQtPwQhPfSXiddsBAODsm1nxCEIHHxdjSMA63Oqf9oGVkqdFSFI0MYLw4jwoQo8+I2lieWiLVtrZz4Qy9YkFMeHXLSILTR/4MT0+zGYGqveMCHzuHsHHrqIdVOBH/0N977Ysp9uU6G8JzY+oLqr5w+auESTcogY7CaM2LL6f5hQ2iI3JHgl29KTAKQz3gHSzfhoD27x5bRAVAm5n9f5idIQTThwaCt3Uhj1GdEAUsyqmPNynWMxRpvas65mNypm/9IatnEIs6Cdtrnu2cdM7JslPtmb9QMlylEs5wwnVsafIOLDG8CEk8/IqYJrMuBFZ02wb0pjix/RV7HXofNWFlpEGvwfixCBL+9ET7Gr5GejYq3m4BGIeBVNThDYoM6y2y48+KvtF6Yzk5J5X/xxHPb8i1T3ylU04Fj bXTFlutL Aq6NOIJYdeFPsjV69y2zjmTn2q8FoodYxlGejdhEPMKHqHfupC94+cMI1dEd1XgJ0debQxUTuavyXcgWy/RfMbQld7EC0Z3U5ci7PdswH26MczlLf25WK+95rSxUNZ4yU9/OlSDDk2S5rc4RMKe2Ft+cC52/08Lc9mZDUo6V9zcerMSrvKqxX3jZYdU64NiQfXJZB+l6YJZUKcwNHnu0ch/fYJFsYEfN0wdHSrIvqfmls9qlyLVs5vbrXgLp336KOS7w0cY9ClUs0DUhgVaA1ukSj38fFxPAzONmK9CWmfmyuMi2PeTDmMR/NY0odKg6Q2JdrRhydkD3I/DlRUuzbL0fkzk8cWcL0CPQMqPGJL4gYuyPxhDgNy9qGmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 09:29:58AM +0800, Feng Tang wrote: > Danilo Krummrich raised issue about krealloc+GFP_ZERO [1], and Vlastimil > suggested to add some test case which can sanity test the kmalloc-redzone > and zeroing by utilizing the kmalloc's 'orig_size' debug feature. > > It covers the grow and shrink case of krealloc() re-using current kmalloc > object, and the case of re-allocating a new bigger object. > > User can add "slub_debug" kernel cmdline parameter to test it. > > [1]. https://lore.kernel.org/lkml/20240812223707.32049-1-dakr@kernel.org/ > > Suggested-by: Vlastimil Babka > Signed-off-by: Feng Tang Reviewed-by: Danilo Krummrich > --- > lib/slub_kunit.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/lib/slub_kunit.c b/lib/slub_kunit.c > index 6e3a1e5a7142..03e0089149ad 100644 > --- a/lib/slub_kunit.c > +++ b/lib/slub_kunit.c > @@ -186,6 +186,51 @@ static void test_leak_destroy(struct kunit *test) > KUNIT_EXPECT_EQ(test, 1, slab_errors); > } > > +static void test_krealloc_redzone_zeroing(struct kunit *test) > +{ > + char *p; > + int i; > + > + KUNIT_TEST_REQUIRES(test, __slub_debug_enabled()); > + > + /* Allocate a 64B kmalloc object */ > + p = kzalloc(48, GFP_KERNEL); > + if (unlikely(is_kfence_address(p))) { > + kfree(p); > + return; > + } > + memset(p, 0xff, 48); > + > + kasan_disable_current(); > + OPTIMIZER_HIDE_VAR(p); > + > + /* Test shrink */ > + p = krealloc(p, 40, GFP_KERNEL | __GFP_ZERO); > + for (i = 40; i < 64; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); > + > + /* Test grow within the same 64B kmalloc object */ > + p = krealloc(p, 56, GFP_KERNEL | __GFP_ZERO); > + for (i = 40; i < 56; i++) > + KUNIT_EXPECT_EQ(test, p[i], 0); > + for (i = 56; i < 64; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); > + > + /* Test grow with allocating a bigger 128B object */ > + p = krealloc(p, 112, GFP_KERNEL | __GFP_ZERO); > + if (unlikely(is_kfence_address(p))) > + goto exit; > + > + for (i = 56; i < 112; i++) > + KUNIT_EXPECT_EQ(test, p[i], 0); > + for (i = 112; i < 128; i++) > + KUNIT_EXPECT_EQ(test, p[i], SLUB_RED_ACTIVE); > + > +exit: > + kfree(p); > + kasan_enable_current(); > +} > + > static int test_init(struct kunit *test) > { > slab_errors = 0; > @@ -196,6 +241,7 @@ static int test_init(struct kunit *test) > } > > static struct kunit_case test_cases[] = { > + KUNIT_CASE(test_krealloc_redzone_zeroing), > KUNIT_CASE(test_clobber_zone), > > #ifndef CONFIG_KASAN > -- > 2.34.1 >