From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5796DECE582 for ; Tue, 10 Sep 2024 09:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1BE78D004D; Tue, 10 Sep 2024 05:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCBDA8D0002; Tue, 10 Sep 2024 05:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBA4F8D004D; Tue, 10 Sep 2024 05:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC8DA8D0002 for ; Tue, 10 Sep 2024 05:39:01 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 50E808112C for ; Tue, 10 Sep 2024 09:39:01 +0000 (UTC) X-FDA: 82548329682.12.7DF07D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 80E5E180007 for ; Tue, 10 Sep 2024 09:38:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnZDZxpm; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725961037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jg80v2sHYr9jxVuH+ZibnLi+74iJM1iXUQ8iFd11kAo=; b=wzcRGGdb5gUruXmTzAO3QprFE4y9n5x+umZqYTjhdB6xcp65URNmaYuopDk5B1PsURABPP AGfgnVF/4/OUWb3RAAQZnTvTqUKrgyjWaiHjow9kx4+AG4BGlApMnI84cqzaUUuaBHy2Vu xR4qdqU6VnEPMaZZ2WS4AuknEC71ejg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725961037; a=rsa-sha256; cv=none; b=qtkzWeyhyNo8fA/9wn5ykNHFrVATu/KiGU7bhC9/xDsWtDZE8k8245GdJQI2HV0UN+b/k/ tVhpN2DpLUOdIMW2+stKzj4zwRNax0Hmu+22KZHeZz3yKHDZjzzxWE2e9i6cvQuCz/nlKD ODnp+RaF5Su4dpVYkcOuqYPoAyODBjE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UnZDZxpm; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725961138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jg80v2sHYr9jxVuH+ZibnLi+74iJM1iXUQ8iFd11kAo=; b=UnZDZxpm86wc/MiN7N4pAjCLvac0d6iidLkmzajVdgMnawJ3rg3HvZqyr6pJi4RSa1QY2x 9AY4GI3w/vl4j/eWIQDxjuWj/vt8g4cT3OgT5KSAdjVbugjvcQCg3J4xd0YMLZiIizV5JH 66View48aPLFk86I/mQXfPLmspg7SDA= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-2G_Q7nXqOuOwOzjcoc0RYQ-1; Tue, 10 Sep 2024 05:38:55 -0400 X-MC-Unique: 2G_Q7nXqOuOwOzjcoc0RYQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9359919560BF; Tue, 10 Sep 2024 09:38:53 +0000 (UTC) Received: from localhost (unknown [10.72.112.58]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 351951955D44; Tue, 10 Sep 2024 09:38:51 +0000 (UTC) Date: Tue, 10 Sep 2024 17:38:47 +0800 From: Baoquan He To: Uladzislau Rezki Cc: linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Message-ID: References: <20240906095049.3486-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Queue-Id: 80E5E180007 X-Stat-Signature: f9ixse9nypxwubjcrtxz1yf8fbeukbjm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725961139-468604 X-HE-Meta: U2FsdGVkX1+h/QLmmUeTl64AyR0jlmffO2JXHyzbQjJ/uSy1KvLQVPbfjBO1asTXX3EIbTo5urCbtiGGg2SDGuczsin1yMPBRdFlM0Qy5PjAqGzXnUI92IZjeTjTbtai3MFlbfwzltYgSxMcukOrHSFMsK0m0sQRsSznmLhf6sGamSws30GJsssqy1ZL8RwrgDpBangUOK1JP9yMIv+95Eivm5fhZe6G0b+gGStfPT3BeMqWs62ipMqDLA5bBM0FATZNLfH6QzdV8cywsUYGkGGFKcw0LSkxDw4ck92zCwWtsTDaiMCIlHYkgNJkU/rAGea0DYl7v18r6S/yeiUllokE0KIDShiRdgIUh8Y609wJabKPGXaeKyyVcjQSuan78K32zxzoqbet/j2eLdwlmWdVkdGd7tB58XFj7uWyWSu4RdPgnA0tepiE3TC9L2+z5RNwKYRvdiHxASdVVxp6hfUCy5DFSC4LJDJiZFUeXBqF/N/Z/qwhXl+qf6QYHcjfvQe5WaturQ9p71dvkyicmSdtVynXyAwOrY6/wOH5QRVodd7fdEDE4bv7ZB9O5HQOuvg0/EtlupjMgNNLQSjf24R/45aWtx/Bh863xSYxPIalAvf3YPZQ8WKyA7FiINiEEDJcaJA0g/outQyNocbgu8OJQHrIb6M5/hpaAQWG3etyg91kwbCU/0Eb5EsLH2ZivHWhYV3mqylPpo1fa3z05/SjjNDcyNPN0tHwJXGfErD9hdua0cOknmG+iy2U0pkjIxeHfOYVk99Y7mdILBxrlDR+8gv+kitICKOsF4LE/YZWCAo+iltV68PsCvNvxwOsChmwviIzOUqpKyIuRLoRYd0NNaXirt7LjzNMXuHPY3ZSRmAewpfFwcZRCLHW7qb2F7WwNOqXUwteRg86P1GUk+u8ZhErXLxAsuD1x226GAhRiAsxHMK5aGp3L2rVZvVU3TkymvEW79jCGzBzYMO pmufTljP 2Z+BuKRz4Orqo7uemgLHKODLa/wPyByqvosn5IXhpzMZRlC6uMOlxZPY1635h8o0MZ6HMsmbDeEhFM91H6bjo2cmGPhk8E9H/9zkI0YcaRMg92T7rimMoXVkjal5rIE4k0qVS2JUQBaNSvPqg3C/lhrOF2oc/UMF5TIUIY6M9103jlSQeptVfM5gAxeLTxrEn2wtAd0GYjnIOJpwWCqrOA8fSWqyx7v3l0dcUx+S57RzBFpFrCFohQP/HuyCFKpX3d8Ogto9tYB4CNbrCDfxLqnQKOKczuX7C0srJewE06qJ5Uy6umeJ75P6JF4RC22vFdJdFfpqwJlvlFABqbfXcoSXKPhr4+knJiMzg5vNfOZrhixg5sw7c9rDJAlzejpbOXiieD6wDu3Cc3pc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/10/24 at 10:57am, Uladzislau Rezki wrote: > On Tue, Sep 10, 2024 at 08:40:42AM +0800, Baoquan He wrote: > > On 09/09/24 at 07:52pm, Uladzislau Rezki wrote: > > > On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote: > > > > On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote: > > > > > In many places, in the comments, we use both "higher-order" and > > > > > "high-order" to describe the non 0-order pages. That is confusing, > > > > > because a "higher-order" statement does not reflect what it is > > > > > compared with. > > > > > > > > > > Suggested-by: Baoquan He > > > > > Signed-off-by: Uladzislau Rezki (Sony) > > > > > --- > > > > > mm/vmalloc.c | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > This looks good to me, thanks. > > > > > > > > Reviewed-by: Baoquan He > > > > > > > > By the way, do you plan to clean up the rest of them in other places? > > > > > > > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h > > > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c > > > 493: * nr is a running index into the array which helps higher level > > > urezki@pc638:~/data/raid0/coding/linux-next.git$ > > > > > > What am i missing? Didn't i do it? > > > > Sorry, I didn't make it clear. I meant those places other than vmalloc > > related files, e.g mm/page_alloc.c, there are a lot of [Hhigh]er-order > > mixed with high-order. I can continue the cleaning sometime if it's not > > in your TO-DO list. > > > > mm/page_alloc.c:551: * Higher-order pages are called "compound pages". They are structured thusly: > > mm/page_alloc.c:716: * of the next-higher order is free. If it is, it's possible > > mm/page_alloc.c:720: * as a 2-level higher order page > > mm/page_alloc.c:735: return find_buddy_page_pfn(higher_page, higher_page_pfn, order + 1, > > mm/page_alloc.c:2750: * split_page takes a non-compound higher-order page, and splits it into > > mm/page_alloc.c:3587: /* The OOM killer will not help higher order allocs */ > > mm/page_alloc.c:4811: * within a 0 or higher order page. Multiple fragments within that page > > mm/page_alloc.c:6516: * page allocator holds, ie. they can be part of higher order > > mm/page_alloc.c:6790: * Break down a higher-order page in sub-pages, and keep our target out of > > > I see. I appreciate if you go ahead and improve it further. Ok, will do later.