From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C861DECE582 for ; Tue, 10 Sep 2024 08:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5308D0035; Tue, 10 Sep 2024 04:57:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37CD38D0002; Tue, 10 Sep 2024 04:57:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DCE8D0035; Tue, 10 Sep 2024 04:57:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0415A8D0002 for ; Tue, 10 Sep 2024 04:57:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94A25C0218 for ; Tue, 10 Sep 2024 08:57:10 +0000 (UTC) X-FDA: 82548224220.23.593D22A Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf09.hostedemail.com (Postfix) with ESMTP id 9F1A3140003 for ; Tue, 10 Sep 2024 08:57:08 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kE1riCMe; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725958577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ClddBKTpFhc9CnFInwAIwrp55e49LC20yixgnWvdO2I=; b=1Zw/+v+WJqP617Ri9eOsrjfdABLPltMzhwVm9XZ8lyzbzH7NC8+4uPXkDBa2khzryrYJhG lCI0IQ7mL3G9H9FBHK1tuoRin2EASgSFjVXhLtehtrk3IAbrbFS6roe5fw9m6rLsGlTL3I 7ZgQtSL3MJVIIeYMbv4LVs3XlS+y/Oc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kE1riCMe; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725958577; a=rsa-sha256; cv=none; b=eFBoegzg+JVwZACiB4+3lGp7yB22dxOJMcmvYy5IX9ocHAMQoohgE/QLPWqSDWDhmuCjpy acXyKkI+6DcNadEOb7kn2SZUcbOg5UGFLyRImZ5mRafhXDOch94z40+a/ThYNx+9tEI6Td Hz/CtDMQDUOLYGiVcY9kkjsB4ZZqvhg= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2f761cfa5e6so31063421fa.0 for ; Tue, 10 Sep 2024 01:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725958627; x=1726563427; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ClddBKTpFhc9CnFInwAIwrp55e49LC20yixgnWvdO2I=; b=kE1riCMeA0cU6Ub+OuEjuQR4zXBWwnuPZs8/4jq1Y8Vw+dtq7lI2w9gJdG8eu1Eq4J l6SUqwg2bk/63v9gDlLCmKTntEFnbML9L14IZfgs/hUoQuW1Odj9JxHjQ+Wqlet3nYNi z4ZPuh4GLjGvdbdggfZxlyZMzTOUSAhbjY2n1GVGp6vB/GTRdXNBRqH8cn+aJ4ZTu4+C l+XVQWJaRTBtGSqioi06rqf0OZM7rLFwXju5tVJaJy5DDFkGcw/C6MZIvFr3kEz4zmob Gbo4JT/Fb7lsIFsMcyIqFSZVflw/Db7cUxmkoNI/ZOtfFwFOgTRP27HYHss3i8+28KZE JOlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725958627; x=1726563427; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ClddBKTpFhc9CnFInwAIwrp55e49LC20yixgnWvdO2I=; b=idNwPRe2898JWx4QAYzbIIChg23wmD+p/CRTkrD3Rr3RSSZ4PtO4Lz59mcESGu3Hhy LpZ2tnz8RYw+Czm+hNQgXF0SQyqV1tULy33pyRSaBXZLJQQs55plMdI5b3pxzD0tQi87 w1IJwyUXyvrpp/5O27YhzOvsnrrQMYrZkHI/l5NSjH6nrmccWwKPKQxgVKbm4m1hsX05 ccbc3qoNegPQ/Gypda/vkythOE28eyTaxBKCQBQBE0L4GW5XEvZM5fkcxWwLqB6DPaYa uvjfCMsGL4aNWxAcy0KCK/bkwpdvKZavsfuIOnIkMrLlW6imW2eZVOIipQVdqX473m9v B9MQ== X-Forwarded-Encrypted: i=1; AJvYcCUn67iByvtr8PJG7DovbbChuSRQQC+7FlCLR0Dd2uqXrLxWuC590geHI6Mt5zOJr1xXIDW0D09NdQ==@kvack.org X-Gm-Message-State: AOJu0YyRCVnxxRt+U6DITcQZaBiO33w5+ZpP/2Wb4umHKPXBESTAAN0Q KU+sGe9+ozVcdnuyaXQSZX3HsuFHgzZ+gc+D6unjwd3AE53YzX+G X-Google-Smtp-Source: AGHT+IGVMfPHMIIQj4j2shaIpBXWAYWn/aZbnyeKQoRcePoJuQDHvX+fcf4Lww69xHzmqkLALK/gsQ== X-Received: by 2002:a2e:bc1b:0:b0:2f7:5a83:a90b with SMTP id 38308e7fff4ca-2f75b87eba0mr77099661fa.8.1725958625672; Tue, 10 Sep 2024 01:57:05 -0700 (PDT) Received: from pc636 (host-90-235-20-248.mobileonline.telia.com. [90.235.20.248]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f75bfe6ae1sm10930141fa.18.2024.09.10.01.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 01:57:05 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 10 Sep 2024 10:57:02 +0200 To: Baoquan He Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Message-ID: References: <20240906095049.3486-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 9F1A3140003 X-Stat-Signature: pxmubxoxbuyg7457zh4dge3ybmtbw8x3 X-HE-Tag: 1725958628-449288 X-HE-Meta: U2FsdGVkX19cRaOpiIzjbQrTrXrpwXzsR2qhKxcNMEquT59Uxe1M+bBLvpXy7JTwiZytJmHQXGD4w4wqVQUP5iMCuibTbHzd+Wgl+dNMdp/wnZ7bMe0ClVmDSn6JHTCBQNO1ZSpy0ZzPA6UH+RNj4BDS3/k2WDh8UF/aLJerwZZ6dwZrbXT5dK/733qktIeq1eL+8HBGOOVWOTSfUgUY7pnMdIRHUx3TF2VxWO7cLIsDKpJn0Qneg7K+stcwB3e3DFk9zgwsmDN2NF6KIqg5xMpE5QOO0mx+d1GsO0tKOaP7HtwJej4BuG98Y100bIYi9AXvpQMELGdZ2788JjJGwQvqeKm+Vjqzwvd5h3tIAZrKHacUB1h9YEyEB4wIg/EUb9pRpjiqDD5fuZ2jEu89JRqJz+j4cDXhljMLfCYVZJFksdRFmF54sZmmxiBQ1cCeHP9224366xnRw6Vw/gJqEMlTWDeQOspqeXi1J+qbvVuznqP775/V8B9LSWsCfSAGVJV8mJKnCKXs8Rnyvd8inGMMPLFdvVcEcXKFx5OdGk6f7C1rGYlNfNzf3TAiieIGFGmQzdVnFfZRQBGkiGxRoOPQK7Dx+Jzho2kjJXYH6r8/dGKQKuJ2ez1YcIoCO13s+LuVG72RXYTny2WFRLDfgjTRbUBW1/TL0i1x7ZeISQr6s7dwBftgPBUOp5ab9bnbdOZMbx08WTl58ay72MQ9eC1zSFmeVYPtJ0qsDYMZSOhBKw27Cxtiu3JJNdriGMDgJb6cP2ixWvjonmZdH2mxTX5kVX+VB86mHN7aFH8UCNQygK25vC9jxgcwt5r6a6WkrKZ5iMXMlSIThpZZPWukT7MgMi1kHRhuDWMXQ3ZpfnRpF4bU5IGHp5RtQ+UDuQqfhSRJZj7ePBPsENyMcgoSCI/6vMpDGlso1qxDGu9xVmyxcOTk4NxajhkTOSmG4IledURWFgKT+S86rX8tBeU 11h4rQnO zZ7/C0F+aRHrBL4RL6nuRuTLxzlQPwkIddX6gFDC9ts9c4wJwFPTUoxCdePeqMAF5U0RK2ITRn+6qSaWvEt6l05rvSUh70/lJkbu75zM3WOon6AraCCgX1/ankdJPV395y9NcqqlQaDzLfHDGPp/fCEoxqz6aCzpJFkAWQNDfk7anSblfUjItOtOczY3w55eyoNTbsyTVI1tU32rrS2jh7d3Q3qibj0TWS5wMQWiOetaai8FS9m5Jv1jJ6lKy24nAPATql6/h/grb+MNLu9SgibO2tt9pQdHMRderYRJuFt4dlLUzZuyU4QwaMEOjD55l2oK93ttEl93QUc1oy+dyroBvX2kaYu6fR3QPLicCaNp9qSXULCn6s1yV7aLA1bMF2WcpOazqhEGSBmum9repuSQ9mYgiyhrrtwvH9d29D8b0AIjY1Cssqlj2yss9tkNsqigm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 08:40:42AM +0800, Baoquan He wrote: > On 09/09/24 at 07:52pm, Uladzislau Rezki wrote: > > On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote: > > > On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote: > > > > In many places, in the comments, we use both "higher-order" and > > > > "high-order" to describe the non 0-order pages. That is confusing, > > > > because a "higher-order" statement does not reflect what it is > > > > compared with. > > > > > > > > Suggested-by: Baoquan He > > > > Signed-off-by: Uladzislau Rezki (Sony) > > > > --- > > > > mm/vmalloc.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > This looks good to me, thanks. > > > > > > Reviewed-by: Baoquan He > > > > > > By the way, do you plan to clean up the rest of them in other places? > > > > > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h > > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c > > 493: * nr is a running index into the array which helps higher level > > urezki@pc638:~/data/raid0/coding/linux-next.git$ > > > > What am i missing? Didn't i do it? > > Sorry, I didn't make it clear. I meant those places other than vmalloc > related files, e.g mm/page_alloc.c, there are a lot of [Hhigh]er-order > mixed with high-order. I can continue the cleaning sometime if it's not > in your TO-DO list. > > mm/page_alloc.c:551: * Higher-order pages are called "compound pages". They are structured thusly: > mm/page_alloc.c:716: * of the next-higher order is free. If it is, it's possible > mm/page_alloc.c:720: * as a 2-level higher order page > mm/page_alloc.c:735: return find_buddy_page_pfn(higher_page, higher_page_pfn, order + 1, > mm/page_alloc.c:2750: * split_page takes a non-compound higher-order page, and splits it into > mm/page_alloc.c:3587: /* The OOM killer will not help higher order allocs */ > mm/page_alloc.c:4811: * within a 0 or higher order page. Multiple fragments within that page > mm/page_alloc.c:6516: * page allocator holds, ie. they can be part of higher order > mm/page_alloc.c:6790: * Break down a higher-order page in sub-pages, and keep our target out of > I see. I appreciate if you go ahead and improve it further. -- Uladzislau Rezki