From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BC7CF9C6B for ; Sun, 22 Sep 2024 00:36:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3BEF6B007B; Sat, 21 Sep 2024 20:36:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EA516B0082; Sat, 21 Sep 2024 20:36:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2416B0085; Sat, 21 Sep 2024 20:36:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6BAE16B007B for ; Sat, 21 Sep 2024 20:36:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CDD0580B6A for ; Sun, 22 Sep 2024 00:36:11 +0000 (UTC) X-FDA: 82590507342.22.546BB77 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id AC2331C0006 for ; Sun, 22 Sep 2024 00:36:09 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FjRljN6Z; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726965311; a=rsa-sha256; cv=none; b=lMsS1Mx458G4B49/sk97BfODJlQANkP/gRKQjazumiVjAmliovIQVJpIPcqnIen5p3tSmH rU55YJ3Jr49QlwFE62nUSJc6jiiEvuFLrIMkxPiQm8aFeuFeXYaaGQPADcOxs1smyx8QmK XaP9/S1E5iUMNCSOHn1qlvC8ZGmBEzU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FjRljN6Z; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726965311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XMtvylaUwwhb/kxBPvNcJGl3QJuXFbLPE2VHYOWXK/M=; b=BTS0Ksws5yXhI7duMsRjEohi+5ctWwRz0xrqFHWolXomgL1Cj1/UnCuwtSiwu7Gx7VGBzf qVs/7aGI/ak0I3E1ookP6T7hfPcbf7RLwb8r6CuG1sr6+BFZLljkfE5sff4YeP1BC8s4Yx LAopxW3hBP/WG7QRxGwDWaO/QOVaaCU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XMtvylaUwwhb/kxBPvNcJGl3QJuXFbLPE2VHYOWXK/M=; b=FjRljN6Z6a1USemY8N922JVxdM wzAyFjoq7xsZoI7wexO7z3GCyDTdQxkwU4nK7/FBIKik7q+Ug+lhBOJqUwe8WqjpVLMhhMaaPZyRc ju8CqjZppZha6L2SokGc7VmhviIrox8Yue1waTic+dnfKID2fSYJER1YazPxweVko1s8CPnFRGxYu bZfG+0beBblSFaQ+eyXDt1lzYwVz8OrCws/lIynf082lII2/1sm8WIkb2WH6JyaLKs1M1Nvod+TO0 XDb0mZu1/fYuBIzt6e9sLP83Ym2tpWaU6JHQ7alBku7EqTMGfWczVRrfztxElBUt+GvX4eVdfDeYD oZhidbbA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1ssAZw-0000000D8zN-1xro; Sun, 22 Sep 2024 00:35:56 +0000 Date: Sun, 22 Sep 2024 01:35:56 +0100 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , Hugh Dickins , Alexander Viro , Christian Brauner , Jan Kara , Anna Schumaker , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Baolin Wang Subject: Re: [PATCH v2] tmpfs: fault in smaller chunks if large folio allocation not allowed Message-ID: References: <20240914140613.2334139-1-wangkefeng.wang@huawei.com> <20240920143654.1008756-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240920143654.1008756-1-wangkefeng.wang@huawei.com> X-Stat-Signature: yaiptuh33kx3ktwfmmc9ed6ykgaoyfbr X-Rspamd-Queue-Id: AC2331C0006 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726965369-934034 X-HE-Meta: U2FsdGVkX1+nz4dosgTRZxatj9zKKidJbEJyXF1Cr9B7/vE4yaTWREv3TqMzC5MJ0RN7jeRZx9CwdMDofIXHhzQBSFmFcaCI8302ATeNwByLIQdKEyQpxQoosMzW5mvSCCb4ahWUkcd9YZUmQUqnsXubUbwgv6pLCTzwycMSRI3kGx5+Lq/y10eJpUSFBXr3vm7xp41RdV0dDwub7bjgkxRA/waNreDG0YF+o6ihXFIgW+taeRtIv2CyvJwGrcz2ko6H15mu0D/CSPUBDBobVDAOmDJmv2AltDIYywTm8m1YzGxQyr+14xQ6XR69iAWxjwWjBvPExnL0BYEazCjg9PSn2BkdG7wM5APM9bwLHNMUSrS9z9YMZTxQwLcut9e/dYGGjdg6jjuOpmRCCpUJDmTjpWVUxRM1VRJ0Fcytk0oxWT65xlrGyBYeDBEE/xXMt+wjZ5JSH5Mppmyd5BlvLda0GDEzmkKW9iMReCdHiBTXbILBkHOFKWMJRFzjkm277bYfyKfzTc6u7ZIIa4pz1XhJA/fj2+iwPgPPOByZRRpLBwvbbTLipjFfXOB+wAcBlCXWAO95B+3YgdFGOXwWOeOQWkvm2ySqVILB4iTWm9I73VyvmIY55jxakXxkmSubwFOl2VaHcb6tw4OzKmERghiQvF9L8a47pD530hVTBr5xlFjHBkGRSnHNxjYNbKOKDn3TJxQnIZ/lw7NhMSlK7laREI0OPGFBwu+fwAMFg0/oY39j0Jlew1yz6dIaa5WDoxhCqUEDWKmuMmNN9oCP8KFvWj30cUdIEPndUsctKrcj69VRxAsYV9C0Jz2PuuIyjsT3IZ4XlBFE6z2MxJo3FPYqDzl28bcu0CnTU+Y+69frPK/Pdeih65GxWbHDaLXNDeZ3uWqenaelcKsqjyi+SZSVo4KGpmXIWksQRfJ0jRxRFt0q0pRlB6Otxk3GZpDNzMbpA8bI3GgRMgLsQEy eH0dhsmN 5au5wPcQaPa7ZwcQxHfo6wd7shroVr/86ii2QBA6VBY31x1HxpQXsCF8WfQjOuItptHhDNx96FN3Pr5gzmPo44MBWQjZVznsaXvUjb9gLPZG1x81v2PU++PelN1PFvrojzGPCxao8bpXqFwj2FJIwE+0R/NCHKTijv2/e3h1YfxZchTDVu6sqtEvhC7emGtZitNQm+8h1xhWKN/6fjzRsYQx2CKKdYfg6cwuwFs95WbMxqIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 20, 2024 at 10:36:54PM +0800, Kefeng Wang wrote: > The tmpfs supports large folio, but there is some configurable options > to enable/disable large folio allocation, and for huge=within_size, > large folio only allowabled if it fully within i_size, so there is > performance issue when perform write without large folio, the issue is > similar to commit 4e527d5841e2 ("iomap: fault in smaller chunks for > non-large folio mappings"). No. What's wrong with my earlier suggestion?