From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4AAC7883B for ; Fri, 20 Sep 2024 13:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5F816B0082; Fri, 20 Sep 2024 09:18:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0EE96B0083; Fri, 20 Sep 2024 09:18:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D63E6B0085; Fri, 20 Sep 2024 09:18:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 80A686B0082 for ; Fri, 20 Sep 2024 09:18:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C6FDB4035D for ; Fri, 20 Sep 2024 13:18:25 +0000 (UTC) X-FDA: 82585170570.10.051D054 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 97FDB4000E for ; Fri, 20 Sep 2024 13:18:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=pdp7-com.20230601.gappssmtp.com header.s=20230601 header.b=svzzFgqC; dmarc=none; spf=none (imf27.hostedemail.com: domain of drew@pdp7.com has no SPF policy when checking 209.85.208.174) smtp.mailfrom=drew@pdp7.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726838211; a=rsa-sha256; cv=none; b=W17hJ+0OFGtvMN74vCS150HebutF6bsNKfbBl0tp5txkDlDAFqf/DL+dVmufZYdwDTTPIZ QwomqKHJbl+NhzZWoYV/VDWXLwqG1hb+CW9G4HUROjzlZfUlzmpeHAAWdHsQHWy3+35bGd HEtktGBCbO3qqYzxIq2QsBL6JvChg7I= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=pdp7-com.20230601.gappssmtp.com header.s=20230601 header.b=svzzFgqC; dmarc=none; spf=none (imf27.hostedemail.com: domain of drew@pdp7.com has no SPF policy when checking 209.85.208.174) smtp.mailfrom=drew@pdp7.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726838211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCr+b1uaUv6DBDhbwInFIiICgPG/Kycc9x8fjXZbOhA=; b=Xq9hQq3Odq3q3x7CTwSD2IXYSvMNljZmCGnvG1ONU/0sIrl2Hy0UOlgw+F406M5mK2amxl gxSW8r3yjxfg5u6sqWMcoqP7VW6Kc4PkkyR9HF2SR5gGIJWo/HCV2PNxdETNuMMR0aVR80 PKehc+RAmFuGIkNhgJjW1WCm9nTc6qU= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2f752d9ab62so21408281fa.3 for ; Fri, 20 Sep 2024 06:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1726838302; x=1727443102; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bCr+b1uaUv6DBDhbwInFIiICgPG/Kycc9x8fjXZbOhA=; b=svzzFgqCeswB6iQHIlP6sAuoKekOaBbe8vv/JmnHgGjBNzZCBW7EPhzUIC177AS8XI bX0/L/XZEwlabnzjHdU3E6PMGCY7u2zIUmyPd4vqdMqyEJ60FDQ92Gy8nGh0Oya0G4AD WIp3k1LVyuvc3xXaQ+J7Uou9yQE84/zkdL6YybYTztGidq3ATdFYXsIcZZOMTwU99ei3 57IhnW6WUnOSETEJ91NChihB28Rx+Kfwblg7WlNnllt/h3JTIjBPCZ8U95eC3KrmAOJ6 2B/dD5h9cqf1jtzma85ZpQG6ULLcZ6RIETHWT0RxbAioRoSDszX7jGIFLphDA2TeAIoQ QTtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726838302; x=1727443102; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bCr+b1uaUv6DBDhbwInFIiICgPG/Kycc9x8fjXZbOhA=; b=v3KTAL6kLpWmmUdC9KBDMaDjML17EJ0YeKR3BZoqUa5toICE3jz36a0wiXXFgUWQ0V ur94qk/Bb6EajmOUm/5BBQZVh9VF8sZ5XkZDr5kTIQidNKTQH/1KMt5T1fX7iOzEeQcm I1NX6QXjeDEdkPczHWO0SPBCSBs60VHvh/2dR6+n1cY4bX71aFS9YVcQ5IOm9MOBG3IL Rc4SE6KmHI1Eyv+bCl4nI26U8uqY1gfH8o351YLHqXA/HdlGH85o1WXlLCSncF7JsU8b k8Fb5TVyFbPTK7UvYYOfRJmbmv3aXLX1vApBsaEsgewWlc3xgjLzFbgUdcAPDuMch8cm kN+Q== X-Forwarded-Encrypted: i=1; AJvYcCVXbFJpW/y+NluNRw8nk5dLiOre4aj+hjF/UjNTV6Qu8UKIx5TXVbxX9hsH9NLA2WsKn5KmvWMx+A==@kvack.org X-Gm-Message-State: AOJu0YzfVVWdMJEifU5k6nvFKR08R4+oLDhesVCPuYcVvzGR+QXcoHBm paA/XLsGBfmM3vx1VDogfM06MbLAPYxutC6RyGuaaUpl33ZcvGB1+PiZJumX+ALTazfLzyIl8cH zSXg= X-Google-Smtp-Source: AGHT+IEKGMpSHb5f0yI5u05QvgiUAxmRxE826tRbypV2GPNIMdsmv1gm2pe/f5PYbylfyOE4f+EASQ== X-Received: by 2002:a05:651c:220d:b0:2f6:5921:f35b with SMTP id 38308e7fff4ca-2f7cb30cabfmr19027321fa.27.1726838301434; Fri, 20 Sep 2024 06:18:21 -0700 (PDT) Received: from x1 ([83.68.141.146]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb5ee43sm7111622a12.50.2024.09.20.06.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 06:18:21 -0700 (PDT) Date: Fri, 20 Sep 2024 15:18:19 +0200 From: Drew Fustini To: Palmer Dabbelt Cc: dfustini@tenstorrent.com, Conor Dooley , vladimir.kondratiev@mobileye.com, Paul Walmsley , aou@eecs.berkeley.edu, akpm@linux-foundation.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] riscv: make ZONE_DMA32 optional Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 97FDB4000E X-Stat-Signature: 1m794f3udm15c7bfoeakricnt41z6d8t X-Rspam-User: X-HE-Tag: 1726838303-576908 X-HE-Meta: U2FsdGVkX1+RgnJu1S8Awey+9cNonHgI6u9mPsMxkPpdKTDPLh/gWZ584fA6YXqXxL8SDTG4yh2fkeO+iOnWJjGdnJheD9uwXsgrrc2szHUj37jrspeOlpdO0096dPGdMLU/5KjceksNYbTRBIRZYSG5Oa1Z+uw54gSJ+DNsOWOndLMWccS7Z+WHAcez4x6H0k9fUDqde+ag1sgyi7H4VGr9N8yl0HIe0eWFKRmBH2IMxaO9STzDdTt1exNA7rLqHg/rVkomXVTPSYfmxA3+hqE27ccDguZYnvOqNeDGnW6g6+qLmddf+yKnO+t6xtZ4GJx0RxR4p/s1VX9W6yNykho3tor9G/Jx4rv1AgW1HU3siv30UDprykCw+5/upGeGVaVPBIie8DoQnA0Wqw00yIbA5cbzjJDcFBEQV/Ted6YLNg1rQJ6G040QH/FQ/OgDJ29C8Fi/YWchR1kaFJUhRap2URyrvGXtLTzCTuWJu/YTXd3x0Qu9EMq1qUWmSRyQq8O/sNEySFp+8cOfFDHKU+jRnvfmqCslGZui4ZLx3KHzY2F2l+EMHmW/Kw6kCNfxDWen1wxJ5+uR/hbxZS6DA74DG+7FnDVNTbtzUnEi5moDfVBG5tQolNvzUOX+3p5gupiqJMuT5xP2yy3H4irUIfYVRmSvEKalscipX0tFMsSfmOSxwj5y/WwwXH98jOUvIwYUW9uw7SoW/dZKnuK9mDqVW/m4gajlYUZFYZpdu5eEFwpH5CXtNDPAXPqFzKJ9Bu2lQYwuJ8qOxYM3ujO186gqA4pjmQT+rc85PFvKpj8pwBJ/AXq+EKkalUh+OkLT7t5LtAesG8zt1SX3IeqFL27pUsbfcSlfxjg3SfiUZw2eNvDJF2f7ErH53sXvd3p3qadEmBsWw++lD4A6ZpZAVP94KTkB99kM+2gBv/OmBuOMA0kTUHdju4VnX53D8EOok3RI2OHJhnkLjKDo867 9jAi/l7q H2xU8Ynkw7yMMkO3Iro3uYY4guUyVgHMvLEz/Z2Lhf7CKOjtL7UcnenB+UpIMog00mAW6jgu4Ogpu2QY8mv/TqWGEXpy5bViQSkeA/1snQctxPPCpT1fV4s/RWp9foCJcggtry7a3oeINA/cGa65xteejMchORPk1K/XG8pFsTScCOKJb7dJ48mxYBuccBDoq5JZMv/HyVMiZuM2xFc4SE3ZPhaG+HIJdsnK8h9MKu3g21xQznKJG2AgKOrsvxOV7E2mmS2lzDxZXHx4HqVEyCSD7eza7YopMlyUdHdsV/bQFefyvC4vrj+F85hp0KX7dWJ/T1ikUBu7Ohbw7JASUUt0IIVJETm3a8bayE21kjp1MU7uXwXxxqTrDN9pb/YRDRgSmE8lnMmDYWsHhQ4hxrdYLyhX4xZvA7uyOliYDObrUgtk8HVfJawyfMJE0j0s6gVpH5VQpAP4847woC7TJJN+2kM009GR0ZFvFtJgrxlhuXD+C0xizL3OXTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 20, 2024 at 01:58:23AM -0700, Palmer Dabbelt wrote: > On Tue, 27 Aug 2024 16:10:20 PDT (-0700), dfustini@tenstorrent.com wrote: > > On Tue, Aug 27, 2024 at 02:36:11PM +0300, Vladimir Kondratiev wrote: > > > It is not necessary any RISCV platform has ZONE_DMA32. > > > > > > Example - if platform has no DRAM in [0..4G] region, > > > it will report failure like below each boot. > > > > > > [ 0.088709] swapper/0: page allocation failure: order:7, mode:0xcc4(GFP_KERNEL|GFP_DMA32), nodemask=(null),cpuset=/ > > > [ 0.088832] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0-rc5 #30 > > > [ 0.088864] Call Trace: > > > [ 0.088869] [] dump_backtrace+0x1c/0x24 > > > [ 0.088910] [] show_stack+0x2c/0x38 > > > [ 0.088957] [] dump_stack_lvl+0x52/0x74 > > > [ 0.088987] [] dump_stack+0x14/0x1c > > > [ 0.089010] [] warn_alloc+0xf4/0x176 > > > [ 0.089041] [] __alloc_pages_noprof+0xc28/0xcb4 > > > [ 0.089067] [] atomic_pool_expand+0x62/0x1f8 > > > [ 0.089090] [] __dma_atomic_pool_init+0x46/0x9e > > > [ 0.089115] [] dma_atomic_pool_init+0x96/0x11c > > > [ 0.089139] [] do_one_initcall+0x5c/0x1b2 > > > [ 0.089158] [] kernel_init_freeable+0x214/0x274 > > > [ 0.089190] [] kernel_init+0x1e/0x10a > > > [ 0.089209] [] ret_from_fork+0xe/0x1c > > > > > > Signed-off-by: Vladimir Kondratiev > > > --- > > > arch/riscv/Kconfig | 2 +- > > > mm/Kconfig | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > > index 0f3cd7c3a436..94a573112625 100644 > > > --- a/arch/riscv/Kconfig > > > +++ b/arch/riscv/Kconfig > > > @@ -50,6 +50,7 @@ config RISCV > > > select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST > > > select ARCH_HAS_UBSAN > > > select ARCH_HAS_VDSO_DATA > > > + select ARCH_HAS_ZONE_DMA_SET if 64BIT > > > select ARCH_KEEP_MEMBLOCK if ACPI > > > select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if 64BIT && MMU > > > select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX > > > @@ -200,7 +201,6 @@ config RISCV > > > select THREAD_INFO_IN_TASK > > > select TRACE_IRQFLAGS_SUPPORT > > > select UACCESS_MEMCPY if !MMU > > > - select ZONE_DMA32 if 64BIT > > > > > > config CLANG_SUPPORTS_DYNAMIC_FTRACE > > > def_bool CC_IS_CLANG > > > diff --git a/mm/Kconfig b/mm/Kconfig > > > index b72e7d040f78..97c85da98e89 100644 > > > --- a/mm/Kconfig > > > +++ b/mm/Kconfig > > > @@ -1032,7 +1032,7 @@ config ZONE_DMA > > > config ZONE_DMA32 > > > bool "Support DMA32 zone" if ARCH_HAS_ZONE_DMA_SET > > > depends on !X86_32 > > > - default y if ARM64 > > > + default y if ARM64 || (RISCV && 64BIT) > > > > > > config ZONE_DEVICE > > > bool "Device memory (pmem, HMM, etc...) hotplug support" > > > -- > > > 2.37.3 > > > > > > > Reviewed-by: Drew Fustini > > > > Thanks for sending this patch as I've also encountered that annoying > > error on systems with DRAM above 4GB. > > > > I tested this patch by changing the qemu virt machine to have DRAM > > starting at 2^32: > > > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > > index cef41c150aaf..3033a2560edb 100644 > > --- a/hw/riscv/virt.c > > +++ b/hw/riscv/virt.c > > @@ -87,7 +87,7 @@ static const MemMapEntry virt_memmap[] = { > > [VIRT_IMSIC_S] = { 0x28000000, VIRT_IMSIC_MAX_SIZE }, > > [VIRT_PCIE_ECAM] = { 0x30000000, 0x10000000 }, > > [VIRT_PCIE_MMIO] = { 0x40000000, 0x40000000 }, > > - [VIRT_DRAM] = { 0x80000000, 0x0 }, > > + [VIRT_DRAM] = { 0x100000000, 0x0 }, > > }; > > > > /* PCIe high mmio is fixed for RV32 */ > > IIRC the ZONE_DMA32 stuff existed for some of the early SiFive systems, > where the expansion daughterboard's PCIe controller (via a Xilinx FPGA) > could only handle 32-bit DMA addreses. I think there's a similar quirk in > the Microsemi PCIe controller on the PolarFire boards, but Conor would know > for sure. I don't think this patch would affect those systems that need ZONE_DMA2. I believe it just makes it possible to disable it in the kernel config. The platform I'm working on has no memory below 4GB and all the PCIe devices that I care about are not 32-bit constrained. Therefore I just want to be able to turn it off in my .config. Thanks, Drew