From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84EBCF58F1 for ; Fri, 20 Sep 2024 09:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28B2E6B0082; Fri, 20 Sep 2024 05:14:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 239A96B0083; Fri, 20 Sep 2024 05:14:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 101ED6B0085; Fri, 20 Sep 2024 05:14:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E68996B0082 for ; Fri, 20 Sep 2024 05:14:17 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 655F4C01D2 for ; Fri, 20 Sep 2024 09:14:17 +0000 (UTC) X-FDA: 82584555354.30.A8D4676 Received: from outgoing2021.csail.mit.edu (outgoing2021.csail.mit.edu [128.30.2.78]) by imf28.hostedemail.com (Postfix) with ESMTP id 9AB9AC000C for ; Fri, 20 Sep 2024 09:14:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=outgoing.csail.mit.edu header.s=test20231205 header.b=AYMtujmy; spf=pass (imf28.hostedemail.com: domain of srivatsa@csail.mit.edu designates 128.30.2.78 as permitted sender) smtp.mailfrom=srivatsa@csail.mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726823597; a=rsa-sha256; cv=none; b=8MdC+2jmRQdKbossVJ/ZgBYMwz+HfrfL5bz1QXLTItZenChqzdfEBkTlzwJtN+5/RtjeEi VUgGQNkTzSyeUClj1rafAgARVKkLqcJeLAiNqJakg+Cy/JDOP76YQmL8DFj9gdFTfEGpj0 G7Nea75yNd36iW5hSteXlCsuogkBWAQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=outgoing.csail.mit.edu header.s=test20231205 header.b=AYMtujmy; spf=pass (imf28.hostedemail.com: domain of srivatsa@csail.mit.edu designates 128.30.2.78 as permitted sender) smtp.mailfrom=srivatsa@csail.mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726823597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rw93B/21NuWVfL/ibqQ+YISfWYXzFqSVN+KXpI2YlJQ=; b=a15x91m66oRK7/wr6IdmVXSbYHGOMEmor9d8JWoluI4XS746MgZua5CZ+G6+okoRUYZmTE I6aLpbrL3QjljK1tIQSoFAHEQ5EDafG/gqwKCQquSrt0GvYE1oOZNKDpombP4gjhNlcVZA e5toEJir+QLVgcV5h2qg4zFk3YvPSmk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=outgoing.csail.mit.edu; s=test20231205; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rw93B/21NuWVfL/ibqQ+YISfWYXzFqSVN+KXpI2YlJQ=; t=1726823655; x=1727687655; b=AYMtujmyNXPOyj1nzIjMOb476rkVrMqxVdIP0FuUHtZscubYKyS2fHpO/DNthWaAYotUhe90upn FvMuzJe1/EpBFZDaZWP1voi7wEcKytPeH8zELKgUHJKUD9OudnrjoAlGjwyPuzyk30KG1NALIKEnG m6WZOX5wfABGdiJ0gP8xlqqx+BYryF5CD3eclbzewPFt4TXj5ajTpg/QjRCzS/ZndJ/4q/ODic49q Anl90IeztMGnYytxZbOQPjlOs6vIJ7KT5rXUSSbH7kHPfbmgtTGgrTyhTc7EHHr+pmVq2ucpIGhsh rzyZoXFEQ40YHDRDxEa/M/TOV9s9vKpxT7AQ==; Received: from [172.179.10.40] (helo=csail.mit.edu) by outgoing2021.csail.mit.edu with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1srZiO-006Dkk-ES; Fri, 20 Sep 2024 05:14:12 -0400 Date: Fri, 20 Sep 2024 09:14:06 +0000 From: "Srivatsa S. Bhat" To: Anshuman Khandual Cc: Saurabh Sengar , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ssengar@microsoft.com, wei.liu@kernel.org Subject: Re: [PATCH v2] mm/vmstat: Defer the refresh_zone_stat_thresholds after all CPUs bringup Message-ID: References: <1723443220-20623-1-git-send-email-ssengar@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: uo9bwo8a5r9rfm8p179hw8wgcueffjw4 X-Rspamd-Queue-Id: 9AB9AC000C X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726823655-372758 X-HE-Meta: U2FsdGVkX18gjEvZCbjN4BSpBi4RAfE9W1ZPLDO+9EGmAOqn4hwVRPhotmyXkfhRd/L941wEVWJ1ACphMREAaE17fx7VSMVpLfV5oEbW+rTLjhTPTBq6PAv7qGyRB/Te1rABAJRzzhEbGu1YldR0IVI6CelU8QS9tT/L99CEWp61F+xWyA0XsJP257e+AtfEsaWUj3oIT1Dnw34ntjD7yp9tssBnlgcYDt18b7WE9eJOPxJqgAShACyMnEYXRZ1P/Afd+mBgWflwCvZ+y2chrvQmdLL+vctLw6k5oISsRbdYFA8PtZlDjTZWuMqAY5NxP61oWcYU4ks08o302r1i2A1gX2Xgw3iwjWy+bopCCNuc+oM8dqfIHtozdNOTdDgnJ5gppkwpjcy1wetWT/EGg4sF5JfRzlg+9JZXm+U30iknzcnd5Wc95rRNx0L7bNRwkbJCdyyCU+KYZ8K8x1P82nFg8UjBHEkcKUP3y9Kfv3YylTpw//2+A5rrB2wAHU3YiWWiDW51MLSuPGJgQv5rrLbbL7eouzn7CcYoTTB1/0N+tuI9OEb7qzuSik3TDztqDOZGV6XNPrLSEx+NW3GETGOif4d6lkf3lmdujh6MM5Ml4CyHJdOc1cbcqT4mFrv50dg0Th7rWKaQi3/6XqmcpfOpLxXNu/+c/4lGdxaqC4GZ9Wo/mPN6J09dzaxPZwn3+lN9AN48K340RPSTWij5pR96Qjmej6253r6Hd67xsx84A0JpFxCh06nQMlD5gs55SZR/5A+TBgySBbhqVGZPrmbsnkhvyKFbCcecAqujZz5vtG2kv0WkAky9OUSjNud0cWzGUOvxg52P4Wx27EaPVFnH54TGvgSIkZe+GvnIxUaRLOkVEQU5k6QvPUVgvTOt2+tcTqJoZHo76TRywzBvPVCQ1yzVqStUAhJfnDDZ4wRgrDYnVhIbku6AZx1ATi3NpThMnpEt8pahBXM1Hna PuDxm35d IzBKTZalZSEkZKhJMdLYwi3kuAG2wGn7wLw9UQhapa0DzOo7nxLRSMKlUFTMDcOjqIKI0HpcRKh1ymVgcwNZ1bRscZtq/jkNA8NctsdGanihFShdR9+MpPuPB40tNcbPo+DG17a42W5fnOxirc3LLObsidXd2eC3j52UDWspVNvyRbu0JMFk0tWnhLPVhir/6Id8vEtuwwrRk2zmsJtKiHgF127KipUEZdN3mMGNqZ2MIrf4ZU5P91WYYz6P4cpq49LkNtYRykiOiIEVfGW4WQgWnA6osDAOsfnJKCyZl7GU9lACwMvPfJR2q1EFJVxl31M8FJuLoKB9BGYwog1DWUp+G0jqycY97ofO/kS4DXsDGCCw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Anshuman, Long time... :-) Hope you are doing great! On Fri, Sep 20, 2024 at 12:28:44PM +0530, Anshuman Khandual wrote: [...] > > @@ -1908,6 +1908,7 @@ static const struct seq_operations vmstat_op = { > > #ifdef CONFIG_SMP > > static DEFINE_PER_CPU(struct delayed_work, vmstat_work); > > int sysctl_stat_interval __read_mostly = HZ; > > +static int vmstat_late_init_done; > > > > #ifdef CONFIG_PROC_FS > > static void refresh_vm_stats(struct work_struct *work) > > @@ -2110,7 +2111,8 @@ static void __init init_cpu_node_state(void) > > > > static int vmstat_cpu_online(unsigned int cpu) > > { > > - refresh_zone_stat_thresholds(); > > + if (vmstat_late_init_done) > > + refresh_zone_stat_thresholds(); > > > > if (!node_state(cpu_to_node(cpu), N_CPU)) { > > node_set_state(cpu_to_node(cpu), N_CPU); > > @@ -2142,6 +2144,14 @@ static int vmstat_cpu_dead(unsigned int cpu) > > return 0; > > } > > > > +static int __init vmstat_late_init(void) > > +{ > > + refresh_zone_stat_thresholds(); > > + vmstat_late_init_done = 1; > > + > > + return 0; > > +} > > +late_initcall(vmstat_late_init);> #endif > > > > struct workqueue_struct *mm_percpu_wq; > > late_initcall() triggered vmstat_late_init() guaranteed to be called > before the last call into vmstat_cpu_online() during a normal boot ? > Otherwise refresh_zone_stat_thresholds() will never be called unless > there is a CPU online event later. The vmstat_late_init() function itself calls refresh_zone_stat_thresholds(). So, we don't need another CPU online event to happen later just to invoke refresh_zone_stat_thresholds(). Does that address your concern? Regards, Srivatsa Microsoft Linux Systems Group