From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 634C5EB64CF for ; Sat, 7 Sep 2024 19:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DA156B00B1; Sat, 7 Sep 2024 15:16:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78A866B00B2; Sat, 7 Sep 2024 15:16:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65BDC6B00B3; Sat, 7 Sep 2024 15:16:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 484F86B00B1 for ; Sat, 7 Sep 2024 15:16:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5D89160B8A for ; Sat, 7 Sep 2024 19:16:34 +0000 (UTC) X-FDA: 82538898708.16.70635BC Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf29.hostedemail.com (Postfix) with ESMTP id D480E120007 for ; Sat, 7 Sep 2024 19:16:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OfZjFKRO; spf=pass (imf29.hostedemail.com: domain of visitorckw@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=visitorckw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725736492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KVvIq9cbRzgUomviOr5pfKJ5huC/3mV8XHpAjftGdTU=; b=PzUyZQXZIsqya64sLpp6v+LLg0eCyzO1WwYk85ggrj9EN5okn/7ZERob7Cb8YLXpCUxS14 8mX1KIxDQdiolswC4haLSqBe3kqG4Nk6/pcenUxdMRgoj6Bx47k+awD3qGoIIeklXTQ4Dg xpJHZI2tbZdjZhxKLvN2KRouufPqgH4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725736492; a=rsa-sha256; cv=none; b=3WuAmgWzN+bQG7NowsL/3U/hVF6cdkTkRNSxIaMXVx/qXNuJ6CZnTOMfVAn6tU/d4CiI/6 gdRbifxrRqyeJb3AqDBZSuKuaDSo1URo3KrOe4ITqRu2eq4OjqFH2OxZD/eVPAtnLoUfNl ALQDMvY2AQ7kczu+Ta1RhFGD3VTGOUg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OfZjFKRO; spf=pass (imf29.hostedemail.com: domain of visitorckw@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=visitorckw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-718e1ce7e84so848977b3a.1 for ; Sat, 07 Sep 2024 12:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725736591; x=1726341391; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KVvIq9cbRzgUomviOr5pfKJ5huC/3mV8XHpAjftGdTU=; b=OfZjFKROA35SsU+uUWHKv+uSzh+Wf1ibmoDpmyzt6SEWwToLmtc7ta71PhjuEirtib BaRUQ+1C1lnegIf3v2uBO6bV4dnSbZkXUgrfe7+uO5lqcP7RT/aOLopfhAng82DAFfZ6 uKFVb8bbrFqJmWO9FeL8lQcYAqZmwVGbirXbW1HRtOi5qEdA+XfwDoKkcByEfrorZxcr Bz5D/m4ABzO/mCNHyjT+yII8lG/qshp4Cg9IYyWOR9fYnQ5ri4GjDeylm6ZLGSHn6rHZ cWeMug5S18AcXKmw0ECsb3MpRL6sJL9gvc9Ml74M43Bt+1uO26DnhzyMZIxOKyCcb7Pu wfjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725736591; x=1726341391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KVvIq9cbRzgUomviOr5pfKJ5huC/3mV8XHpAjftGdTU=; b=jOTJgTHYSZfxCNgOw+HSRSSJC8A7QFwXItkceM2yI/aHfOZBgGssWkERewKXXteBAQ 2u148BnC8zBvK9O2pd93YglsypCI/GueWrEnorXF0cQigHTaIUFuS1TTVkCPeADQTXmk 7NYcyRZEtbBjWtVbYWqKWINwU4GibOerlbn1k6aY8nic4meqzZ4PfRv31Xq5HqZQ4tYE v74F/bXNeyEolv+zXAnvdxEVi/W807b5Dx9LoH+1lj05+Ki32jIj3vfd86QDBgiFifLu sNt2pNymgAPezJBpAfQomPn9C6qARB02UGaMkx+kG0R252yENPWbAImoQXyguB3zs3/d 0AFQ== X-Forwarded-Encrypted: i=1; AJvYcCUiqyHd/3mJeRVlAVvL9NR/hgO3ZzOKI91mFTzjG5RHTQxbtZGKx5OVjWEIyjYn8homxoizhmuMJA==@kvack.org X-Gm-Message-State: AOJu0YygXVezBDpOb7p/RcHUmbxiAMzjnTpDUI10UbHdNWmm5KRRoF1G r9PLLkue0LLQg7nl1hXkveFpy0VYmVhmX3AuM8f76KcJBcf/yOLR X-Google-Smtp-Source: AGHT+IHPvmwOUamhODAghY2fnNUji7in+pa6rUK3uZzkO10N0T61Nm8kcp63YljA29RhpgKHiHqXww== X-Received: by 2002:a05:6a20:ac44:b0:1ca:ccd1:281e with SMTP id adf61e73a8af0-1cf1d05a9demr6768324637.7.1725736591313; Sat, 07 Sep 2024 12:16:31 -0700 (PDT) Received: from visitorckw-System-Product-Name ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-718e58963desm1172521b3a.35.2024.09.07.12.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Sep 2024 12:16:27 -0700 (PDT) Date: Sun, 8 Sep 2024 03:16:23 +0800 From: Kuan-Wei Chiu To: Lorenzo Stoakes Cc: "Liam R. Howlett" , Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] maple_tree: Mark three functions as __maybe_unused Message-ID: References: <20240907021506.4018676-1-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: q5t9f8wt5y9uhyzijfrsaqth1pew3hcc X-Rspamd-Queue-Id: D480E120007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725736592-314541 X-HE-Meta: U2FsdGVkX1/1wZA7yP3Ij3tSSngklsncVJPgo0eRcLMg5wokPXSeZwjkrdr1qmxvMLq4RAd4X7vQlBilzbIIRvzG/2jOr5sw4BP6WXPL64QdGTy0CcVi10nByUQ35VCSRJuO4wVyLijj5xOsvcCp0YQ45cOJQyR01E2RnNHjfdi2NHq1M0J76jDF/IZAYHxCwWsdL+5ys1nt5c3ZE8YEc1QXl4bXAUdBlnvM/bnRJu6wCpW+T9pgdi+YBjOtISpYLXLsDtVZSee0135r0iW9jef4wSHXMNlsm7GMYIgOpd+6ZV7jQ5zsyL8Q8YkwhcxnHZTdHDIHjXrt30kKMgUq+9n/aCtSKsp70iuSody66pFw0Q9ZvEnPfJ8Qj34vYA4v11A2MMXn9tTBDiQZG+i0o3hWOQWQjqIiYtVK7QjaKoQsSYE1PFbsihLGu2bf2KfojuUFIwFv/tKJP63cVwuNQPkjlwPwKxWmFheY4+rC5vGeFg100+uZs/fJr9RwBGnylLrO/C2HEHQUqIdvEXN0sI3XoHlgR5H8YshX/B03DuCjMg1pmhmq5bA2c830KGc2MZ4egsCj668uvabIUl/RirNeDZfItXcrMfweh4TFDb1Ujpbmy1t5fS/wHiIDupTApQcOblHpLYA6fnDQjbsOsHIP4FkcG8QxQqzW1yOBcqQMSQQ7hgNZEnKe/4ciKq3dmWTvVeKLPg57n4rvDbV/EEmOtZ7xWu/zTonjiocycn6gYioR9XjdbiTJBTNO4cTh0inVEKwWJvQMKOB2fqnlI0gtKtvdR+DRbSuXFvV5iW8CbdfHLmB+cmWMMxodTKu+0/SSKGHicHnn0KoWOp3ND7/wcm0+Ne4L1aEGXf5Fqkf4Yk9zQf7hMMORe3JmckQG5/ME8EbjdZavMYPC/PYz+tVtaC2hbCdoLkcOjKL4HEdL1Kbcevc0nrHhzvihzRo1bQ/ILZ32cUDfhTLRr7l /nK2V3cs fG92gfeq1uebl/9+6UUQyidQkfwOPGzbpn6j1VxbXv+hI9juyxhiRZao4hh0Yceru4R3tncBEEbn7cliWKmEdhtme5YyRPr6paA/QKmhO5dNqDdyFILUlQSg6pMohhdFU6E+AuPcG7y+AthK5YDQSDwENZlji+JbS/Ps/5fbm7udvAybp6NwM1DOsbd8iVaTtx4k5Mo+nkSVne+eYBZEt6vGU4zzAJ/EOhUyZDajj9GeUKI1xVKMKAxeWFTs9NbJO+pon+Wd9Uhxcv0FLyXrcCr2k05G9H2f7391A2MKllfNmDxdWES9tGBCg/ZlXD04wfsBCUVU7A2VKLw2lX5pOKtPe1rRCKcBjWJoRclPlfkRe85hNOzHv6xdiDQsRiMc+2I0rF65CunpuL8Ra5W3vPpus3g+4pKxLtBTIGN0do9w7mS/GerRpNFUzexxN50/qUu8fkJXIW4ddc1QTnBVUXnIo4kup9CL+Wt6FPVD+ougQx2MoChyqqjQDCn65chYfhqIe90s6UZb4Or1EglB3rp+L4uOeaPfN10ieiwyjdpnX72UOuCo7HXGAYgqkkGcZCSkeg5r26Eda6adb6TyStcq0xXfd1mAHN4Hm X-Bogosity: Ham, tests=bogofilter, spamicity=0.216130, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Sep 07, 2024 at 07:31:14PM +0100, Lorenzo Stoakes wrote: > On Fri, Sep 06, 2024 at 10:15:06PM GMT, Liam R. Howlett wrote: > > People keep trying to remove three functions that are going to be used > > in a feature that is being developed. Dropping the functions entirely > > may end up with people trying to use the bit for other uses, as people > > have tried in the past. > > > > Adding __maybe_unused stops compilers complaining about the unused > > functions so they can be silently optimised out of the compiled code and > > people won't try to claim the bit for another use. > > > > Link: https://lore.kernel.org/all/20230726080916.17454-2-zhangpeng.00@bytedance.com/ > > Link: https://lore.kernel.org/all/202408310728.S7EE59BN-lkp@intel.com/ > > Signed-off-by: Liam R. Howlett > > Reviewed-by: Lorenzo Stoakes Thank you for solving the compilation warning! Reviewed-by: Kuan-Wei Chiu Regards, Kuan-Wei > > > --- > > lib/maple_tree.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index 4f34e50c92b5..20990ecba2dd 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -348,17 +348,17 @@ static inline void *mte_safe_root(const struct maple_enode *node) > > return (void *)((unsigned long)node & ~MAPLE_ROOT_NODE); > > } > > > > -static inline void *mte_set_full(const struct maple_enode *node) > > +static inline void __maybe_unused *mte_set_full(const struct maple_enode *node) > > { > > return (void *)((unsigned long)node & ~MAPLE_ENODE_NULL); > > } > > > > -static inline void *mte_clear_full(const struct maple_enode *node) > > +static inline void __maybe_unused *mte_clear_full(const struct maple_enode *node) > > { > > return (void *)((unsigned long)node | MAPLE_ENODE_NULL); > > } > > > > -static inline bool mte_has_null(const struct maple_enode *node) > > +static inline bool __maybe_unused mte_has_null(const struct maple_enode *node) > > { > > return (unsigned long)node & MAPLE_ENODE_NULL; > > } > > -- > > 2.43.0 > > >