From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51501E6FE2D for ; Fri, 6 Sep 2024 15:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9829E6B0085; Fri, 6 Sep 2024 11:43:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 932B76B0088; Fri, 6 Sep 2024 11:43:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F9EC6B0089; Fri, 6 Sep 2024 11:43:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 628216B0085 for ; Fri, 6 Sep 2024 11:43:45 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F2CB5406C2 for ; Fri, 6 Sep 2024 15:43:44 +0000 (UTC) X-FDA: 82534733568.27.4184C36 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf29.hostedemail.com (Postfix) with ESMTP id 34A3D12000A for ; Fri, 6 Sep 2024 15:43:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="a/kzGOK8"; spf=none (imf29.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725637324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VdL9Hkz3cCqbKZd2xGaoNoPr3k6OnHg8Xil85aJs3Do=; b=C5D+GQPzkHs0EnE6bEPr3HO+a6gSJ2REElBz3yvd8yQNIvSMzZUOhFCLKeN1eZr1EiIUF5 qMANN4AkmaVY2Ty2H2mWxr90z2ikKWwqcDAYBv6D0NiOEPWktXmD78Ep/mqT81BRi6lGS0 EFnPnC61RiKcn9wqz9EF2va3yIn5hzk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725637324; a=rsa-sha256; cv=none; b=oK/tL1cT30Esu7mhIS5rWcT0qRlQTqRmKB+YyUSyhB/pB8+MvXMBeTSRZbTHfqZZk1rXBb 8UxNGNWwDhM+EInR5N8LssCdelDFIbaG2/qrp//jQuQUX6EBMiO3ZeQ54B/bBaN/yS7BR4 a9nrRccJLFeJIVIK/BNE0anhRsCcICg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="a/kzGOK8"; spf=none (imf29.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725637421; x=1757173421; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=5FDvh4fea6HWFs/qXnSsOsUIHGXCTXgCLjpn+Cc/8yM=; b=a/kzGOK8qYoDYmPQIRuv+DyQTledJA6K0YqFe3N590QZJistSjGDUaDw REcdQtwDMaIUmimnW+Ih6dTaS+aX1tI9QNmsAXWHQjdG7xFj2xL1pAF6e 4l1ArN++8NMaPexzKM3kKanS05w/2V/EQXaB8OUmE2m8F3OeeokNcGL72 R/ynbtrqICTcRSaGqMJdLQP3dQirgxkmJsQEuts2OyISqwTtgosaApDi2 ZK7lPse+zkOhnQmZtBp6A2qr9ZXqQHXeXdYVgsSxgWFmN5c0xzdtz6guA wYj6rnIwowDSbYPxYBP0hHFuILR3T3fd/sH001Aho1FkHje48jC6Wt7mT w==; X-CSE-ConnectionGUID: bSjWoM0VQw+axOGLyov7hw== X-CSE-MsgGUID: 70xTTcXRSCGhmDMW/24rSQ== X-IronPort-AV: E=McAfee;i="6700,10204,11187"; a="24349666" X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="24349666" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 08:43:39 -0700 X-CSE-ConnectionGUID: L0dOF7V6Ts+sggY5gOybcg== X-CSE-MsgGUID: vYswIGANTV+XEgUtmza+cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,208,1719903600"; d="scan'208";a="65960892" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2024 08:43:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smb7X-00000005qmn-0yUi; Fri, 06 Sep 2024 18:43:35 +0300 Date: Fri, 6 Sep 2024 18:43:34 +0300 From: Andy Shevchenko To: "Liam R. Howlett" , Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] maple_tree: Drop unused functions to fix the build Message-ID: References: <20240906150533.568994-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: nzhfdxsuidf8gnwtgo9hbebnc38gq6x7 X-Rspamd-Queue-Id: 34A3D12000A X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725637421-983311 X-HE-Meta: U2FsdGVkX1/FNttKOyYJqqSV+2xM90M5nwS8s7J97iSms459KfcVkYelZxeFM1B/nD4nE0UZIGIZZPmy0swspG+so1klu6D5P/iBto0/cPh+Ya+nchJU9kK392kQcgTmRsOCzWU8jiBzyVA+kguqoayqF6nagiJSbhfqeCGr2LfUZTiNnD4nrtpT+H4EqOD5LZLdeMLFVOg1ig0TdYO8TtypAuxHgtSBZUtUJKnM3CrtPHimHZ1uRjC9teNt2V+GWKz6S54Pl/66ffQOcYCdM5d0qdgLS0YGXJ45qbSc0vaSt7M2ZVMi9TOGAkh0RWedgT3tkAziFqf3nU6iCV3RH4ixVBf1cRwaRE41McQnRfNebpQKPvcd58dIJ+304Ghqx4/1DzNcaef935taFm8IY7USDA7yajJE9scCijAoWZ4j8PrTSVtvaDnzrA7ZuD06c2DN4qReuE83L87YAdUxaV3WftcVBVxkqJMS6iNGJ97S0uvTJ5osZSeAtIo1hO4AQfVAzlJJZXHc1WGIq9fHfPIrRpL2SF/ar1brBejKd15ZSgOS1HM4do7hdROfrwsDJQgPMArNWnxi1VQmM5eMSgcXExD6WPGC/tJSwQNyDLNXTwFvzD/O45eDFrTux/QQAPpF9bN3JIa1hjwRigIG62h9EzltuN/Y+25OVy5vN6CEeSz+WgpsItuhcOpxf4UTqxm/v+4i5zH/AvixWMheyAW01q8ZEVvnMzwuT4654e/FyEylOG8wavKVtcI2nBRerhOkev0LzNWVctD3+S90DceK9UeS2MoI/3aH24lpxxgyHcxd7eKpPfd1ONM99atI4pP6/BsuMlKb+xSyFlwBhocmjB5vv7iWTEIDNyMhRl/QSv92Sbec9JUd6XLTnGoy9Dbd3iDtmZS3beDJ8zrhvRefcSDu2pwobsXu40OvMsnMGIAUxkrvshVZNti4xZtAuzoRhe4r8GrkgqYpgwj 9/g2I8DB GqxQmXKw3+COlxjoPScjvDmSwwZ7Ajh0sK6LheWx1asoV9Fo806InY8+qjV4SIKmlK9avBum9gi+Ux+KMzBoHWhwjNC+XIPX36ZtRRxhmw3SOcXuCerFNuAb3Xi2dVIt5DfyGoHqd9wk6dJ/yxFjDaGNR+53HjuwFrNO5MwJC/toR9F0nkdHZAgYN6vLru1m7Xon+22CniU4WKW4xbokOBYcAiEiWoF8/LfRteKiruw9VaGKaXBOjahAMVlCIC7NUwIp0ZbawaX4FyMlLb3E0IGNs5F44rIo9zDuC72hOY6XdZ1Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 06, 2024 at 11:26:26AM -0400, Liam R. Howlett wrote: > This exists to stop people from using the bits while the feature is in > active development. We had the same patch a few days (weeks?) ago. This breaks build. Can you propose better solution, please? > * Andy Shevchenko [240906 11:05]: > > A few functions defined but not used. This, in particular, > > prevents kernel builds with clang, `make W=1` and CONFIG_WERROR=y: > > > > lib/maple_tree.c:351:21: error: unused function 'mte_set_full' [-Werror,-Wunused-function] > > 351 | static inline void *mte_set_full(const struct maple_enode *node) > > | ^~~~~~~~~~~~ > > lib/maple_tree.c:356:21: error: unused function 'mte_clear_full' [-Werror,-Wunused-function] > > 356 | static inline void *mte_clear_full(const struct maple_enode *node) > > | ^~~~~~~~~~~~~~ > > lib/maple_tree.c:361:20: error: unused function 'mte_has_null' [-Werror,-Wunused-function] > > 361 | static inline bool mte_has_null(const struct maple_enode *node) > > | ^~~~~~~~~~~~ > > > > Fix this by dropping unused functions. > > > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). > > > > Fixes: 6e7ba8b5e238 ("maple_tree: mte_set_full() and mte_clear_full() clang-analyzer clean up") > > Fixes: 54a611b60590 ("Maple Tree: add new data structure") -- With Best Regards, Andy Shevchenko