linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] maple_tree: Drop unused functions to fix the build
Date: Fri, 6 Sep 2024 18:43:34 +0300	[thread overview]
Message-ID: <ZtsjJoGKRxszp-m6@smile.fi.intel.com> (raw)
In-Reply-To: <krsjmi43ziyojqicc4pxzwfwbffqrnk5npbuoq6l2cnq5eovkd@afofyteb5wo3>

On Fri, Sep 06, 2024 at 11:26:26AM -0400, Liam R. Howlett wrote:
> This exists to stop people from using the bits while the feature is in
> active development.  We had the same patch a few days (weeks?) ago.

This breaks build. Can you propose better solution, please?

> * Andy Shevchenko <andriy.shevchenko@linux.intel.com> [240906 11:05]:
> > A few functions defined but not used. This, in particular,
> > prevents kernel builds with clang, `make W=1` and CONFIG_WERROR=y:
> > 
> > lib/maple_tree.c:351:21: error: unused function 'mte_set_full' [-Werror,-Wunused-function]
> >   351 | static inline void *mte_set_full(const struct maple_enode *node)
> >       |                     ^~~~~~~~~~~~
> > lib/maple_tree.c:356:21: error: unused function 'mte_clear_full' [-Werror,-Wunused-function]
> >   356 | static inline void *mte_clear_full(const struct maple_enode *node)
> >       |                     ^~~~~~~~~~~~~~
> > lib/maple_tree.c:361:20: error: unused function 'mte_has_null' [-Werror,-Wunused-function]
> >   361 | static inline bool mte_has_null(const struct maple_enode *node)
> >       |                    ^~~~~~~~~~~~
> > 
> > Fix this by dropping unused functions.
> > 
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
> > 
> > Fixes: 6e7ba8b5e238 ("maple_tree: mte_set_full() and mte_clear_full() clang-analyzer clean up")
> > Fixes: 54a611b60590 ("Maple Tree: add new data structure")

-- 
With Best Regards,
Andy Shevchenko




  reply	other threads:[~2024-09-06 15:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 15:05 Andy Shevchenko
2024-09-06 15:26 ` Liam R. Howlett
2024-09-06 15:43   ` Andy Shevchenko [this message]
2024-09-06 20:05     ` Liam R. Howlett
2024-09-09  9:41       ` Andy Shevchenko
2024-09-09  9:55         ` Andy Shevchenko
2024-09-09 10:16           ` Lorenzo Stoakes
2024-09-09 10:24             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtsjJoGKRxszp-m6@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=maple-tree@lists.infradead.org \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox