From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090ECE6FE34 for ; Fri, 6 Sep 2024 17:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18C5B6B007B; Fri, 6 Sep 2024 13:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13CD36B0083; Fri, 6 Sep 2024 13:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0037E6B0085; Fri, 6 Sep 2024 13:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CFEBA6B007B for ; Fri, 6 Sep 2024 13:18:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3D670A937D for ; Fri, 6 Sep 2024 17:18:18 +0000 (UTC) X-FDA: 82534971876.13.49A0348 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf12.hostedemail.com (Postfix) with ESMTP id 4A8C440012 for ; Fri, 6 Sep 2024 17:18:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m+8rRYxB; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725643047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=foY/mqpoigLwlXtdwHmsCB1m0vVWgISLxGbm0i/rgEU=; b=Xwfi1yJ7tPdp5yRJYRryzYseMJAHXypvLzt13ypgHLByVsEWMBquN7HfaV7FXTi5jXQI56 WWfQ3yAJ/04Q5YyQv0S029TxP+/DGxrp1CjGzFmjdokgA4Dq7aedqMhr2nJg2UkAsPTmkn qq7ot0LO4qBPdZCGHW6zI2QDEJghqCs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m+8rRYxB; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725643047; a=rsa-sha256; cv=none; b=NYuS+8oz3+0dBbswAZDui7BugCWdGIWi6t3xWYumKnFp3/WCjmAQdsIGcMREKvnFVM5Hiv jrPOs5Hmfrrfj4Le6OOs75dSpokCuh8TxOIuZpiO5fhEZjIK4PtbLBs6i996ssp8KRvkqa iTHEUW/juxA/F4ORyc+1ojmmF9s72ko= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5356ab89665so2925200e87.1 for ; Fri, 06 Sep 2024 10:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725643094; x=1726247894; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=foY/mqpoigLwlXtdwHmsCB1m0vVWgISLxGbm0i/rgEU=; b=m+8rRYxBXFcH2epv1uaBuuS6hCMcd5RtoJO1oF6/7ybwh9b0lY1V5zsbfdWeYEdFaY RSoLa+bT0W2UKFbwbm2xEDCSBUB9XFxyFyVA8fsaI16H3D+MsbsIZp6RHQQdXAlK3XUA Egi/zDTtLWMafcvHp4sZoh1apWHtyv0UOWICb3fYeH4qvjkEygPTbZmwojHVr4j9jrKM DxLPktDbB1m3XqyesOeavGArthtoV5aqlSeCN/GZ3f30BeFg0qYln3WGh3J/O8D5/Teu 0ciEjP14NkWMpuwFYpLiflp1y+WQ8AfoHzzatxdub9Rzj/ABcr9XcqWpVnRssn1c5Wuu iNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725643094; x=1726247894; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=foY/mqpoigLwlXtdwHmsCB1m0vVWgISLxGbm0i/rgEU=; b=T9U315nWmsuqTNdVUVvjRKfyU5jZRUkjEYERCx658VbYhbAJGwAzDzS8Crgtv1pQGq EQ/83SDfvzKg1A9+GKAIB3QsiB1iFQdCHc4kVIygmdW+UpYbWyiH2VU7am7DxCTBPb/p txSG/e90JUSXWIQVVyHc0/YDAOu5zRjh2Whti8FTk6QWz6BXAKYy09iQl3uOEgGLr+Ee DCKKnT6W8s+Whs/Ddwcs/8+fymQPbXc9D+f1XH0TaZUBwcSpyFc0G2mbpfutui7IJdKM Qjp+y9L0PaRuRoAtnKGUgm0vGzXfL3NfHxb9QVg4+ZmdKXtR9+Buj5zCBoYXxZpQEmfw l8Hg== X-Gm-Message-State: AOJu0YxNFysbkljrzYW4HD4p1GmUzqN7NJesqyTemPqUexigFp2KB734 c4KPfhMfsXvq2bhkhV/v4h8v/xzYmZajx9G/4CD99io3VlQXVLay X-Google-Smtp-Source: AGHT+IEhbInSaHtgS1T3xtavDC2oSPmzQV0szMoNmv1EGgEpcX3IvIHPyYGTWfszY/XpcYzgDhEYeA== X-Received: by 2002:a05:6512:33cb:b0:52c:dc97:45d1 with SMTP id 2adb3069b0e04-536587aa70cmr2442091e87.10.1725643093468; Fri, 06 Sep 2024 10:18:13 -0700 (PDT) Received: from pc636 (host-90-235-20-248.mobileonline.telia.com. [90.235.20.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-536545e2875sm408205e87.6.2024.09.06.10.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 10:18:13 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 6 Sep 2024 19:18:11 +0200 To: Peng Zhang Cc: linux-mm@kvack.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org Subject: Re: [PATCH] mm/vmalloc.c: use helper function va_size() Message-ID: References: <20240906102539.3537207-1-zhangpeng362@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906102539.3537207-1-zhangpeng362@huawei.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 4A8C440012 X-Stat-Signature: bcck8zo5zto9qx7bw948ji49b5zhcppa X-HE-Tag: 1725643096-49203 X-HE-Meta: U2FsdGVkX19gYunszth42x3zyA08TD+jjMHYQx8j14RRPun9djKFeLWkk9dqxHwxgZvsFFIVPIzddep8PPYyK+jv6XtR3SHLuaLhQ8KUZIvf9Z6g+aNcd+BevprdTqs6FlMYRSfclLG47vRCZTT7LgGMnQ8Sp64VMK8TarNPb3n43TFx7t/F8+As1nUTmCwKBrNOMM+8XdAVgyrjfaww2QAPKwcLpd+xDNzVl9lHvgXd5cFshhAA5A6gCl440CXmj7VNBH+wcrJc6VvLlp1xlmCNsGLiLSzDiEMDjZ7OBxU0ORPj1GcPaJzU5aJR3F3bra4WFeMUW1jHuhmxxJaAPjEkiGCFZi2GuI/g5wNKudlnWDTiedw2NNQ+P+WqA4LLlSR86COIDsjKhpfJ7D1kZieF3hIQaOImfkv/wB/zu/3suq3aBQP0UXoiVnwqfdqfg9kvJ8VGJi1zppe/DGXNBwfNIGhTTtE9OCoMr90s9F0QHYcCqlnSZDK3HLq8qw5jkPJCklSCTqd0RSzjVhgembg/baJPb5/zWtZM/cviO8RcSpSobyHZItqaeudGqaLhix3xd/GTZQer7y+Z2lOqnepxBbO40aOcWdHifyFUnv8vpWWFBoEUGRMeBiAIDUedV+B8JsXcBA6JXl+EPN2WGwbne/40kIxGuUgapE6yrKNBmBAKgteRlDjtQyHGrPmJd0ZymiwZPr2SkUJfQwcCv3P1G+5gX6RYbS6b7EYzxlAoX0Z6Mysfg0GLzU3sdL0CXbVLvoSOMUZhT5jryGtw2QQ0N7cI68Du4yj5IiRKwmkbyFu9Fia9VZC94jmWJ16fUSHX8vRptNqz5P1xm9tPIiRRYCMUTRJAJmmGZIGjhbEj2MN4LSO5qRb+1c0TQ0NLAAj1jsvDTG7dvrXEdnyLP82JBIJajZTJl9VCVebJ+qPWjEx8iz9pQHH9m+bWguDRa9ZOf7spqHC/EaUdPru JEjTk6A3 Bto/L8xAtfgNzWPSQBK68NkmQxSxg9FwLMGax1xZ8MrwSzohXlq+jexwd6QiIAwK1BZCg7Pg7lt735MFKnvKBh3BjfNfDId8HzFfPcxoVTNROQVWiuvqIm1ywmokqJZoeL3HhiMpdBFzPr/Ty2uHfg/CwTcI0XUK4VyvCKSXk8SsY8cajmn/+Yt9FF2TauJ+mWjj/yLkTqPmlYt+2bOwjBRaYr6cajep3k339iflOKGDnUCFbSx8zl7TCIzZhlJPhg3fDQdwtKxCm9Fem6J1B+uJcPEjRjU8YhwZST6k70dIlwrOC3hcZ728ImxDKyDSioMKxKFzkSUHAWBG9wxqGzqe2sHXhD8lQ0lqmzJKQ3JA8p0T/IOEPBHKSif+xOJIIrTydwNqY+1XYA8P75VhANtFjBree2eWcZsXih3zdcTZleo3TY+mGfoDxyJ+VNM4jJmxiI+Rer3HzIqECxfjtFn5jfUON6Z72CBrWBJdAdlJ7yvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 06, 2024 at 06:25:39PM +0800, Peng Zhang wrote: > From: ZhangPeng > > Use helper function va_size() to improve code readability. No functional > modification involved. > > Signed-off-by: ZhangPeng > --- > mm/vmalloc.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 37b6e987234e..e4c8d0b0f70c 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1940,7 +1940,7 @@ static inline void setup_vmalloc_vm(struct vm_struct *vm, > { > vm->flags = flags; > vm->addr = (void *)va->va_start; > - vm->size = va->va_end - va->va_start; > + vm->size = va_size(va); > vm->caller = caller; > va->vm = vm; > } > @@ -2018,7 +2018,7 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > > if (vm) { > vm->addr = (void *)va->va_start; > - vm->size = va->va_end - va->va_start; > + vm->size = va_size(va); > va->vm = vm; > } > > @@ -2215,7 +2215,7 @@ static void purge_vmap_node(struct work_struct *work) > vn->nr_purged = 0; > > list_for_each_entry_safe(va, n_va, &vn->purge_list, list) { > - unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT; > + unsigned long nr = va_size(va) >> PAGE_SHIFT; > unsigned int vn_id = decode_vn_id(va->flags); > > list_del_init(&va->list); > @@ -2355,8 +2355,8 @@ static void free_vmap_area_noflush(struct vmap_area *va) > if (WARN_ON_ONCE(!list_empty(&va->list))) > return; > > - nr_lazy = atomic_long_add_return((va->va_end - va->va_start) >> > - PAGE_SHIFT, &vmap_lazy_nr); > + nr_lazy = atomic_long_add_return(va_size(va) >> PAGE_SHIFT, > + &vmap_lazy_nr); > > /* > * If it was request by a certain node we would like to > @@ -2952,8 +2952,7 @@ void vm_unmap_ram(const void *mem, unsigned int count) > if (WARN_ON_ONCE(!va)) > return; > > - debug_check_no_locks_freed((void *)va->va_start, > - (va->va_end - va->va_start)); > + debug_check_no_locks_freed((void *)va->va_start, va_size(va)); > free_unmap_vmap_area(va); > } > EXPORT_SYMBOL(vm_unmap_ram); > @@ -4953,7 +4952,7 @@ static void show_purge_info(struct seq_file *m) > list_for_each_entry(va, &vn->lazy.head, list) { > seq_printf(m, "0x%pK-0x%pK %7ld unpurged vm_area\n", > (void *)va->va_start, (void *)va->va_end, > - va->va_end - va->va_start); > + va_size(va)); > } > spin_unlock(&vn->lazy.lock); > } > @@ -4975,7 +4974,7 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > if (va->flags & VMAP_RAM) > seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", > (void *)va->va_start, (void *)va->va_end, > - va->va_end - va->va_start); > + va_size(va)); > > continue; > } > -- > 2.25.1 > LGTM. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki