From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F262CE7AA5 for ; Fri, 6 Sep 2024 01:34:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 795C96B0082; Thu, 5 Sep 2024 21:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71FA76B0085; Thu, 5 Sep 2024 21:34:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E6216B0088; Thu, 5 Sep 2024 21:34:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 426036B0082 for ; Thu, 5 Sep 2024 21:34:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1235140DDB for ; Fri, 6 Sep 2024 01:34:31 +0000 (UTC) X-FDA: 82532593542.12.1F267B3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 5E21E180026 for ; Fri, 6 Sep 2024 01:34:30 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UAW6geP+; spf=pass (imf24.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725586445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vAvlKKvceOHGeQqA3OFijkpOTQ2UoOoCoS22adHsG/U=; b=Sjq/pF+l2vF1mA0B/AcRBdBtIYIh98yYfaodKfmXPWS7vUAjBDpfeIUzPe/2TmKa0/xYb+ +L2m2czafITXU5wRaqlyeDST0bSAsLyNvqSFydm8XelVtdwE/QB9J1vxiFFXwuPVBuCt86 Sc9Ij6G430rZE5Yz+Qx7SUdMxHG+atw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UAW6geP+; spf=pass (imf24.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725586445; a=rsa-sha256; cv=none; b=U2CM7ZgitOCUbHBnj/cWcP7ZtKAJnrWoUYyEas5Fuu6yyVGTNOYJt0HZiKyMYe0AdLN3Zs g3kbfNGZSsvc2iXK2ff5Rg8ODbZM5twN9nJrrqVDzvMqDK37whG7VoM9Hjzu6ikg/rPrQm 6MGu5tJm8ZILJi81yIh2KYGee/MbsT8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2F8C1A431E3; Fri, 6 Sep 2024 01:34:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 931CFC4CEC3; Fri, 6 Sep 2024 01:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725586468; bh=DhY6rGfOlLTMtYFY6JMioPUvjaIkctEMK5oG3sIAKKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UAW6geP+l/1A7xcK1gfy30FPnS/X9eRktTLABf0RTHny7zuS3fUAVgAYxkv9SUrN+ A0v/Ji1O3R34gXq+nFwN4JMqgrxeE6dZDk2AQFFmT4F1LaV5NPXqtNlOB5OtE3gEmz j8WOiiUA4BAK1iisAzWQKVIK2LcBnr/v1qU58sa2D3cFk+jUfDtO6O2k6tgGaZMsLc VakmieRckRYZtwFhd4hN9syttFl2+06L+HqrWM2KTnVv8uxh5r1h2eAaBSJF2sA4og mY128FTnfL9EAO5ai4zKA+a9qfJ3/NnBLn7vcgYtwACUAHY5qlEmIxBNENOU3msnp+ XYfkZBkT4qJ2A== Date: Thu, 5 Sep 2024 15:34:27 -1000 From: Tejun Heo To: Mike Snitzer Cc: Eric Biggers , Mikulas Patocka , dm-devel@lists.linux.dev, Alasdair Kergon , Lai Jiangshan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sami Tolvanen , linux-nfs@vger.kernel.org Subject: Re: sharing rescuer threads when WQ_MEM_RECLAIM needed? [was: Re: dm verity: don't use WQ_MEM_RECLAIM] Message-ID: References: <20240904040444.56070-1-ebiggers@kernel.org> <086a76c4-98da-d9d1-9f2f-6249c3d55fe9@redhat.com> <20240905223555.GA1512@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: qihgnji7gjr7j3mbkoudeutp7wf1knfx X-Rspamd-Queue-Id: 5E21E180026 X-Rspamd-Server: rspam11 X-HE-Tag: 1725586470-899120 X-HE-Meta: U2FsdGVkX1/FTq0jwkZ0PLR0OZMtxpnWy6t36O3aAu6w71prk39GzkQYcaTSy/k1uV9/apE80w+cKq8uk+6kMYdZ8YeuKg/5s1uUIsaIdhwbj+PDIMNeqRlmo/MV470B8WJFSddK9Y6yaCEx+seShanxT0iGf6nHixouv4fouaVm5ttw/UAKrVcpyexTqNkeFasM+1KvsA/uu42yRTgsXXSEXKWSV4LDfokPcozlac7XcRtx+umc5E+HiQ0XR7iAiVVuiTD+m8PumXgaLPa8vdbJaiQ587aIRaxXtFtoWN467qSBMXCsDr2ajsJ8DjiKKxSOrO7Q6c09Jdc/VAW18N9sQjAaVhQ8RuRL7II9MLKP5pvVdDjnTOdC2QPdcmsoBueMxDmiQLMT0PK82Gh/ycs+cRgStZ2xwg2E+9aLB2GLaaZORFW/+i95H+j9/JGqRD9dNMQvz+7wnQPDNV8OEiwhSCSOvNAIzsJOyRkT0lM1U6DrivLHvZi5SFB1j4xyjPaUE+13mI7X7V2OfD0lq1C8qm8lt8pyh6XwCpYMRrmShLvrTNPgHgD0KHhJQ0qpbwLCnpvnrp1CK2hUu2Z7cxHuFyj2Lx4TW64kT6Mk0qNj1m6PbazAnkHp7znd+39pUeTJaw6mv34SIrz+OSOUPSzCPli11Ju0zVPFwGukyN+Ziq6KMIrmgAkMDGm/ZGF1sKeYDG2CnZ784zqY1sGMzixJY2fW+QqmEqYUwyaxcDGJ13Bov1WuHcjl+HgTzogFMIyrl/6E9AsR6hNgYkjeZcSAK+mYug+TT4KyUIuPtVFw8Vb5yC1HnHxvRUu7SlLBiBsfu0U2yDeHBJXS5Z7B+4/IcKeAY7tNroj+W7HpRLx/vA/uUAN5cTctYVQ2FUtAWXSxIecocDWE1+FcdZbBRd2y/xJizzeK3CqVA7hAP5Kajw1cHogMl112iUuDHQUkpB/7SRPQ4Cw+FmcrABv BN6AIunF NF4d0g72Ux8it8v+1iI9PoWMXjzRGUoeO5hNQ92AC3A3XP2/XxGnUnCbEUblV1nn3RPc+8KpGf4JI3IAIyvh79hgT+SLxEcqWvXK35UvxBXvCTxFjLegK9F4mldL/hqGx+gg6b0OIKfetDjfZpQhHkSRtiN6iW2eABnZHCpJF7m0qMUxeXM13AAtSlHIg0oSiR/wivoOpfAX8ZaG1IUFyYGkTsqJtSYUvdKEnLLEBtCtT8id0k4E8q3VrDoMb1cYAMPoFeEvkN/3pJNDyv5CbSZPYNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, Sep 05, 2024 at 07:35:41PM -0400, Mike Snitzer wrote: ... > > I wonder if there's any way to safely share the rescuer threads. > > Oh, I like that idea, yes please! (would be surprised if it exists, > but I love being surprised!). Like Mikulas pointed out, we have had > to deal with fundamental deadlocks due to resource sharing in DM. > Hence the need for guaranteed forward progress that only > WQ_MEM_RECLAIM can provide. The most straightforward way to do this would be simply sharing the workqueue across the entities that wanna be in the same forward progress guarantee domain. It shouldn't be that difficult to make workqueues share a rescuer either but may be a bit of an overkill. Taking a step back tho, how would you determine which ones can share a rescuer? Things which stack on top of each other can't share the rescuer cuz higher layer occupying the rescuer and stall lower layers and thus deadlock. The rescuers can be shared across independent stacks of dm devices but that sounds like that will probably involve some graph walking. Also, is this a real problem? Thanks. -- tejun