From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C7DCE7AA6 for ; Fri, 6 Sep 2024 00:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C1EA6B0099; Thu, 5 Sep 2024 20:15:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14BF56B009A; Thu, 5 Sep 2024 20:15:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2E3C6B009B; Thu, 5 Sep 2024 20:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D098F6B0099 for ; Thu, 5 Sep 2024 20:15:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9934CA0DAA for ; Fri, 6 Sep 2024 00:15:16 +0000 (UTC) X-FDA: 82532393832.20.3BD75BD Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf02.hostedemail.com (Postfix) with ESMTP id E20008000C for ; Fri, 6 Sep 2024 00:15:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=W3fh84xM; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725581585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5+2Pibvrlz+QfETZflGLoh0C2TJXNiA3gyTi0XyefyY=; b=mmWW/WBLyX7+/cmpLoLq6EWuSE3UE5VqTrUjdpM1PDVE72MVQS1rChnHv1ZoOTAqKVFXEH jE2LSZtGiut2+1ZxAknrSOPfyzdpbaG6J7YcuuvlOw3OAspJLRLalHkQXmSYlPzG8fOoiE c98k9A9dsFySzoEovT/3OaNf6e6Twkw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=W3fh84xM; spf=pass (imf02.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725581585; a=rsa-sha256; cv=none; b=PqctjuCHOIaaT9Qi2mLII70yWu24J/5n83HvFkDONdLa8l+UI+e8pc/eUnf4UHz4qVsOFa gX0igo87V5jpZjWqfJN8t+y++87N1AV+ueA6uH+R5OadxJWqQtA5gGCCKTID0S1l0w32KA LZRVbRYfyGkFnhloYjKrJ8U5bkwtPe0= Date: Fri, 6 Sep 2024 00:15:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725581713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5+2Pibvrlz+QfETZflGLoh0C2TJXNiA3gyTi0XyefyY=; b=W3fh84xMtn9KXwKm+/0pJxoC693OXhkEKaeUDlgiyKADSfFZc1ptotr/eof5p8Avo7DPSN 9tk1XULaBHRSkRjkd1uwaEXGR3H65UjGbM/o+CbuqFiJSvZWP7Qh2f9z5NdVvQAcO3YXgW W6SHz7PF6dppM4cy8/gcWZkQ/Hv+Xr8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , Mike Rapoport , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 02/17] slab: add struct kmem_cache_args Message-ID: References: <20240905-work-kmem_cache_args-v4-0-ed45d5380679@kernel.org> <20240905-work-kmem_cache_args-v4-2-ed45d5380679@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905-work-kmem_cache_args-v4-2-ed45d5380679@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E20008000C X-Stat-Signature: xpka8g1nxw1tps36gdtaig33ek9qhjmy X-Rspam-User: X-HE-Tag: 1725581714-181960 X-HE-Meta: U2FsdGVkX19UqI3wBuBKFJDPkCPxkFwNCoKXepvP8AyQfywhA8gPoB9wEtfxSS8yYZJm5jmV9kpzAbC1NzAzc7wm819mwS7c8wbY0sSjEDYjUyW8p+QIzVZ+WVGKeeRfg9ZfmR7VOj2pPK3pnQvCW5SnVWgvtFm8H72C/SaeCrqlux6T21MKgkkMtPRa7ZploDjqlpMtTYwb0eKEkc8DsuuKprP4mZQRdB+O9KU5kLO+f8KWlvKqlXLoGB6qrgtYuFjq4nPHuP3c2lUYIDatfd5TpYMKgGL/5k2Vp7lfgTid8Q10dy5raTlF8VqWm6qTgp2VD04ptBk9JOWzi94xh6JVLAQKDgqyArsqoyoN+XHwLmi+wbnvpZ8qKgyWwH8RSjAMeChI5OTiewU634E5rgkzCmYnIHyfJ8n262GtOWV9mjqPProFStPoOSWFp4BssFE7At3P1AjDJf+iExq8VweOB6+f3YtTCq+6tKApXWc3R2fdtmKrV5QFNccnQtnTDPtjrR76PA75HLY7xY8kaTtFFDTnCf7Mdrzue8FxjTeicgL6Efitry08AnmYZd74xqfBFuMjFo+RdMkAO1z9lolqy6nbPygCuiPGReuCV30kgij7377gp03pLkn2etkug4OddgqOYxDa9kiIq6b3NmtioLNtlDD8EhPd7WUKu2St4I9u2qY7vLo27kf0pJ0AwrQPx+qLSLIGFMc29X8m/8vMfbKMaBOjSJD+edmBStCfYIKkY7OgRB3WpNjmEkiM2mxW8p4X+9wpba6zyZxLf5mPtxFTfJ72J5wAmd8kDS2h1peTXm2Fp8B95gwNv/qdlPvaTjAoZdLo3T/Sc8t+KGwwQZY5Pmco9fDjKllRdGgexzYhysc4EarYoV3Cat12KJnokQ87c7BedQ53tTiVq6FBRW3UEgxEXYxLLVIHOntPAGyhJD4vK3zkcsAI4Rl4SU+TdmhEsdM2/jOaiTu aGw5sCmY 3bc0m9LeRDtTVhOkJ/kfvUHFJYgMbsA8IYaQZl9nBs8Rn1nczSbf6WsR7DuK8xdHfEOA9raChJI6Ppqyj5YSBt2mzNi7CqWjZsRhAyA1ECEh0Oun4oN3FfJ4bbLtKOiFD3B/cPZ+pCdCYutviiZzbIcPZllodsnaq6diSZ4ZFCbpsKAXqYt06gR+oXXWe7Lm+uhc7Who3Ns1h+P7nuBxOBEQOFD9DkZ0y7r3a94PVqgs9n2zcC0n9nka2fPSgFi42tqpGn1hCvUfMwdvejQlo/tAGhNXoUHxBiq1NpzwCVmrlHsqIxGjibNMOum8umUWVt4EtSF2yM88ogubNKR82LH2qU6sYl6pOmFpcJXBJGXaGBM4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 09:56:45AM +0200, Christian Brauner wrote: > Currently we have multiple kmem_cache_create*() variants that take up to > seven separate parameters with one of the functions having to grow an > eigth parameter in the future to handle both usercopy and a custom > freelist pointer. > > Add a struct kmem_cache_args structure and move less common parameters > into it. Core parameters such as name, object size, and flags continue > to be passed separately. > > Add a new function __kmem_cache_create_args() that takes a struct > kmem_cache_args pointer and port do_kmem_cache_create_usercopy() over to > it. > > In follow-up patches we will port the other kmem_cache_create*() > variants over to it as well. > > Reviewed-by: Kees Cook > Reviewed-by: Jens Axboe > Reviewed-by: Mike Rapoport (Microsoft) > Reviewed-by: Vlastimil Babka > Signed-off-by: Christian Brauner Reviewed-by: Roman Gushchin